You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2017/11/16 09:27:41 UTC

[GitHub] flink pull request #5022: [FLINK-7389] [table] Remove Calcite PushProjector

GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/5022

    [FLINK-7389] [table] Remove Calcite PushProjector

    ## What is the purpose of the change
    
    Removes copied Calcite class `PushProjector`. All tests are successful.
    
    ## Brief change log
    
    Removed class.
    
    
    ## Verifying this change
    
    Modified some existing tests.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? not applicable


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-7389

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5022.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5022
    
----
commit 3202dbedfeec2919eab4ccd055b04fa74292e96c
Author: twalthr <tw...@apache.org>
Date:   2017-11-16T09:20:16Z

    [FLINK-7389] [table] Remove Calcite PushProjector

----


---

[GitHub] flink pull request #5022: [FLINK-7389] [table] Remove Calcite PushProjector

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5022


---

[GitHub] flink issue #5022: [FLINK-7389] [table] Remove Calcite PushProjector

Posted by fhueske <gi...@git.apache.org>.

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/5022
  
    LGTM
    +1 to merge


---

[GitHub] flink issue #5022: [FLINK-7389] [table] Remove Calcite PushProjector

Posted by fhueske <gi...@git.apache.org>.

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/5022
  
    will merge this


---