You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2023/04/20 08:52:27 UTC
[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #1442: [CELEBORN-532][METRICS] Refine push-related failure metrics
AngersZhuuuu opened a new pull request, #1442:
URL: https://github.com/apache/incubator-celeborn/pull/1442
### What changes were proposed in this pull request?
Current metrics is confused, make it clear and more detail
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1442: [CELEBORN-532][METRICS] Refine push-related failure metrics
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1442:
URL: https://github.com/apache/incubator-celeborn/pull/1442#issuecomment-1517313288
> Should update Grafana dashboard as well?
I didn't use the same dashboard.. don't know how to update the Grafana dashboard..
cc @FMX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1442: [CELEBORN-532][METRICS] Refine push-related failure metrics
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1442:
URL: https://github.com/apache/incubator-celeborn/pull/1442#issuecomment-1517205899
ping @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1442: [CELEBORN-532][METRICS] Refine push-related failure metrics
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1442:
URL: https://github.com/apache/incubator-celeborn/pull/1442#issuecomment-1517229497
Should update Grafana dashboard as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu merged pull request #1442: [CELEBORN-532][METRICS] Refine push-related failure metrics
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu merged PR #1442:
URL: https://github.com/apache/incubator-celeborn/pull/1442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1442: [CELEBORN-532][METRICS] Refine push-related failure metrics
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1442:
URL: https://github.com/apache/incubator-celeborn/pull/1442#issuecomment-1515962795
ping @FMX @waitinfuture
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1442: [CELEBORN-532][METRICS] Refine push-related failure metrics
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1442:
URL: https://github.com/apache/incubator-celeborn/pull/1442#issuecomment-1516005448
## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1442?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1442](https://codecov.io/gh/apache/incubator-celeborn/pull/1442?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe60ec7) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/6378a386d04e57325af082b324bfd7069416080f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6378a38) will **increase** coverage by `0.15%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1442 +/- ##
==========================================
+ Coverage 44.76% 44.91% +0.15%
==========================================
Files 156 156
Lines 9572 9572
Branches 956 956
==========================================
+ Hits 4284 4298 +14
+ Misses 5005 4993 -12
+ Partials 283 281 -2
```
[see 1 file with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1442/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org