You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Chia-Ping Tsai <ch...@apache.org> on 2018/07/05 14:45:01 UTC
[VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde
hi all,
I would like to start voting on "KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde"
https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
Cheers,
Chia-Ping
Re: [VOTE] KIP-331 Add default implementation to close() and
configure() for Serializer, Deserializer and Serde
Posted by John Roesler <jo...@confluent.io>.
Thank you!
I'm +1 (non-binding)
On Thu, Jul 5, 2018 at 10:24 PM Richard Yu <yr...@yahoo.com.invalid>
wrote:
> Nice KIP!
> +1 (non-binding)
> -Richard
>
> On Friday, July 6, 2018, 9:10:43 AM GMT+8, Matthias J. Sax <
> matthias@confluent.io> wrote:
>
> Thanks for the KIP!
>
> +1 (binding)
>
>
> -Matthias
>
> On 7/5/18 7:45 AM, Chia-Ping Tsai wrote:
> > hi all,
> >
> > I would like to start voting on "KIP-331 Add default implementation to
> close() and configure() for Serializer, Deserializer and Serde"
> >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
> >
> > Cheers,
> > Chia-Ping
> >
>
Re: [VOTE] KIP-331 Add default implementation to close() and
configure() for Serializer, Deserializer and Serde
Posted by Richard Yu <yr...@yahoo.com.INVALID>.
Nice KIP!
+1 (non-binding)
-Richard
On Friday, July 6, 2018, 9:10:43 AM GMT+8, Matthias J. Sax <ma...@confluent.io> wrote:
Thanks for the KIP!
+1 (binding)
-Matthias
On 7/5/18 7:45 AM, Chia-Ping Tsai wrote:
> hi all,
>
> I would like to start voting on "KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde"
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
>
> Cheers,
> Chia-Ping
>
Re: [VOTE] KIP-331 Add default implementation to close() and
configure() for Serializer, Deserializer and Serde
Posted by "Matthias J. Sax" <ma...@confluent.io>.
Thanks for the KIP!
+1 (binding)
-Matthias
On 7/5/18 7:45 AM, Chia-Ping Tsai wrote:
> hi all,
>
> I would like to start voting on "KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde"
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
>
> Cheers,
> Chia-Ping
>
Re: [VOTE] KIP-331 Add default implementation to close() and
configure() for Serializer, Deserializer and Serde
Posted by Damian Guy <da...@gmail.com>.
Thanks +1 binding
On Sun, 7 Oct 2018 at 03:16, Chia-Ping Tsai <ch...@apache.org> wrote:
> (just bump)
>
> We have following votes:
>
> non-binding
> 1. John Roesler
> 2. vito jeng
> 3. Richard Yu
> 4. Bill Bejeck
> 5. Satish Duggana
>
> binding
> 1. Matthias J. Sax
> 2. Ismael Juma
>
> it needs one more ticket :)
>
> Cheers,
> Chia-Ping
>
> On 2018/07/05 14:45:01, Chia-Ping Tsai <ch...@apache.org> wrote:
> > hi all,
> >
> > I would like to start voting on "KIP-331 Add default implementation to
> close() and configure() for Serializer, Deserializer and Serde"
> >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
> >
> > Cheers,
> > Chia-Ping
> >
>
Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde
Posted by Chia-Ping Tsai <ch...@apache.org>.
(just bump)
We have following votes:
non-binding
1. John Roesler
2. vito jeng
3. Richard Yu
4. Bill Bejeck
5. Satish Duggana
binding
1. Matthias J. Sax
2. Ismael Juma
it needs one more ticket :)
Cheers,
Chia-Ping
On 2018/07/05 14:45:01, Chia-Ping Tsai <ch...@apache.org> wrote:
> hi all,
>
> I would like to start voting on "KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde"
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
>
> Cheers,
> Chia-Ping
>
Re: [VOTE] KIP-331 Add default implementation to close() and
configure() for Serializer, Deserializer and Serde
Posted by vito jeng <vi...@is-land.com.tw>.
Thanks for the KIP!
+1(non-binding)
---
Vito
On Sat, Jul 7, 2018 at 11:29 AM, Chia-Ping Tsai <ch...@apache.org> wrote:
> hi Ismael
>
> > I think we should be thinking about
> > https://issues.apache.org/jira/browse/KAFKA-6923 at the same time.
>
> you are right. KAFKA-6923 and KAFKA-6161 are the keys to complete the
> Serializer and Deserializer. Let us add the default implementations first
> (KAFKA-6161). And then integrate the ExtendedSerializer/ExtendedDeSerializer
> to Serializer/Deserialize (KAFKA-6923)
>
> --
> Chia-Ping
>
> On 2018/07/06 15:33:18, Ismael Juma <is...@gmail.com> wrote:
> > Thanks for the KIP. I think we should be thinking about
> > https://issues.apache.org/jira/browse/KAFKA-6923 at the same time.
> >
> > Ismael
> >
> > On Thu, 5 Jul 2018, 07:45 Chia-Ping Tsai, <ch...@apache.org> wrote:
> >
> > > hi all,
> > >
> > > I would like to start voting on "KIP-331 Add default implementation to
> > > close() and configure() for Serializer, Deserializer and Serde"
> > >
> > >
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+
> implementation+to+close%28%29+and+configure%28%29+for+
> Serializer%2C+Deserializer+and+Serde
> > >
> > > Cheers,
> > > Chia-Ping
> > >
> >
>
Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde
Posted by Chia-Ping Tsai <ch...@apache.org>.
hi Ismael
> I think we should be thinking about
> https://issues.apache.org/jira/browse/KAFKA-6923 at the same time.
you are right. KAFKA-6923 and KAFKA-6161 are the keys to complete the Serializer and Deserializer. Let us add the default implementations first (KAFKA-6161). And then integrate the ExtendedSerializer/ExtendedDeSerializer to Serializer/Deserialize (KAFKA-6923)
--
Chia-Ping
On 2018/07/06 15:33:18, Ismael Juma <is...@gmail.com> wrote:
> Thanks for the KIP. I think we should be thinking about
> https://issues.apache.org/jira/browse/KAFKA-6923 at the same time.
>
> Ismael
>
> On Thu, 5 Jul 2018, 07:45 Chia-Ping Tsai, <ch...@apache.org> wrote:
>
> > hi all,
> >
> > I would like to start voting on "KIP-331 Add default implementation to
> > close() and configure() for Serializer, Deserializer and Serde"
> >
> >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
> >
> > Cheers,
> > Chia-Ping
> >
>
Re: [VOTE] KIP-331 Add default implementation to close() and
configure() for Serializer, Deserializer and Serde
Posted by Ismael Juma <is...@gmail.com>.
Thanks for the KIP. I think we should be thinking about
https://issues.apache.org/jira/browse/KAFKA-6923 at the same time.
Ismael
On Thu, 5 Jul 2018, 07:45 Chia-Ping Tsai, <ch...@apache.org> wrote:
> hi all,
>
> I would like to start voting on "KIP-331 Add default implementation to
> close() and configure() for Serializer, Deserializer and Serde"
>
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
>
> Cheers,
> Chia-Ping
>
Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde
Posted by Chia-Ping Tsai <ch...@apache.org>.
> Part of the motivation for this KIP is to make these interfaces functional
> interfaces. But I think that may not be desirable due to the method that
> passes headers. So, it doesn't make sense to discuss two separate changes
> to the same interfaces in isolation, we should figure out how we want them
> to work holistically.
Got it. Let us keep the discussion in KIP-336.
[1] https://lists.apache.org/thread.html/21155b13ef88bb04ae084d5c62a72fdecf8851ebf9a7fa2da0215d96@%3Cdev.kafka.apache.org%3E
On 2018/07/20 10:56:59, Ismael Juma <is...@juma.me.uk> wrote:
> Part of the motivation for this KIP is to make these interfaces functional
> interfaces. But I think that may not be desirable due to the method that
> passes headers. So, it doesn't make sense to discuss two separate changes
> to the same interfaces in isolation, we should figure out how we want them
> to work holistically.
>
> Ismael
>
> On Fri, Jul 20, 2018 at 3:50 AM Chia-Ping Tsai <ch...@apache.org> wrote:
>
> > > The KIP needs 3 binding votes to pass.
> >
> > Thanks for the reminder. I will reopen the ballot box until we get 3
> > tickets.
> >
> > > I still think we should include the details of how things will look like
> > > with the headers being passed to serializers/deserializers to ensure
> > > things actually make sense as a whole.
> >
> > This KIP is unrelated to the both methods - serialize() and deserialize().
> > We won't add the default implementation to them in this kip. Please correct
> > me if I didn't catch what you said.
> >
> > Cheers,
> > Chia-Ping
> >
> > On 2018/07/09 01:55:41, Ismael Juma <is...@gmail.com> wrote:
> > > The KIP needs 3 binding votes to pass. I still think we should include
> > the
> > > details of how things will look like with the headers being passed to
> > > serializers/deserializers to ensure things actually make sense as a
> > whole.
> > >
> > > Ismael
> > >
> > >
> > > On Sun, 8 Jul 2018, 18:31 Chia-Ping Tsai, <ch...@apache.org> wrote:
> > >
> > > > All,
> > > >
> > > > The 72 hours has passed. The vote result of KIP-313 is shown below.
> > > >
> > > > 1 binding vote (Matthias J. Sax)
> > > > 4 non-binding votes (John Roesler, Richard Yu, vito jeng and Chia-Ping)
> > > >
> > > > Cheers,
> > > > Chia-Ping
> > > >
> > > > On 2018/07/05 14:45:01, Chia-Ping Tsai <ch...@apache.org> wrote:
> > > > > hi all,
> > > > >
> > > > > I would like to start voting on "KIP-331 Add default implementation
> > to
> > > > close() and configure() for Serializer, Deserializer and Serde"
> > > > >
> > > > >
> > > >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
> > > > >
> > > > > Cheers,
> > > > > Chia-Ping
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] KIP-331 Add default implementation to close() and
configure() for Serializer, Deserializer and Serde
Posted by Satish Duggana <sa...@gmail.com>.
Thanks for the KIP! +1 (non-binding)
On Tue, Sep 25, 2018 at 1:38 PM, Ismael Juma <is...@juma.me.uk> wrote:
> Thanks, +1 (binding).
>
> Ismael
>
> On Thu, Sep 20, 2018 at 8:12 PM Chia-Ping Tsai <ch...@apache.org> wrote:
>
>> KIP-336[1] has been merged so it is time to activate this thread
>> (KIP-331[2]). Last discussion is about "Should we add FunctionalInterface
>> annotation to Serializer and Deserializer". In discussion of KIP-336 we
>> mentioned that we probably add the default implementation for headless
>> method later. Hence, adding FunctionalInterface annotation is not suitable
>> now.
>>
>> KIP-331 has removed the change of adding FunctionalInterface annotation.
>> Please take a look again.
>>
>> [1]
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87298242
>> [2]
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
>>
>> Cheers,
>> Chia-Ping
>>
>>
>> On 2018/07/20 10:56:59, Ismael Juma <is...@juma.me.uk> wrote:
>> > Part of the motivation for this KIP is to make these interfaces
>> functional
>> > interfaces. But I think that may not be desirable due to the method that
>> > passes headers. So, it doesn't make sense to discuss two separate changes
>> > to the same interfaces in isolation, we should figure out how we want
>> them
>> > to work holistically.
>> >
>> > Ismael
>> >
>> > On Fri, Jul 20, 2018 at 3:50 AM Chia-Ping Tsai <ch...@apache.org>
>> wrote:
>> >
>> > > > The KIP needs 3 binding votes to pass.
>> > >
>> > > Thanks for the reminder. I will reopen the ballot box until we get 3
>> > > tickets.
>> > >
>> > > > I still think we should include the details of how things will look
>> like
>> > > > with the headers being passed to serializers/deserializers to ensure
>> > > > things actually make sense as a whole.
>> > >
>> > > This KIP is unrelated to the both methods - serialize() and
>> deserialize().
>> > > We won't add the default implementation to them in this kip. Please
>> correct
>> > > me if I didn't catch what you said.
>> > >
>> > > Cheers,
>> > > Chia-Ping
>> > >
>> > > On 2018/07/09 01:55:41, Ismael Juma <is...@gmail.com> wrote:
>> > > > The KIP needs 3 binding votes to pass. I still think we should
>> include
>> > > the
>> > > > details of how things will look like with the headers being passed to
>> > > > serializers/deserializers to ensure things actually make sense as a
>> > > whole.
>> > > >
>> > > > Ismael
>> > > >
>> > > >
>> > > > On Sun, 8 Jul 2018, 18:31 Chia-Ping Tsai, <ch...@apache.org>
>> wrote:
>> > > >
>> > > > > All,
>> > > > >
>> > > > > The 72 hours has passed. The vote result of KIP-313 is shown below.
>> > > > >
>> > > > > 1 binding vote (Matthias J. Sax)
>> > > > > 4 non-binding votes (John Roesler, Richard Yu, vito jeng and
>> Chia-Ping)
>> > > > >
>> > > > > Cheers,
>> > > > > Chia-Ping
>> > > > >
>> > > > > On 2018/07/05 14:45:01, Chia-Ping Tsai <ch...@apache.org>
>> wrote:
>> > > > > > hi all,
>> > > > > >
>> > > > > > I would like to start voting on "KIP-331 Add default
>> implementation
>> > > to
>> > > > > close() and configure() for Serializer, Deserializer and Serde"
>> > > > > >
>> > > > > >
>> > > > >
>> > >
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
>> > > > > >
>> > > > > > Cheers,
>> > > > > > Chia-Ping
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>>
Re: [VOTE] KIP-331 Add default implementation to close() and
configure() for Serializer, Deserializer and Serde
Posted by Ismael Juma <is...@juma.me.uk>.
Thanks, +1 (binding).
Ismael
On Thu, Sep 20, 2018 at 8:12 PM Chia-Ping Tsai <ch...@apache.org> wrote:
> KIP-336[1] has been merged so it is time to activate this thread
> (KIP-331[2]). Last discussion is about "Should we add FunctionalInterface
> annotation to Serializer and Deserializer". In discussion of KIP-336 we
> mentioned that we probably add the default implementation for headless
> method later. Hence, adding FunctionalInterface annotation is not suitable
> now.
>
> KIP-331 has removed the change of adding FunctionalInterface annotation.
> Please take a look again.
>
> [1]
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87298242
> [2]
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
>
> Cheers,
> Chia-Ping
>
>
> On 2018/07/20 10:56:59, Ismael Juma <is...@juma.me.uk> wrote:
> > Part of the motivation for this KIP is to make these interfaces
> functional
> > interfaces. But I think that may not be desirable due to the method that
> > passes headers. So, it doesn't make sense to discuss two separate changes
> > to the same interfaces in isolation, we should figure out how we want
> them
> > to work holistically.
> >
> > Ismael
> >
> > On Fri, Jul 20, 2018 at 3:50 AM Chia-Ping Tsai <ch...@apache.org>
> wrote:
> >
> > > > The KIP needs 3 binding votes to pass.
> > >
> > > Thanks for the reminder. I will reopen the ballot box until we get 3
> > > tickets.
> > >
> > > > I still think we should include the details of how things will look
> like
> > > > with the headers being passed to serializers/deserializers to ensure
> > > > things actually make sense as a whole.
> > >
> > > This KIP is unrelated to the both methods - serialize() and
> deserialize().
> > > We won't add the default implementation to them in this kip. Please
> correct
> > > me if I didn't catch what you said.
> > >
> > > Cheers,
> > > Chia-Ping
> > >
> > > On 2018/07/09 01:55:41, Ismael Juma <is...@gmail.com> wrote:
> > > > The KIP needs 3 binding votes to pass. I still think we should
> include
> > > the
> > > > details of how things will look like with the headers being passed to
> > > > serializers/deserializers to ensure things actually make sense as a
> > > whole.
> > > >
> > > > Ismael
> > > >
> > > >
> > > > On Sun, 8 Jul 2018, 18:31 Chia-Ping Tsai, <ch...@apache.org>
> wrote:
> > > >
> > > > > All,
> > > > >
> > > > > The 72 hours has passed. The vote result of KIP-313 is shown below.
> > > > >
> > > > > 1 binding vote (Matthias J. Sax)
> > > > > 4 non-binding votes (John Roesler, Richard Yu, vito jeng and
> Chia-Ping)
> > > > >
> > > > > Cheers,
> > > > > Chia-Ping
> > > > >
> > > > > On 2018/07/05 14:45:01, Chia-Ping Tsai <ch...@apache.org>
> wrote:
> > > > > > hi all,
> > > > > >
> > > > > > I would like to start voting on "KIP-331 Add default
> implementation
> > > to
> > > > > close() and configure() for Serializer, Deserializer and Serde"
> > > > > >
> > > > > >
> > > > >
> > >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
> > > > > >
> > > > > > Cheers,
> > > > > > Chia-Ping
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] KIP-331 Add default implementation to close() and
configure() for Serializer, Deserializer and Serde
Posted by John Roesler <jo...@confluent.io>.
Thanks for the reply.
I think my question may have been ambiguous.
I was confirming that there would be just one method *without* a default
implementation, and therefore that the lambda I quoted would actually work.
Thanks,
-John
On Sun, Sep 23, 2018 at 10:53 AM Chia-Ping Tsai <ch...@apache.org> wrote:
> > This means that I could supply a serializer like this: "(topic, myData)
> ->
> > myData.toByteArrayOrWhatever()", right? (and of course similar for
> > deserializers).
>
> That code will work well if KIP-331 is merged. However, the lambda
> expressions will fail if we add default implementation to all methods of
> Serializer (ditto for Deserializer). KIP-336 had discussed such changes
> which may happen in the future. That is why KIP-331 doesn't add
> FunctionalInterface annotation to Serialize and Deserializer.
>
> Cheers,
> chia-ping
>
> On 2018/09/21 21:57:51, John Roesler <jo...@confluent.io> wrote:
> > If I understand the way that this works in light of KIP-331, all the
> > methods of Serializer, for example, will have defaults except for :
> "byte[]
> > serialize(String topic, T data);"
> >
> > This means that I could supply a serializer like this: "(topic, myData)
> ->
> > myData.toByteArrayOrWhatever()", right? (and of course similar for
> > deserializers).
> >
> > This sounds right to me, so if that is right, I'm still a non-binding +1.
> >
> > Thanks,
> > -John
> >
> > On Thu, Sep 20, 2018 at 10:12 PM Chia-Ping Tsai <ch...@apache.org>
> wrote:
> >
> > > KIP-336[1] has been merged so it is time to activate this thread
> > > (KIP-331[2]). Last discussion is about "Should we add
> FunctionalInterface
> > > annotation to Serializer and Deserializer". In discussion of KIP-336 we
> > > mentioned that we probably add the default implementation for headless
> > > method later. Hence, adding FunctionalInterface annotation is not
> suitable
> > > now.
> > >
> > > KIP-331 has removed the change of adding FunctionalInterface
> annotation.
> > > Please take a look again.
> > >
> > > [1]
> > >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87298242
> > > [2]
> > >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
> > >
> > > Cheers,
> > > Chia-Ping
> > >
> > >
> > > On 2018/07/20 10:56:59, Ismael Juma <is...@juma.me.uk> wrote:
> > > > Part of the motivation for this KIP is to make these interfaces
> > > functional
> > > > interfaces. But I think that may not be desirable due to the method
> that
> > > > passes headers. So, it doesn't make sense to discuss two separate
> changes
> > > > to the same interfaces in isolation, we should figure out how we want
> > > them
> > > > to work holistically.
> > > >
> > > > Ismael
> > > >
> > > > On Fri, Jul 20, 2018 at 3:50 AM Chia-Ping Tsai <ch...@apache.org>
> > > wrote:
> > > >
> > > > > > The KIP needs 3 binding votes to pass.
> > > > >
> > > > > Thanks for the reminder. I will reopen the ballot box until we get
> 3
> > > > > tickets.
> > > > >
> > > > > > I still think we should include the details of how things will
> look
> > > like
> > > > > > with the headers being passed to serializers/deserializers to
> ensure
> > > > > > things actually make sense as a whole.
> > > > >
> > > > > This KIP is unrelated to the both methods - serialize() and
> > > deserialize().
> > > > > We won't add the default implementation to them in this kip. Please
> > > correct
> > > > > me if I didn't catch what you said.
> > > > >
> > > > > Cheers,
> > > > > Chia-Ping
> > > > >
> > > > > On 2018/07/09 01:55:41, Ismael Juma <is...@gmail.com> wrote:
> > > > > > The KIP needs 3 binding votes to pass. I still think we should
> > > include
> > > > > the
> > > > > > details of how things will look like with the headers being
> passed to
> > > > > > serializers/deserializers to ensure things actually make sense
> as a
> > > > > whole.
> > > > > >
> > > > > > Ismael
> > > > > >
> > > > > >
> > > > > > On Sun, 8 Jul 2018, 18:31 Chia-Ping Tsai, <ch...@apache.org>
> > > wrote:
> > > > > >
> > > > > > > All,
> > > > > > >
> > > > > > > The 72 hours has passed. The vote result of KIP-313 is shown
> below.
> > > > > > >
> > > > > > > 1 binding vote (Matthias J. Sax)
> > > > > > > 4 non-binding votes (John Roesler, Richard Yu, vito jeng and
> > > Chia-Ping)
> > > > > > >
> > > > > > > Cheers,
> > > > > > > Chia-Ping
> > > > > > >
> > > > > > > On 2018/07/05 14:45:01, Chia-Ping Tsai <ch...@apache.org>
> > > wrote:
> > > > > > > > hi all,
> > > > > > > >
> > > > > > > > I would like to start voting on "KIP-331 Add default
> > > implementation
> > > > > to
> > > > > > > close() and configure() for Serializer, Deserializer and Serde"
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > >
> > >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
> > > > > > > >
> > > > > > > > Cheers,
> > > > > > > > Chia-Ping
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde
Posted by Chia-Ping Tsai <ch...@apache.org>.
> This means that I could supply a serializer like this: "(topic, myData) ->
> myData.toByteArrayOrWhatever()", right? (and of course similar for
> deserializers).
That code will work well if KIP-331 is merged. However, the lambda expressions will fail if we add default implementation to all methods of Serializer (ditto for Deserializer). KIP-336 had discussed such changes which may happen in the future. That is why KIP-331 doesn't add FunctionalInterface annotation to Serialize and Deserializer.
Cheers,
chia-ping
On 2018/09/21 21:57:51, John Roesler <jo...@confluent.io> wrote:
> If I understand the way that this works in light of KIP-331, all the
> methods of Serializer, for example, will have defaults except for : "byte[]
> serialize(String topic, T data);"
>
> This means that I could supply a serializer like this: "(topic, myData) ->
> myData.toByteArrayOrWhatever()", right? (and of course similar for
> deserializers).
>
> This sounds right to me, so if that is right, I'm still a non-binding +1.
>
> Thanks,
> -John
>
> On Thu, Sep 20, 2018 at 10:12 PM Chia-Ping Tsai <ch...@apache.org> wrote:
>
> > KIP-336[1] has been merged so it is time to activate this thread
> > (KIP-331[2]). Last discussion is about "Should we add FunctionalInterface
> > annotation to Serializer and Deserializer". In discussion of KIP-336 we
> > mentioned that we probably add the default implementation for headless
> > method later. Hence, adding FunctionalInterface annotation is not suitable
> > now.
> >
> > KIP-331 has removed the change of adding FunctionalInterface annotation.
> > Please take a look again.
> >
> > [1]
> > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87298242
> > [2]
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
> >
> > Cheers,
> > Chia-Ping
> >
> >
> > On 2018/07/20 10:56:59, Ismael Juma <is...@juma.me.uk> wrote:
> > > Part of the motivation for this KIP is to make these interfaces
> > functional
> > > interfaces. But I think that may not be desirable due to the method that
> > > passes headers. So, it doesn't make sense to discuss two separate changes
> > > to the same interfaces in isolation, we should figure out how we want
> > them
> > > to work holistically.
> > >
> > > Ismael
> > >
> > > On Fri, Jul 20, 2018 at 3:50 AM Chia-Ping Tsai <ch...@apache.org>
> > wrote:
> > >
> > > > > The KIP needs 3 binding votes to pass.
> > > >
> > > > Thanks for the reminder. I will reopen the ballot box until we get 3
> > > > tickets.
> > > >
> > > > > I still think we should include the details of how things will look
> > like
> > > > > with the headers being passed to serializers/deserializers to ensure
> > > > > things actually make sense as a whole.
> > > >
> > > > This KIP is unrelated to the both methods - serialize() and
> > deserialize().
> > > > We won't add the default implementation to them in this kip. Please
> > correct
> > > > me if I didn't catch what you said.
> > > >
> > > > Cheers,
> > > > Chia-Ping
> > > >
> > > > On 2018/07/09 01:55:41, Ismael Juma <is...@gmail.com> wrote:
> > > > > The KIP needs 3 binding votes to pass. I still think we should
> > include
> > > > the
> > > > > details of how things will look like with the headers being passed to
> > > > > serializers/deserializers to ensure things actually make sense as a
> > > > whole.
> > > > >
> > > > > Ismael
> > > > >
> > > > >
> > > > > On Sun, 8 Jul 2018, 18:31 Chia-Ping Tsai, <ch...@apache.org>
> > wrote:
> > > > >
> > > > > > All,
> > > > > >
> > > > > > The 72 hours has passed. The vote result of KIP-313 is shown below.
> > > > > >
> > > > > > 1 binding vote (Matthias J. Sax)
> > > > > > 4 non-binding votes (John Roesler, Richard Yu, vito jeng and
> > Chia-Ping)
> > > > > >
> > > > > > Cheers,
> > > > > > Chia-Ping
> > > > > >
> > > > > > On 2018/07/05 14:45:01, Chia-Ping Tsai <ch...@apache.org>
> > wrote:
> > > > > > > hi all,
> > > > > > >
> > > > > > > I would like to start voting on "KIP-331 Add default
> > implementation
> > > > to
> > > > > > close() and configure() for Serializer, Deserializer and Serde"
> > > > > > >
> > > > > > >
> > > > > >
> > > >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
> > > > > > >
> > > > > > > Cheers,
> > > > > > > Chia-Ping
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] KIP-331 Add default implementation to close() and
configure() for Serializer, Deserializer and Serde
Posted by John Roesler <jo...@confluent.io>.
If I understand the way that this works in light of KIP-331, all the
methods of Serializer, for example, will have defaults except for : "byte[]
serialize(String topic, T data);"
This means that I could supply a serializer like this: "(topic, myData) ->
myData.toByteArrayOrWhatever()", right? (and of course similar for
deserializers).
This sounds right to me, so if that is right, I'm still a non-binding +1.
Thanks,
-John
On Thu, Sep 20, 2018 at 10:12 PM Chia-Ping Tsai <ch...@apache.org> wrote:
> KIP-336[1] has been merged so it is time to activate this thread
> (KIP-331[2]). Last discussion is about "Should we add FunctionalInterface
> annotation to Serializer and Deserializer". In discussion of KIP-336 we
> mentioned that we probably add the default implementation for headless
> method later. Hence, adding FunctionalInterface annotation is not suitable
> now.
>
> KIP-331 has removed the change of adding FunctionalInterface annotation.
> Please take a look again.
>
> [1]
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87298242
> [2]
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
>
> Cheers,
> Chia-Ping
>
>
> On 2018/07/20 10:56:59, Ismael Juma <is...@juma.me.uk> wrote:
> > Part of the motivation for this KIP is to make these interfaces
> functional
> > interfaces. But I think that may not be desirable due to the method that
> > passes headers. So, it doesn't make sense to discuss two separate changes
> > to the same interfaces in isolation, we should figure out how we want
> them
> > to work holistically.
> >
> > Ismael
> >
> > On Fri, Jul 20, 2018 at 3:50 AM Chia-Ping Tsai <ch...@apache.org>
> wrote:
> >
> > > > The KIP needs 3 binding votes to pass.
> > >
> > > Thanks for the reminder. I will reopen the ballot box until we get 3
> > > tickets.
> > >
> > > > I still think we should include the details of how things will look
> like
> > > > with the headers being passed to serializers/deserializers to ensure
> > > > things actually make sense as a whole.
> > >
> > > This KIP is unrelated to the both methods - serialize() and
> deserialize().
> > > We won't add the default implementation to them in this kip. Please
> correct
> > > me if I didn't catch what you said.
> > >
> > > Cheers,
> > > Chia-Ping
> > >
> > > On 2018/07/09 01:55:41, Ismael Juma <is...@gmail.com> wrote:
> > > > The KIP needs 3 binding votes to pass. I still think we should
> include
> > > the
> > > > details of how things will look like with the headers being passed to
> > > > serializers/deserializers to ensure things actually make sense as a
> > > whole.
> > > >
> > > > Ismael
> > > >
> > > >
> > > > On Sun, 8 Jul 2018, 18:31 Chia-Ping Tsai, <ch...@apache.org>
> wrote:
> > > >
> > > > > All,
> > > > >
> > > > > The 72 hours has passed. The vote result of KIP-313 is shown below.
> > > > >
> > > > > 1 binding vote (Matthias J. Sax)
> > > > > 4 non-binding votes (John Roesler, Richard Yu, vito jeng and
> Chia-Ping)
> > > > >
> > > > > Cheers,
> > > > > Chia-Ping
> > > > >
> > > > > On 2018/07/05 14:45:01, Chia-Ping Tsai <ch...@apache.org>
> wrote:
> > > > > > hi all,
> > > > > >
> > > > > > I would like to start voting on "KIP-331 Add default
> implementation
> > > to
> > > > > close() and configure() for Serializer, Deserializer and Serde"
> > > > > >
> > > > > >
> > > > >
> > >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
> > > > > >
> > > > > > Cheers,
> > > > > > Chia-Ping
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde
Posted by Chia-Ping Tsai <ch...@apache.org>.
KIP-336[1] has been merged so it is time to activate this thread (KIP-331[2]). Last discussion is about "Should we add FunctionalInterface annotation to Serializer and Deserializer". In discussion of KIP-336 we mentioned that we probably add the default implementation for headless method later. Hence, adding FunctionalInterface annotation is not suitable now.
KIP-331 has removed the change of adding FunctionalInterface annotation. Please take a look again.
[1] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87298242
[2] https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
Cheers,
Chia-Ping
On 2018/07/20 10:56:59, Ismael Juma <is...@juma.me.uk> wrote:
> Part of the motivation for this KIP is to make these interfaces functional
> interfaces. But I think that may not be desirable due to the method that
> passes headers. So, it doesn't make sense to discuss two separate changes
> to the same interfaces in isolation, we should figure out how we want them
> to work holistically.
>
> Ismael
>
> On Fri, Jul 20, 2018 at 3:50 AM Chia-Ping Tsai <ch...@apache.org> wrote:
>
> > > The KIP needs 3 binding votes to pass.
> >
> > Thanks for the reminder. I will reopen the ballot box until we get 3
> > tickets.
> >
> > > I still think we should include the details of how things will look like
> > > with the headers being passed to serializers/deserializers to ensure
> > > things actually make sense as a whole.
> >
> > This KIP is unrelated to the both methods - serialize() and deserialize().
> > We won't add the default implementation to them in this kip. Please correct
> > me if I didn't catch what you said.
> >
> > Cheers,
> > Chia-Ping
> >
> > On 2018/07/09 01:55:41, Ismael Juma <is...@gmail.com> wrote:
> > > The KIP needs 3 binding votes to pass. I still think we should include
> > the
> > > details of how things will look like with the headers being passed to
> > > serializers/deserializers to ensure things actually make sense as a
> > whole.
> > >
> > > Ismael
> > >
> > >
> > > On Sun, 8 Jul 2018, 18:31 Chia-Ping Tsai, <ch...@apache.org> wrote:
> > >
> > > > All,
> > > >
> > > > The 72 hours has passed. The vote result of KIP-313 is shown below.
> > > >
> > > > 1 binding vote (Matthias J. Sax)
> > > > 4 non-binding votes (John Roesler, Richard Yu, vito jeng and Chia-Ping)
> > > >
> > > > Cheers,
> > > > Chia-Ping
> > > >
> > > > On 2018/07/05 14:45:01, Chia-Ping Tsai <ch...@apache.org> wrote:
> > > > > hi all,
> > > > >
> > > > > I would like to start voting on "KIP-331 Add default implementation
> > to
> > > > close() and configure() for Serializer, Deserializer and Serde"
> > > > >
> > > > >
> > > >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
> > > > >
> > > > > Cheers,
> > > > > Chia-Ping
> > > > >
> > > >
> > >
> >
>
Re: [VOTE] KIP-331 Add default implementation to close() and
configure() for Serializer, Deserializer and Serde
Posted by Ismael Juma <is...@juma.me.uk>.
Part of the motivation for this KIP is to make these interfaces functional
interfaces. But I think that may not be desirable due to the method that
passes headers. So, it doesn't make sense to discuss two separate changes
to the same interfaces in isolation, we should figure out how we want them
to work holistically.
Ismael
On Fri, Jul 20, 2018 at 3:50 AM Chia-Ping Tsai <ch...@apache.org> wrote:
> > The KIP needs 3 binding votes to pass.
>
> Thanks for the reminder. I will reopen the ballot box until we get 3
> tickets.
>
> > I still think we should include the details of how things will look like
> > with the headers being passed to serializers/deserializers to ensure
> > things actually make sense as a whole.
>
> This KIP is unrelated to the both methods - serialize() and deserialize().
> We won't add the default implementation to them in this kip. Please correct
> me if I didn't catch what you said.
>
> Cheers,
> Chia-Ping
>
> On 2018/07/09 01:55:41, Ismael Juma <is...@gmail.com> wrote:
> > The KIP needs 3 binding votes to pass. I still think we should include
> the
> > details of how things will look like with the headers being passed to
> > serializers/deserializers to ensure things actually make sense as a
> whole.
> >
> > Ismael
> >
> >
> > On Sun, 8 Jul 2018, 18:31 Chia-Ping Tsai, <ch...@apache.org> wrote:
> >
> > > All,
> > >
> > > The 72 hours has passed. The vote result of KIP-313 is shown below.
> > >
> > > 1 binding vote (Matthias J. Sax)
> > > 4 non-binding votes (John Roesler, Richard Yu, vito jeng and Chia-Ping)
> > >
> > > Cheers,
> > > Chia-Ping
> > >
> > > On 2018/07/05 14:45:01, Chia-Ping Tsai <ch...@apache.org> wrote:
> > > > hi all,
> > > >
> > > > I would like to start voting on "KIP-331 Add default implementation
> to
> > > close() and configure() for Serializer, Deserializer and Serde"
> > > >
> > > >
> > >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
> > > >
> > > > Cheers,
> > > > Chia-Ping
> > > >
> > >
> >
>
Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde
Posted by Chia-Ping Tsai <ch...@apache.org>.
> The KIP needs 3 binding votes to pass.
Thanks for the reminder. I will reopen the ballot box until we get 3 tickets.
> I still think we should include the details of how things will look like
> with the headers being passed to serializers/deserializers to ensure
> things actually make sense as a whole.
This KIP is unrelated to the both methods - serialize() and deserialize(). We won't add the default implementation to them in this kip. Please correct me if I didn't catch what you said.
Cheers,
Chia-Ping
On 2018/07/09 01:55:41, Ismael Juma <is...@gmail.com> wrote:
> The KIP needs 3 binding votes to pass. I still think we should include the
> details of how things will look like with the headers being passed to
> serializers/deserializers to ensure things actually make sense as a whole.
>
> Ismael
>
>
> On Sun, 8 Jul 2018, 18:31 Chia-Ping Tsai, <ch...@apache.org> wrote:
>
> > All,
> >
> > The 72 hours has passed. The vote result of KIP-313 is shown below.
> >
> > 1 binding vote (Matthias J. Sax)
> > 4 non-binding votes (John Roesler, Richard Yu, vito jeng and Chia-Ping)
> >
> > Cheers,
> > Chia-Ping
> >
> > On 2018/07/05 14:45:01, Chia-Ping Tsai <ch...@apache.org> wrote:
> > > hi all,
> > >
> > > I would like to start voting on "KIP-331 Add default implementation to
> > close() and configure() for Serializer, Deserializer and Serde"
> > >
> > >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
> > >
> > > Cheers,
> > > Chia-Ping
> > >
> >
>
Re: [VOTE] KIP-331 Add default implementation to close() and
configure() for Serializer, Deserializer and Serde
Posted by Bill Bejeck <bb...@gmail.com>.
Thanks for the KIP! +1 from me.
-Bill
On Sun, Jul 8, 2018 at 9:55 PM Ismael Juma <is...@gmail.com> wrote:
> The KIP needs 3 binding votes to pass. I still think we should include the
> details of how things will look like with the headers being passed to
> serializers/deserializers to ensure things actually make sense as a whole.
>
> Ismael
>
>
> On Sun, 8 Jul 2018, 18:31 Chia-Ping Tsai, <ch...@apache.org> wrote:
>
> > All,
> >
> > The 72 hours has passed. The vote result of KIP-313 is shown below.
> >
> > 1 binding vote (Matthias J. Sax)
> > 4 non-binding votes (John Roesler, Richard Yu, vito jeng and Chia-Ping)
> >
> > Cheers,
> > Chia-Ping
> >
> > On 2018/07/05 14:45:01, Chia-Ping Tsai <ch...@apache.org> wrote:
> > > hi all,
> > >
> > > I would like to start voting on "KIP-331 Add default implementation to
> > close() and configure() for Serializer, Deserializer and Serde"
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
> > >
> > > Cheers,
> > > Chia-Ping
> > >
> >
>
Re: [VOTE] KIP-331 Add default implementation to close() and
configure() for Serializer, Deserializer and Serde
Posted by Ismael Juma <is...@gmail.com>.
The KIP needs 3 binding votes to pass. I still think we should include the
details of how things will look like with the headers being passed to
serializers/deserializers to ensure things actually make sense as a whole.
Ismael
On Sun, 8 Jul 2018, 18:31 Chia-Ping Tsai, <ch...@apache.org> wrote:
> All,
>
> The 72 hours has passed. The vote result of KIP-313 is shown below.
>
> 1 binding vote (Matthias J. Sax)
> 4 non-binding votes (John Roesler, Richard Yu, vito jeng and Chia-Ping)
>
> Cheers,
> Chia-Ping
>
> On 2018/07/05 14:45:01, Chia-Ping Tsai <ch...@apache.org> wrote:
> > hi all,
> >
> > I would like to start voting on "KIP-331 Add default implementation to
> close() and configure() for Serializer, Deserializer and Serde"
> >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
> >
> > Cheers,
> > Chia-Ping
> >
>
Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde
Posted by Chia-Ping Tsai <ch...@apache.org>.
All,
The 72 hours has passed. The vote result of KIP-313 is shown below.
1 binding vote (Matthias J. Sax)
4 non-binding votes (John Roesler, Richard Yu, vito jeng and Chia-Ping)
Cheers,
Chia-Ping
On 2018/07/05 14:45:01, Chia-Ping Tsai <ch...@apache.org> wrote:
> hi all,
>
> I would like to start voting on "KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde"
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
>
> Cheers,
> Chia-Ping
>
Re: [VOTE] KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde
Posted by Chia-Ping Tsai <ch...@apache.org>.
We have following votes:
non-binding
1. John Roesler
2. vito jeng
3. Richard Yu
4. Bill Bejeck
5. Satish Duggana
binding
1. Matthias J. Sax
2. Ismael Juma
3. Damian Guy
KIP-331 has passed. Thanks for all votes
--
Chia-Ping
On 2018/07/05 14:45:01, Chia-Ping Tsai <ch...@apache.org> wrote:
> hi all,
>
> I would like to start voting on "KIP-331 Add default implementation to close() and configure() for Serializer, Deserializer and Serde"
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-331+Add+default+implementation+to+close%28%29+and+configure%28%29+for+Serializer%2C+Deserializer+and+Serde
>
> Cheers,
> Chia-Ping
>