You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "viirya (via GitHub)" <gi...@apache.org> on 2023/09/26 20:59:53 UTC

[GitHub] [arrow-rs] viirya opened a new pull request, #4863: Make align_buffers as public API

viirya opened a new pull request, #4863:
URL: https://github.com/apache/arrow-rs/pull/4863

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   # Rationale for this change
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   Buffer alignment is not automatic for FFI (https://github.com/apache/arrow-rs/pull/4681#issuecomment-1674592087). Although there is `ArrayData::align_buffers` for that, but it is not public API so we cannot use it outside this crate.
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] viirya commented on pull request #4863: Make align_buffers as public API

Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #4863:
URL: https://github.com/apache/arrow-rs/pull/4863#issuecomment-1736398099

   Hmm, but for FFI API, from imported array and schema, you get a ArrayData
   already instead a builder.
   
   On Tue, Sep 26, 2023, 15:28 Raphael Taylor-Davies ***@***.***>
   wrote:
   
   > ***@***.**** commented on this pull request.
   >
   > The public API is
   > https://docs.rs/arrow-data/latest/arrow_data/struct.ArrayDataBuilder.html#method.build_aligned
   >
   > Otherwise you have to build an ArrayData with incorrect alignment to call
   > this method, which is technically unsound per the public API contract
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/arrow-rs/pull/4863#pullrequestreview-1645296691>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAAQZ5ZANDZ6XUX7MCT4IHDX4NJI5ANCNFSM6AAAAAA5IKPF7U>
   > .
   > You are receiving this because you authored the thread.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold merged pull request #4863: Make align_buffers as public API

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4863:
URL: https://github.com/apache/arrow-rs/pull/4863


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on pull request #4863: Make align_buffers as public API

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4863:
URL: https://github.com/apache/arrow-rs/pull/4863#issuecomment-1736425349

   Eh, fair enough. Its a bit off, but 😅


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org