[GitHub] wynot12 edited a comment on issue #65: [NEMO-106] Move /tests/compiler into /compiler/test

[GitBox <gi...@apache.org>]

wynot12 edited a comment on issue #65: [NEMO-106] Move /tests/compiler into /compiler/test 
URL: https://github.com/apache/incubator-nemo/pull/65#issuecomment-402070976
 
 
   The concern is the dependency between compiler test codes.
   
   Actually most of compiler tests can be decomposed and moved into the corresponding sub-modules (e.g., `compiler/optimizer`, `compiler/frontend`) without cross-dependency, except `compiler/backend/NemoBackendTest`, which has a dependency to `compiler/optimizer`.
   
   For `NemoBackendTest`, we can just give `compiler/backend` a dependency to `compiler/optimizer`.
   
   The problem is that the compiler tests have several common classes: `CompilerTestUtil`, `TestPolicy`.
   
   So I just put them all in a compiler-common module for test named `nemo-compiler-test ` in `compiler/test`.
   
   As an option, we may move the test codes into the corresponding sub-modules and keep only the common classes in a new compiler-common module.
   
   Sorry for missing detail in the PR description.
   Feedbacks are always welcome :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services