You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streams.apache.org by mf...@apache.org on 2014/07/21 20:46:21 UTC
[3/4] git commit: STREAMS-132 | Removed unnecessary try/catch loop
from process method
STREAMS-132 | Removed unnecessary try/catch loop from process method
Project: http://git-wip-us.apache.org/repos/asf/incubator-streams/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-streams/commit/b3956f96
Tree: http://git-wip-us.apache.org/repos/asf/incubator-streams/tree/b3956f96
Diff: http://git-wip-us.apache.org/repos/asf/incubator-streams/diff/b3956f96
Branch: refs/heads/master
Commit: b3956f963d1f87ce2b5d1e04e9c9637ca5c3ad67
Parents: 8cc3d69
Author: Robert Douglas <rd...@w2odigital.com>
Authored: Tue Jul 15 11:58:02 2014 -0500
Committer: Robert Douglas <rd...@w2odigital.com>
Committed: Tue Jul 15 11:58:02 2014 -0500
----------------------------------------------------------------------
.../regex/AbstractRegexExtensionExtractor.java | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-streams/blob/b3956f96/streams-contrib/streams-processor-regex/src/main/java/org/apache/streams/regex/AbstractRegexExtensionExtractor.java
----------------------------------------------------------------------
diff --git a/streams-contrib/streams-processor-regex/src/main/java/org/apache/streams/regex/AbstractRegexExtensionExtractor.java b/streams-contrib/streams-processor-regex/src/main/java/org/apache/streams/regex/AbstractRegexExtensionExtractor.java
index 0b45cf2..afd4972 100644
--- a/streams-contrib/streams-processor-regex/src/main/java/org/apache/streams/regex/AbstractRegexExtensionExtractor.java
+++ b/streams-contrib/streams-processor-regex/src/main/java/org/apache/streams/regex/AbstractRegexExtensionExtractor.java
@@ -78,20 +78,14 @@ public abstract class AbstractRegexExtensionExtractor<T> implements StreamsProce
@Override
public void prepare(Object configurationObject) {
- try {
- if (configurationObject instanceof Map) {
- if (((Map) configurationObject).containsKey(patternConfigKey)) {
- pattern = (String) ((Map) configurationObject).get(patternConfigKey);
- }
- } else if (configurationObject instanceof String) {
- pattern = (String) configurationObject;
- } else {
- pattern = defaultPattern;
+ if (configurationObject instanceof Map) {
+ if (((Map) configurationObject).containsKey(patternConfigKey)) {
+ pattern = (String) ((Map) configurationObject).get(patternConfigKey);
}
- } catch (Throwable e) {
- LOGGER.error("Throwable prepare {}", e);
- e.printStackTrace();
- throw new RuntimeException(e);
+ } else if (configurationObject instanceof String) {
+ pattern = (String) configurationObject;
+ } else {
+ pattern = defaultPattern;
}
}