You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by bu...@apache.org on 2019/11/23 03:41:35 UTC

[hbase] branch branch-2 updated: HBASE-22969 A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position; ADDENDUM (#869)

This is an automated email from the ASF dual-hosted git repository.

busbey pushed a commit to branch branch-2
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-2 by this push:
     new c60d11b  HBASE-22969 A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position; ADDENDUM (#869)
c60d11b is described below

commit c60d11b2ba537d6bdba734699020ba4c98d72e50
Author: Peter Somogyi <ps...@apache.org>
AuthorDate: Fri Nov 22 20:42:27 2019 +0100

    HBASE-22969 A new binary component comparator(BinaryComponentComparator) to perform comparison of arbitrary length and position; ADDENDUM (#869)
    
    Signed-off-by: Sean Busbey <bu...@apache.org>
---
 .../filter/TestFiltersWithBinaryComponentComparator.java     | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFiltersWithBinaryComponentComparator.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFiltersWithBinaryComponentComparator.java
index a3ade6e..91b7dae 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFiltersWithBinaryComponentComparator.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFiltersWithBinaryComponentComparator.java
@@ -21,6 +21,7 @@ import static org.junit.Assert.assertTrue;
 
 import java.io.IOException;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.List;
 
 import org.apache.commons.codec.binary.Hex;
@@ -194,11 +195,14 @@ public class TestFiltersWithBinaryComponentComparator {
             Put row = new Put(key);
             if (c%2==0) {
               row.addColumn(family, qf, Bytes.toBytes("abc"));
-              LOG.info("added row:" + Hex.encodeHex(key) + "with value 'abc'");
-            }
-            else {
+              if (LOG.isInfoEnabled()) {
+                LOG.info("added row: {} with value 'abc'", Arrays.toString(Hex.encodeHex(key)));
+              }
+            } else {
               row.addColumn(family, qf, Bytes.toBytes("xyz"));
-              LOG.info("added row:" + Hex.encodeHex(key) + "with value 'xyz'");
+              if (LOG.isInfoEnabled()) {
+                LOG.info("added row: {} with value 'xyz'", Arrays.toString(Hex.encodeHex(key)));
+              }
             }
           }
         }