You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2011/07/15 22:45:15 UTC

Re: svn commit: r1147314 - /subversion/branches/svn_mutex/subversion/libsvn_subr/svn_mutex.c

On Fri, Jul 15, 2011 at 16:39,  <da...@apache.org> wrote:
>...
> +++ subversion/branches/svn_mutex/subversion/libsvn_subr/svn_mutex.c Fri Jul 15 20:39:32 2011
>...
>  svn_error_t *
> -svn_mutex__init(svn_mutex__t **mutex,
> +svn_mutex__init(svn_mutex__t **mutex_p,
>                 svn_boolean_t enable_mutex,
>                 apr_pool_t *pool)

Would it be clearer to call that boolean "require_mutex" ?

Cheers,
-g

Re: svn commit: r1147314 - /subversion/branches/svn_mutex/subversion/libsvn_subr/svn_mutex.c

Posted by Stefan Fuhrmann <eq...@web.de>.
On 15.07.2011 22:45, Greg Stein wrote:
> On Fri, Jul 15, 2011 at 16:39,<da...@apache.org>  wrote:
>> ...
>> +++ subversion/branches/svn_mutex/subversion/libsvn_subr/svn_mutex.c Fri Jul 15 20:39:32 2011
>> ...
>>   svn_error_t *
>> -svn_mutex__init(svn_mutex__t **mutex,
>> +svn_mutex__init(svn_mutex__t **mutex_p,
>>                  svn_boolean_t enable_mutex,
>>                  apr_pool_t *pool)
> Would it be clearer to call that boolean "require_mutex" ?

Yes. Renamed in r1215460.

-- Stefan^2.