You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/11/04 01:37:52 UTC
Re: Review Request 39534: SSLTest refactor: Change MesosTest to
inherit from the SSL helper class.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39534/#review105020
-----------------------------------------------------------
src/tests/mesos.hpp (line 103)
<https://reviews.apache.org/r/39534/#comment163382>
We have two 'TemporaryDirectoryTest' (one in stout, one in mesos). There's some subtle differences between the two (e.g., the temp directory naming, umount unneeded mounts)
MesosTest inherits from TemporaryDirectoryTest in Mesos previously. This change breaks the test (if you run under root).
- Jie Yu
On Oct. 26, 2015, 10:37 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39534/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2015, 10:37 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
>
>
> Bugs: MESOS-3762
> https://issues.apache.org/jira/browse/MESOS-3762
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a
>
> Diff: https://reviews.apache.org/r/39534/diff/
>
>
> Testing
> -------
>
> ```
> ../configure
> make check
> ```
>
> ```
> ../configure --enable-ssl --enable-libevent
> make check
> ```
>
>
> Thanks,
>
> Joseph Wu
>
>