You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/04/24 20:06:59 UTC
[kudu-CR] [backup] Quick fix to fromMs option logic
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13105
Change subject: [backup] Quick fix to fromMs option logic
......................................................................
[backup] Quick fix to fromMs option logic
The fromMS logic was incorrectly updated and we
didn’t have a test validating the bahavior. This patch
fixes and tests that issue.
KUDU-2790 tracks overall coverage improvements,
so this is just a quick fix.
Change-Id: I12dc557fa71470ca8aef2a1c2393bda28e0b81dd
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
4 files changed, 15 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/13105/1
--
To view, visit http://gerrit.cloudera.org:8080/13105
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I12dc557fa71470ca8aef2a1c2393bda28e0b81dd
Gerrit-Change-Number: 13105
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [backup] Quick fix to fromMs option logic
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13105 )
Change subject: [backup] Quick fix to fromMs option logic
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13105
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12dc557fa71470ca8aef2a1c2393bda28e0b81dd
Gerrit-Change-Number: 13105
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 24 Apr 2019 21:45:22 +0000
Gerrit-HasComments: No
[kudu-CR] [backup] Quick fix to fromMs option logic
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13105 )
Change subject: [backup] Quick fix to fromMs option logic
......................................................................
[backup] Quick fix to fromMs option logic
The fromMS logic was incorrectly updated and we
didn’t have a test validating the bahavior. This patch
fixes and tests that issue.
Additionally the TestForceIncrementalBackup was
wrong as well.
KUDU-2790 tracks overall coverage improvements,
so this is just a quick fix. KUDU-2790 will be my next
path on this code.
Change-Id: I12dc557fa71470ca8aef2a1c2393bda28e0b81dd
Reviewed-on: http://gerrit.cloudera.org:8080/13105
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
4 files changed, 18 insertions(+), 15 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13105
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I12dc557fa71470ca8aef2a1c2393bda28e0b81dd
Gerrit-Change-Number: 13105
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [backup] Quick fix to fromMs option logic
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13105
to look at the new patch set (#2).
Change subject: [backup] Quick fix to fromMs option logic
......................................................................
[backup] Quick fix to fromMs option logic
The fromMS logic was incorrectly updated and we
didn’t have a test validating the bahavior. This patch
fixes and tests that issue.
Additionally the TestForceIncrementalBackup was
wrong as well.
KUDU-2790 tracks overall coverage improvements,
so this is just a quick fix. KUDU-2790 will be my next
path on this code.
Change-Id: I12dc557fa71470ca8aef2a1c2393bda28e0b81dd
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/Options.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
4 files changed, 18 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/13105/2
--
To view, visit http://gerrit.cloudera.org:8080/13105
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I12dc557fa71470ca8aef2a1c2393bda28e0b81dd
Gerrit-Change-Number: 13105
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [backup] Quick fix to fromMs option logic
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13105 )
Change subject: [backup] Quick fix to fromMs option logic
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13105/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala:
http://gerrit.cloudera.org:8080/#/c/13105/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@81
PS1, Line 81: val handle = logs.attach()
: doBackup(rootDir, Seq(tableName)) // Incremental backup.
: handle.close()
Scala doesn't support a try-with-resources equivalent for things like this?
--
To view, visit http://gerrit.cloudera.org:8080/13105
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12dc557fa71470ca8aef2a1c2393bda28e0b81dd
Gerrit-Change-Number: 13105
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 24 Apr 2019 20:22:09 +0000
Gerrit-HasComments: Yes
[kudu-CR] [backup] Quick fix to fromMs option logic
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13105 )
Change subject: [backup] Quick fix to fromMs option logic
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13105/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala:
http://gerrit.cloudera.org:8080/#/c/13105/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@81
PS1, Line 81: val handle = logs.attach()
: doBackup(rootDir, Seq(tableName)) // Incremental backup.
: handle.close()
> Scala doesn't support a try-with-resources equivalent for things like this?
Not by default, but I can write one really easy since I can pass functions. I just kept this super small. In he testing followups I will make this better.
--
To view, visit http://gerrit.cloudera.org:8080/13105
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12dc557fa71470ca8aef2a1c2393bda28e0b81dd
Gerrit-Change-Number: 13105
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 24 Apr 2019 20:27:49 +0000
Gerrit-HasComments: Yes