You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/25 08:43:28 UTC

[GitHub] [camel-k] squakez commented on a diff in pull request #3838: Fix tests related to recent camel-k-runtime changes

squakez commented on code in PR #3838:
URL: https://github.com/apache/camel-k/pull/3838#discussion_r1032127414


##########
pkg/util/dsl/template.go:
##########
@@ -41,7 +41,7 @@ func TemplateToYamlDSL(template v1.Template, id string) ([]byte, error) {
 		jsondata["id"] = id
 	}
 	templateWrapper := make(map[string]interface{}, 2)
-	templateWrapper["template"] = jsondata

Review Comment:
   I think the usage of template is still good. However, instead of being an array (therefore a list in yaml) it should be a single parameter of the spec.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org