You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/02/09 01:57:23 UTC
[GitHub] [incubator-pekko] pjfanning opened a new pull request, #152: try to fix nightly build issue
pjfanning opened a new pull request, #152:
URL: https://github.com/apache/incubator-pekko/pull/152
I made a mistake in my last PR.
https://github.com/apache/incubator-pekko/pull/148/files#diff-e780cb03e0575bf97176af613cf9b23d9337cc6a8d309a7475704fc756cfcce3R166
I copy/pasted this from another project and inadvertently kept the wrong variable name (java-version instead of jdkVersion) but then reviewing the existing variable, I see now that setup-java requires numeric params - so I changed the matrix values and anything that used them. I renamed the param to javaVersion to match the naming style in this file.
I removed extraopts because it always appears to be set to ""
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jrudolph commented on a diff in pull request #152: try to fix nightly build issue
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #152:
URL: https://github.com/apache/incubator-pekko/pull/152#discussion_r1101313274
##########
.github/workflows/nightly-builds.yml:
##########
@@ -145,25 +145,18 @@ jobs:
# binary version is required and Akka build will set the right
# full version from it.
scalaVersion: ["2.12", "2.13"]
- jdkVersion: ["adopt@1.8.0", "adopt@1.11", "openjdk@1.17.0"]
- include:
- - jdkVersion: adopt@1.8.0
- extraOpts: ""
- - jdkVersion: adopt@1.11
- extraOpts: ""
- - jdkVersion: openjdk@1.17.0
- extraopts: ""
+ javaVersion: [8, 11, 17]
Review Comment:
Not sure about the numeric part, where did you get that from? E.g. see https://github.com/actions/setup-java#testing-against-different-java-versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning merged pull request #152: try to fix nightly build issue
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #152:
URL: https://github.com/apache/incubator-pekko/pull/152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jrudolph commented on a diff in pull request #152: try to fix nightly build issue
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #152:
URL: https://github.com/apache/incubator-pekko/pull/152#discussion_r1101358788
##########
.github/workflows/nightly-builds.yml:
##########
@@ -145,25 +145,18 @@ jobs:
# binary version is required and Akka build will set the right
# full version from it.
scalaVersion: ["2.12", "2.13"]
- jdkVersion: ["adopt@1.8.0", "adopt@1.11", "openjdk@1.17.0"]
- include:
- - jdkVersion: adopt@1.8.0
- extraOpts: ""
- - jdkVersion: adopt@1.11
- extraOpts: ""
- - jdkVersion: openjdk@1.17.0
- extraopts: ""
+ javaVersion: [8, 11, 17]
Review Comment:
Ok, probably gets autoconverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #152: try to fix nightly build issue
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #152:
URL: https://github.com/apache/incubator-pekko/pull/152#discussion_r1101323604
##########
.github/workflows/nightly-builds.yml:
##########
@@ -145,25 +145,18 @@ jobs:
# binary version is required and Akka build will set the right
# full version from it.
scalaVersion: ["2.12", "2.13"]
- jdkVersion: ["adopt@1.8.0", "adopt@1.11", "openjdk@1.17.0"]
- include:
- - jdkVersion: adopt@1.8.0
- extraOpts: ""
- - jdkVersion: adopt@1.11
- extraOpts: ""
- - jdkVersion: openjdk@1.17.0
- extraopts: ""
+ javaVersion: [8, 11, 17]
Review Comment:
numeric values work (as do text ones) - https://github.com/apache/incubator-pekko-connectors-kafka/pull/26 is an example where I use numeric values (in a previous PR in pekko space)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org