You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@madlib.apache.org by GitBox <gi...@apache.org> on 2019/05/02 19:07:11 UTC

[GitHub] [madlib] kaknikhil commented on issue #383: Dl/remove hardcode

kaknikhil commented on issue #383: Dl/remove hardcode
URL: https://github.com/apache/madlib/pull/383#issuecomment-488793963
 
 
   @reductionista The code changes are ready to be re-reviewed. 
   
   For this comment https://github.com/apache/madlib/pull/379#discussion_r279906423, we removed the duplicated set code but kept the two functions to make the code easier to reflect that we are setting the value at the begining and resetting it later.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services