You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/10/19 03:30:58 UTC

[GitHub] [iotdb] qiaojialin commented on a change in pull request #1796: [IOTDB-886]fix float loss precision

qiaojialin commented on a change in pull request #1796:
URL: https://github.com/apache/iotdb/pull/1796#discussion_r507410119



##########
File path: server/src/main/java/org/apache/iotdb/db/utils/TypeInferenceUtils.java
##########
@@ -52,6 +54,10 @@ private static boolean isBoolean(String s) {
         .equalsIgnoreCase(SQLConstant.BOOLEAN_FALSE);
   }
 
+  private static boolean isConvertFloatPrecisionLack(String s){
+    return Long.parseLong(s) > (2 << 24);

Review comment:
       This may be time-consuming when insert integer string.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org