You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ma...@apache.org on 2023/11/08 06:32:40 UTC
(arrow) branch main updated: GH-38591: [Parquet][C++] Remove redundant open calls in `ParquetFileFormat::GetReaderAsync` (#38621)
This is an automated email from the ASF dual-hosted git repository.
maplefu pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new e62ec62e40 GH-38591: [Parquet][C++] Remove redundant open calls in `ParquetFileFormat::GetReaderAsync` (#38621)
e62ec62e40 is described below
commit e62ec62e40b04b0bfce76d58369845d3aa96a419
Author: Eero Lihavainen <ee...@nitor.com>
AuthorDate: Wed Nov 8 08:32:32 2023 +0200
GH-38591: [Parquet][C++] Remove redundant open calls in `ParquetFileFormat::GetReaderAsync` (#38621)
### Rationale for this change
There were duplicate method calls causing extra I/O operations, apparently unintentional from https://github.com/apache/arrow/commit/0793432ad0ef5cb598b7b1e61071cd4991bd1b8b.
### What changes are included in this PR?
Remove the extra method calls.
### Are these changes tested?
### Are there any user-facing changes?
* Closes: #38591
Authored-by: Eero Lihavainen <ee...@nitor.com>
Signed-off-by: mwish <ma...@gmail.com>
---
cpp/src/arrow/dataset/file_parquet.cc | 5 -----
1 file changed, 5 deletions(-)
diff --git a/cpp/src/arrow/dataset/file_parquet.cc b/cpp/src/arrow/dataset/file_parquet.cc
index d486f194f3..65ad70181f 100644
--- a/cpp/src/arrow/dataset/file_parquet.cc
+++ b/cpp/src/arrow/dataset/file_parquet.cc
@@ -504,11 +504,6 @@ Future<std::shared_ptr<parquet::arrow::FileReader>> ParquetFileFormat::GetReader
default_fragment_scan_options));
auto properties = MakeReaderProperties(*this, parquet_scan_options.get(), source.path(),
source.filesystem(), options->pool);
- ARROW_ASSIGN_OR_RAISE(auto input, source.Open());
- // TODO(ARROW-12259): workaround since we have Future<(move-only type)>
- auto reader_fut = parquet::ParquetFileReader::OpenAsync(
- std::move(input), std::move(properties), metadata);
- auto path = source.path();
auto self = checked_pointer_cast<const ParquetFileFormat>(shared_from_this());
return source.OpenAsync().Then(