You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by yi...@apache.org on 2021/11/01 08:42:26 UTC
[royale-asjs] branch develop updated (f2d58a5 -> 03a67cb)
This is an automated email from the ASF dual-hosted git repository.
yishayw pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git.
from f2d58a5 Support request for ability to switch off AMF verbose logging in js (which is present in flash debug output). The easiest way to do this is with a different ClassAliasBead : <js:AMFClassAliasBead verboseLogging="false" />
add 03cc89e remove trace statement so it doesn't show up in greps
add 0977676 BoxLayout listens to children and runs layout if they change size
add 7704676 add typename
add c819fec fix DateChooser column headers. Should fix #844
add 241c927 try to get measurement changes propagated bottom up
add f59cbc3 fix crash in Panel
add b01a9aa handle remove
add 93f6585 Merge branch 'develop' into ChildResize
add 43ce0a8 Merge branch 'develop' into ChildResize
add 199b495 make sure Image/Bitmap image measurements are not NaN
add 47a85d8 Spark Label is a 'native' control (no view) so it has to send notifications if its size changes as the text changes
add 8ccfa56 listen for child size changing
add 2874e45 More measurements happening, so need to check safety
add 6c7c869 handle skins of SkinnableContainers that are fully sized by parent
add 8d9bb55 Merge branch 'ChildResize' of https://github.com/apache/royale-asjs into ChildResize
add 11c1735 stop forcing size of DG to 200x200 and try measuring based on rowHeight and number of rows in DG when set
add 5787649 invalidateSize if children are growing during layout. It means that a child that was sizedToContent was re-measured or otherwise got a new size so the parent's size is invalid unless both explicitly set. Even for percentage sizing the min size of the parent depends on the children's size
add b34b163 Fix #1019
add 02a50e8 Make sure scrollbars don't prevent a height measurement
add ff08ebb Setting explcit dimensions directly means read dimensions are different to explicit dimensions which can mess up layout.
add 2597ac6 An initial implementation of spark Line
add 823550a Width and height are set on clear so need to do measure before that
add 8920c39 try to fix #1021
add 42dead6 Make sure SkinnableContainer is measured by skin if possible
add 0d781be Merge branch 'develop' into ChildResize
new d8a6186 Merge branch 'ChildResize' into develop
new 03a67cb Merge branch 'develop' of https://github.com/apache/royale-asjs into develop
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../MXRoyale/src/main/resources/defaults.css | 2 -
.../main/royale/mx/containers/beads/BoxLayout.as | 43 +++++++++++++++++-
.../MXRoyale/src/main/royale/mx/core/Container.as | 46 ++++++++++++++++++-
.../royale/spark/components/SkinnableContainer.as | 41 +++++++++++++++++
.../royale/spark/components/beads/GroupView.as | 21 +++++++--
.../components/beads/SkinnableContainerView.as | 14 ++++--
.../layouts/supportClasses/SparkLayoutBead.as | 52 +++++++++++++++++++++-
7 files changed, 207 insertions(+), 12 deletions(-)
RE: [royale-asjs] 01/02: Merge branch 'ChildResize' into develop
Posted by Yishay Weiss <yi...@hotmail.com>.
Hi Andrew,
We expect containers to work as documented in Flex docs. That’s true for all emulation components so I do not think it warrants more documentation.
Thanks.
From: Andrew Wetmore<ma...@gmail.com>
Sent: Monday, November 1, 2021 2:52 PM
To: Apache Royale Development<ma...@royale.apache.org>
Subject: Re: [royale-asjs] 01/02: Merge branch 'ChildResize' into develop
Should I add a description of what we now expect the behaviour to be,
somewhere in the docs on containers?
On Mon, Nov 1, 2021 at 6:59 AM Yishay Weiss <yi...@hotmail.com> wrote:
> Hi,
>
> I finally decided to merge ChildResize branch into develop which should
> improve layout in emulation layer for containers that include children
> added post-creation. Most of the changes were done by Alex over a year ago.
> I tested this branch on a project about a year ago and found that it solved
> many layout issues, though not all of them. Hopefully, when we resolve the
> conflicts with PR #1135 and merge, even more layout issues will be resolved.
>
> As I understand it, the basic idea is that container layouts listen on
> children’s ‘sizeChanged’ events and run layouts and measuremnts in
> response. In addition, if adding a child has resulted in the container
> changing its measured size then the container parent’s size is invalidated
> as well. This should allow size invalidation to bubble up if necessary,
> setting the stage for further measurements in the next layout cycle.
>
> There are additional commits that were made on this branch which should
> fix other issues unrelated to layout.
>
> Please let me know if this merge breaks anything, or if you object to them
> for other reasons. We can discuss what needs to be reverted in such a case.
>
> Thanks,
> Yishay
>
> From: yishayw@apache.org<ma...@apache.org>
> Sent: Monday, November 1, 2021 10:42 AM
> To: commits@royale.apache.org<ma...@royale.apache.org>
> Subject: [royale-asjs] 01/02: Merge branch 'ChildResize' into develop
>
> This is an automated email from the ASF dual-hosted git repository.
>
> yishayw pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>
> commit d8a61862dfa751f762a1f699b5c1016729027409
> Merge: fbf8fcb 0d781be
> Author: Yishay Weiss <yi...@hotmail.com>
> AuthorDate: Sun Oct 31 20:16:56 2021 +0200
>
> Merge branch 'ChildResize' into develop
>
> .../MXRoyale/src/main/resources/defaults.css | 2 -
> .../main/royale/mx/containers/beads/BoxLayout.as | 43 +++++++++++++++++-
> .../MXRoyale/src/main/royale/mx/core/Container.as | 46
> ++++++++++++++++++-
> .../royale/spark/components/SkinnableContainer.as | 41 +++++++++++++++++
> .../royale/spark/components/beads/GroupView.as | 21 +++++++--
> .../components/beads/SkinnableContainerView.as | 14 ++++--
> .../layouts/supportClasses/SparkLayoutBead.as | 52
> +++++++++++++++++++++-
> 7 files changed, 207 insertions(+), 12 deletions(-)
>
>
--
Andrew Wetmore
http://cottage14.blogspot.com/
Re: [royale-asjs] 01/02: Merge branch 'ChildResize' into develop
Posted by Andrew Wetmore <co...@gmail.com>.
Should I add a description of what we now expect the behaviour to be,
somewhere in the docs on containers?
On Mon, Nov 1, 2021 at 6:59 AM Yishay Weiss <yi...@hotmail.com> wrote:
> Hi,
>
> I finally decided to merge ChildResize branch into develop which should
> improve layout in emulation layer for containers that include children
> added post-creation. Most of the changes were done by Alex over a year ago.
> I tested this branch on a project about a year ago and found that it solved
> many layout issues, though not all of them. Hopefully, when we resolve the
> conflicts with PR #1135 and merge, even more layout issues will be resolved.
>
> As I understand it, the basic idea is that container layouts listen on
> children’s ‘sizeChanged’ events and run layouts and measuremnts in
> response. In addition, if adding a child has resulted in the container
> changing its measured size then the container parent’s size is invalidated
> as well. This should allow size invalidation to bubble up if necessary,
> setting the stage for further measurements in the next layout cycle.
>
> There are additional commits that were made on this branch which should
> fix other issues unrelated to layout.
>
> Please let me know if this merge breaks anything, or if you object to them
> for other reasons. We can discuss what needs to be reverted in such a case.
>
> Thanks,
> Yishay
>
> From: yishayw@apache.org<ma...@apache.org>
> Sent: Monday, November 1, 2021 10:42 AM
> To: commits@royale.apache.org<ma...@royale.apache.org>
> Subject: [royale-asjs] 01/02: Merge branch 'ChildResize' into develop
>
> This is an automated email from the ASF dual-hosted git repository.
>
> yishayw pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>
> commit d8a61862dfa751f762a1f699b5c1016729027409
> Merge: fbf8fcb 0d781be
> Author: Yishay Weiss <yi...@hotmail.com>
> AuthorDate: Sun Oct 31 20:16:56 2021 +0200
>
> Merge branch 'ChildResize' into develop
>
> .../MXRoyale/src/main/resources/defaults.css | 2 -
> .../main/royale/mx/containers/beads/BoxLayout.as | 43 +++++++++++++++++-
> .../MXRoyale/src/main/royale/mx/core/Container.as | 46
> ++++++++++++++++++-
> .../royale/spark/components/SkinnableContainer.as | 41 +++++++++++++++++
> .../royale/spark/components/beads/GroupView.as | 21 +++++++--
> .../components/beads/SkinnableContainerView.as | 14 ++++--
> .../layouts/supportClasses/SparkLayoutBead.as | 52
> +++++++++++++++++++++-
> 7 files changed, 207 insertions(+), 12 deletions(-)
>
>
--
Andrew Wetmore
http://cottage14.blogspot.com/
RE: [royale-asjs] 01/02: Merge branch 'ChildResize' into develop
Posted by Yishay Weiss <yi...@hotmail.com>.
Hi,
I finally decided to merge ChildResize branch into develop which should improve layout in emulation layer for containers that include children added post-creation. Most of the changes were done by Alex over a year ago. I tested this branch on a project about a year ago and found that it solved many layout issues, though not all of them. Hopefully, when we resolve the conflicts with PR #1135 and merge, even more layout issues will be resolved.
As I understand it, the basic idea is that container layouts listen on children’s ‘sizeChanged’ events and run layouts and measuremnts in response. In addition, if adding a child has resulted in the container changing its measured size then the container parent’s size is invalidated as well. This should allow size invalidation to bubble up if necessary, setting the stage for further measurements in the next layout cycle.
There are additional commits that were made on this branch which should fix other issues unrelated to layout.
Please let me know if this merge breaks anything, or if you object to them for other reasons. We can discuss what needs to be reverted in such a case.
Thanks,
Yishay
From: yishayw@apache.org<ma...@apache.org>
Sent: Monday, November 1, 2021 10:42 AM
To: commits@royale.apache.org<ma...@royale.apache.org>
Subject: [royale-asjs] 01/02: Merge branch 'ChildResize' into develop
This is an automated email from the ASF dual-hosted git repository.
yishayw pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit d8a61862dfa751f762a1f699b5c1016729027409
Merge: fbf8fcb 0d781be
Author: Yishay Weiss <yi...@hotmail.com>
AuthorDate: Sun Oct 31 20:16:56 2021 +0200
Merge branch 'ChildResize' into develop
.../MXRoyale/src/main/resources/defaults.css | 2 -
.../main/royale/mx/containers/beads/BoxLayout.as | 43 +++++++++++++++++-
.../MXRoyale/src/main/royale/mx/core/Container.as | 46 ++++++++++++++++++-
.../royale/spark/components/SkinnableContainer.as | 41 +++++++++++++++++
.../royale/spark/components/beads/GroupView.as | 21 +++++++--
.../components/beads/SkinnableContainerView.as | 14 ++++--
.../layouts/supportClasses/SparkLayoutBead.as | 52 +++++++++++++++++++++-
7 files changed, 207 insertions(+), 12 deletions(-)
[royale-asjs] 01/02: Merge branch 'ChildResize' into develop
Posted by yi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
yishayw pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit d8a61862dfa751f762a1f699b5c1016729027409
Merge: fbf8fcb 0d781be
Author: Yishay Weiss <yi...@hotmail.com>
AuthorDate: Sun Oct 31 20:16:56 2021 +0200
Merge branch 'ChildResize' into develop
.../MXRoyale/src/main/resources/defaults.css | 2 -
.../main/royale/mx/containers/beads/BoxLayout.as | 43 +++++++++++++++++-
.../MXRoyale/src/main/royale/mx/core/Container.as | 46 ++++++++++++++++++-
.../royale/spark/components/SkinnableContainer.as | 41 +++++++++++++++++
.../royale/spark/components/beads/GroupView.as | 21 +++++++--
.../components/beads/SkinnableContainerView.as | 14 ++++--
.../layouts/supportClasses/SparkLayoutBead.as | 52 +++++++++++++++++++++-
7 files changed, 207 insertions(+), 12 deletions(-)
[royale-asjs] 02/02: Merge branch 'develop' of
https://github.com/apache/royale-asjs into develop
Posted by yi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
yishayw pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit 03a67cbcae4e8bafce64a82c6e75ba8cce8a60f6
Merge: d8a6186 f2d58a5
Author: Yishay Weiss <yi...@hotmail.com>
AuthorDate: Mon Nov 1 09:57:27 2021 +0200
Merge branch 'develop' of https://github.com/apache/royale-asjs into develop
.../royale/org/apache/royale/utils/BinaryData.as | 27 +++++++++
.../royale/flexUnitTests/BinaryDataTesterTest.as | 16 ++++-
.../Network/src/main/resources/basic-manifest.xml | 1 +
.../apache/royale/net/beads/AMFClassAliasBead.as | 70 ++++++++++++++++++++++
.../royale/net/remoting/amf/AMF0AMF3Context.as | 5 +-
.../royale/net/remoting/amf/AMFBinaryData.as | 9 ++-
.../apache/royale/net/remoting/amf/AMFContext.as | 2 +-
7 files changed, 124 insertions(+), 6 deletions(-)