You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/05 17:15:21 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #27643:
[SPARK-30886][SQL] Deprecate two-parameter TRIM function
cloud-fan commented on a change in pull request #27643: [SPARK-30886][SQL] Deprecate two-parameter TRIM function
URL: https://github.com/apache/spark/pull/27643#discussion_r388440051
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1839,13 +1841,18 @@ class Analyzer(
}
AggregateExpression(agg, Complete, isDistinct, filter)
// This function is not an aggregate function, just return the resolved one.
- case other =>
- if (isDistinct || filter.isDefined) {
- failAnalysis("DISTINCT or FILTER specified, " +
- s"but ${other.prettyName} is not an aggregate function")
- } else {
- other
+ case other if (isDistinct || filter.isDefined) =>
+ failAnalysis("DISTINCT or FILTER specified, " +
+ s"but ${other.prettyName} is not an aggregate function")
+ case e: StringTrim if arguments.size == 2 =>
+ if (trimWarningEnabled.get) {
+ log.warn("Two-parameter TRIM function signature is deprecated." +
Review comment:
shall we list all of them? `TRIM` -> `TRIM/LTRIM/RTRIM`, `TRIM(trimStr FROM str)` -> `TRIM((BOTH | LEADING | TRAILING)? trimStr FROM str)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org