You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "xiedeyantu (via GitHub)" <gi...@apache.org> on 2025/03/09 09:26:11 UTC
[PR] [CALCITE-6878] Implement FilterSortTransposeRule [calcite]
xiedeyantu opened a new pull request, #4233:
URL: https://github.com/apache/calcite/pull/4233
link: [[CALCITE-6878]](https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-6878)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6878] Implement FilterSortTransposeRule [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4233:
URL: https://github.com/apache/calcite/pull/4233#issuecomment-2710451959
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4233) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4233&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4233&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4233&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4233&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4233&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4233)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6878] Implement FilterSortTransposeRule [calcite]
Posted by "NobiGo (via GitHub)" <gi...@apache.org>.
NobiGo merged PR #4233:
URL: https://github.com/apache/calcite/pull/4233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6878] Implement FilterSortTransposeRule [calcite]
Posted by "NobiGo (via GitHub)" <gi...@apache.org>.
NobiGo commented on code in PR #4233:
URL: https://github.com/apache/calcite/pull/4233#discussion_r1986496146
##########
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##########
@@ -574,6 +574,45 @@ private static boolean skipItem(RexNode expr) {
.check();
}
+ /** Test case for
+ * <a href="https://issues.apache.org/jira/browse/CALCITE-6878">[CALCITE-6878]
+ * Add the planner rule that pushes the Filter past a Sort</a>. */
+ @Test void testFilterSortTranspose() {
+ final Function<RelBuilder, RelNode> relFn = b -> b
+ .scan("EMP")
+ .project(b.field(0))
+ .sort(b.field(0))
+ .filter(b.lessThan(b.field(0), b.literal(10)))
+ .build();
+ relFn(relFn).withRule(CoreRules.FILTER_SORT_TRANSPOSE).check();
+ }
+
+ /** Test case for
+ * <a href="https://issues.apache.org/jira/browse/CALCITE-6878">[CALCITE-6878]
+ * Add the planner rule that pushes the Filter past a Sort</a>. */
+ @Test void testFilterSortTransposeFetch() {
+ final Function<RelBuilder, RelNode> relFn = b -> b
+ .scan("EMP")
+ .project(b.field(0))
+ .sortLimit(0, 1, b.field(0))
+ .filter(b.lessThan(b.field(0), b.literal(10)))
+ .build();
+ relFn(relFn).withRule(CoreRules.FILTER_SORT_TRANSPOSE).checkUnchanged();
+ }
+
+ /** Test case for
+ * <a href="https://issues.apache.org/jira/browse/CALCITE-6878">[CALCITE-6878]
+ * Add the planner rule that pushes the Filter past a Sort</a>. */
Review Comment:
Please ensure the Java documentation is precisely the same as the Jira title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6878] Implement FilterSortTransposeRule [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on code in PR #4233:
URL: https://github.com/apache/calcite/pull/4233#discussion_r1986363800
##########
core/src/main/java/org/apache/calcite/rel/rules/FilterSortTransposeRule.java:
##########
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.calcite.rel.rules;
+
+import org.apache.calcite.plan.RelOptRuleCall;
+import org.apache.calcite.plan.RelRule;
+import org.apache.calcite.rel.RelNode;
+import org.apache.calcite.rel.core.Filter;
+import org.apache.calcite.rel.core.Sort;
+import org.apache.calcite.rex.RexNode;
+import org.apache.calcite.tools.RelBuilder;
+import org.apache.calcite.tools.RelBuilderFactory;
+
+import org.immutables.value.Value;
+
+/**
+ * Rule that transforms a {@link Filter} on top of a {@link Sort}
+ * into a {@link Sort} on top of a {@link Filter}.
+ */
+@Value.Enclosing
+public class FilterSortTransposeRule
+ extends RelRule<FilterSortTransposeRule.Config>
+ implements TransformationRule {
+ protected FilterSortTransposeRule(FilterSortTransposeRule.Config config) {
+ super(config);
+ }
+
+ @Deprecated // to be removed before 2.0
+ public FilterSortTransposeRule(RelBuilderFactory relBuilderFactory) {
Review Comment:
why create functions which are already deprecated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6878] Implement FilterSortTransposeRule [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on code in PR #4233:
URL: https://github.com/apache/calcite/pull/4233#discussion_r1986501939
##########
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##########
@@ -574,6 +574,45 @@ private static boolean skipItem(RexNode expr) {
.check();
}
+ /** Test case for
+ * <a href="https://issues.apache.org/jira/browse/CALCITE-6878">[CALCITE-6878]
+ * Add the planner rule that pushes the Filter past a Sort</a>. */
+ @Test void testFilterSortTranspose() {
+ final Function<RelBuilder, RelNode> relFn = b -> b
+ .scan("EMP")
+ .project(b.field(0))
+ .sort(b.field(0))
+ .filter(b.lessThan(b.field(0), b.literal(10)))
+ .build();
+ relFn(relFn).withRule(CoreRules.FILTER_SORT_TRANSPOSE).check();
+ }
+
+ /** Test case for
+ * <a href="https://issues.apache.org/jira/browse/CALCITE-6878">[CALCITE-6878]
+ * Add the planner rule that pushes the Filter past a Sort</a>. */
+ @Test void testFilterSortTransposeFetch() {
+ final Function<RelBuilder, RelNode> relFn = b -> b
+ .scan("EMP")
+ .project(b.field(0))
+ .sortLimit(0, 1, b.field(0))
+ .filter(b.lessThan(b.field(0), b.literal(10)))
+ .build();
+ relFn(relFn).withRule(CoreRules.FILTER_SORT_TRANSPOSE).checkUnchanged();
+ }
+
+ /** Test case for
+ * <a href="https://issues.apache.org/jira/browse/CALCITE-6878">[CALCITE-6878]
+ * Add the planner rule that pushes the Filter past a Sort</a>. */
Review Comment:
> Please ensure the Java documentation is precisely the same as the Jira title.
OK, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6878] Implement FilterSortTransposeRule [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4233:
URL: https://github.com/apache/calcite/pull/4233#issuecomment-2708837136
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4233) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4233&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4233&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4233&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [89.7% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4233&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4233&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4233)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6878] Implement FilterSortTransposeRule [calcite]
Posted by "suibianwanwank (via GitHub)" <gi...@apache.org>.
suibianwanwank commented on code in PR #4233:
URL: https://github.com/apache/calcite/pull/4233#discussion_r1986719099
##########
core/src/main/java/org/apache/calcite/rel/rules/FilterSortTransposeRule.java:
##########
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.calcite.rel.rules;
+
+import org.apache.calcite.plan.RelOptRuleCall;
+import org.apache.calcite.plan.RelRule;
+import org.apache.calcite.rel.RelNode;
+import org.apache.calcite.rel.core.Filter;
+import org.apache.calcite.rel.core.Sort;
+import org.apache.calcite.rex.RexNode;
+import org.apache.calcite.tools.RelBuilder;
+
+import org.immutables.value.Value;
+
+/**
+ * Rule that transforms a {@link Filter} on top of a {@link Sort}
+ * into a {@link Sort} on top of a {@link Filter}.
+ */
+@Value.Enclosing
+public class FilterSortTransposeRule
+ extends RelRule<FilterSortTransposeRule.Config>
+ implements TransformationRule {
+ protected FilterSortTransposeRule(FilterSortTransposeRule.Config config) {
+ super(config);
+ }
+
+ @Override public void onMatch(RelOptRuleCall call) {
+ final Filter filter = call.rel(0);
+ final Sort sort = call.rel(1);
+
+ if (sort.offset != null || sort.fetch != null) {
+ return;
+ }
+
+ final RelBuilder builder = call.builder();
+ final RexNode condition = filter.getCondition();
+ RelNode newSort = builder.push(sort.getInput())
+ .filter(condition)
+ .sort(sort.getCollation())
+ .build();
+
+ call.transformTo(newSort);
+ }
+
+ /** Rule configuration. */
+ @Value.Immutable
+ public interface Config extends RelRule.Config {
+ Config DEFAULT = ImmutableFilterSortTransposeRule.Config.of()
+ .withOperandSupplier(f ->
+ f.operand(Filter.class)
+ .oneInput(s ->
+ s.operand(Sort.class).anyInputs()));
Review Comment:
```suggestion
s.operand(Sort.class).predicate(RelOptUtil::isPureOrder).anyInputs()));
```
Based on this modification, we can remove this code:
```
if (sort.offset != null || sort.fetch != null) {
return;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6878] Implement FilterSortTransposeRule [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4233:
URL: https://github.com/apache/calcite/pull/4233#issuecomment-2708770077
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4233) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4233&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4233&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4233&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [87.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4233&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4233&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4233)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6878] Implement FilterSortTransposeRule [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on code in PR #4233:
URL: https://github.com/apache/calcite/pull/4233#discussion_r1986738310
##########
core/src/main/java/org/apache/calcite/rel/rules/FilterSortTransposeRule.java:
##########
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.calcite.rel.rules;
+
+import org.apache.calcite.plan.RelOptRuleCall;
+import org.apache.calcite.plan.RelRule;
+import org.apache.calcite.rel.RelNode;
+import org.apache.calcite.rel.core.Filter;
+import org.apache.calcite.rel.core.Sort;
+import org.apache.calcite.rex.RexNode;
+import org.apache.calcite.tools.RelBuilder;
+
+import org.immutables.value.Value;
+
+/**
+ * Rule that transforms a {@link Filter} on top of a {@link Sort}
+ * into a {@link Sort} on top of a {@link Filter}.
+ */
+@Value.Enclosing
+public class FilterSortTransposeRule
+ extends RelRule<FilterSortTransposeRule.Config>
+ implements TransformationRule {
+ protected FilterSortTransposeRule(FilterSortTransposeRule.Config config) {
+ super(config);
+ }
+
+ @Override public void onMatch(RelOptRuleCall call) {
+ final Filter filter = call.rel(0);
+ final Sort sort = call.rel(1);
+
+ if (sort.offset != null || sort.fetch != null) {
+ return;
+ }
+
+ final RelBuilder builder = call.builder();
+ final RexNode condition = filter.getCondition();
+ RelNode newSort = builder.push(sort.getInput())
+ .filter(condition)
+ .sort(sort.getCollation())
+ .build();
+
+ call.transformTo(newSort);
+ }
+
+ /** Rule configuration. */
+ @Value.Immutable
+ public interface Config extends RelRule.Config {
+ Config DEFAULT = ImmutableFilterSortTransposeRule.Config.of()
+ .withOperandSupplier(f ->
+ f.operand(Filter.class)
+ .oneInput(s ->
+ s.operand(Sort.class).anyInputs()));
Review Comment:
> Based on this modification, we can remove this code:
>
> ```
> if (sort.offset != null || sort.fetch != null) {
> return;
> }
> ```
Thanks, It's better than mine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6878] Implement FilterSortTransposeRule [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on code in PR #4233:
URL: https://github.com/apache/calcite/pull/4233#discussion_r1986409450
##########
core/src/main/java/org/apache/calcite/rel/rules/FilterSortTransposeRule.java:
##########
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.calcite.rel.rules;
+
+import org.apache.calcite.plan.RelOptRuleCall;
+import org.apache.calcite.plan.RelRule;
+import org.apache.calcite.rel.RelNode;
+import org.apache.calcite.rel.core.Filter;
+import org.apache.calcite.rel.core.Sort;
+import org.apache.calcite.rex.RexNode;
+import org.apache.calcite.tools.RelBuilder;
+import org.apache.calcite.tools.RelBuilderFactory;
+
+import org.immutables.value.Value;
+
+/**
+ * Rule that transforms a {@link Filter} on top of a {@link Sort}
+ * into a {@link Sort} on top of a {@link Filter}.
+ */
+@Value.Enclosing
+public class FilterSortTransposeRule
+ extends RelRule<FilterSortTransposeRule.Config>
+ implements TransformationRule {
+ protected FilterSortTransposeRule(FilterSortTransposeRule.Config config) {
+ super(config);
+ }
+
+ @Deprecated // to be removed before 2.0
+ public FilterSortTransposeRule(RelBuilderFactory relBuilderFactory) {
Review Comment:
> why create functions which are already deprecated?
ok, I removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org