Re: [PR] Fix SMTP connection from_email being ignored by email_on_failure and … [airflow]

["bramhanandlingala (via GitHub)" <gi...@apache.org>]

bramhanandlingala commented on code in PR #69271:
URL: https://github.com/apache/airflow/pull/69271#discussion_r3533649474


##########
task-sdk/src/airflow/sdk/execution_time/task_runner.py:
##########
@@ -2058,50 +1951,13 @@ def _send_error_email_notification(
             to=to_emails,
             subject=subject,
             html_content=html_content,
-            from_email=conf.get("email", "from_email", fallback="airflow@airflow"),
+            from_email=None,

Review Comment:
   Hi @SameerMesiah97
   
   Good question — I checked. SmtpNotifier is only constructed in one production call site outside its own module, which is _send_error_email_notification in task_runner.py, and that's already updated in this PR to pass from_email=None. I didn't find any other operator or utility in the repo that resolves from_email from config before building the notifier, so this should cover all callers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org