You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ueshin <gi...@git.apache.org> on 2017/12/29 09:18:07 UTC
[GitHub] spark pull request #20115: [SPARK-22370][SQL][PYSPARK][FOLLOW-UP] Fix a test...
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/20115
[SPARK-22370][SQL][PYSPARK][FOLLOW-UP] Fix a test failure when xmlrunner is installed.
## What changes were proposed in this pull request?
This is a follow-up pr of #19587.
If `xmlrunner` is installed, `VectorizedUDFTests.test_vectorized_udf_check_config` fails by the following error because the `self` which is a subclass of `unittest.TestCase` in the UDF `check_records_per_batch` can't be pickled anymore.
```
PicklingError: Cannot pickle files that are not opened for reading: w
```
This changes the UDF not to refer the `self`.
## How was this patch tested?
Tested locally.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ueshin/apache-spark issues/SPARK-22370_fup1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20115.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20115
----
commit f078fe655efa0796723f175ff37cf6ec7e26e92c
Author: Takuya UESHIN <ue...@...>
Date: 2017-12-29T09:01:16Z
Fix a test failure when xmlrunner is installed.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20115: [SPARK-22370][SQL][PYSPARK][FOLLOW-UP] Fix a test failur...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20115
Merged to master
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20115: [SPARK-22370][SQL][PYSPARK][FOLLOW-UP] Fix a test failur...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20115
**[Test build #85506 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85506/testReport)** for PR 20115 at commit [`f078fe6`](https://github.com/apache/spark/commit/f078fe655efa0796723f175ff37cf6ec7e26e92c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20115: [SPARK-22370][SQL][PYSPARK][FOLLOW-UP] Fix a test failur...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20115
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85506/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20115: [SPARK-22370][SQL][PYSPARK][FOLLOW-UP] Fix a test...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20115
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20115: [SPARK-22370][SQL][PYSPARK][FOLLOW-UP] Fix a test failur...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20115
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20115: [SPARK-22370][SQL][PYSPARK][FOLLOW-UP] Fix a test failur...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20115
**[Test build #85506 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85506/testReport)** for PR 20115 at commit [`f078fe6`](https://github.com/apache/spark/commit/f078fe655efa0796723f175ff37cf6ec7e26e92c).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org