You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/10 11:59:44 UTC
[GitHub] [superset] villebro commented on a change in pull request #16660: [WIP] feat: add support for generic series limit
villebro commented on a change in pull request #16660:
URL: https://github.com/apache/superset/pull/16660#discussion_r706122961
##########
File path: superset/connectors/sqla/models.py
##########
@@ -1087,7 +1096,6 @@ def get_sqla_query( # pylint: disable=too-many-arguments,too-many-locals,too-ma
metrics_exprs = []
time_range_endpoints = extras.get("time_range_endpoints")
- groupby_exprs_with_timestamp = OrderedDict(groupby_exprs_sans_timestamp.items())
Review comment:
`OrderedDict` is no longer necessary, as `dict` is guaranteed to be ordered as of Python 3.7.
https://docs.python.org/3.8/library/stdtypes.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org