[jira] [Comment Edited] (SUREFIRE-1232) JUnit4Provider#createTestsDescription doesn't respect runner anymore

["Tibor Digana (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SUREFIRE-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15183912#comment-15183912 ] 

Tibor Digana edited comment on SUREFIRE-1232 at 3/7/16 10:44 PM:
-----------------------------------------------------------------

[~OliverL]
We had to do this change in {{surefire-junit4}} because too precise Description would lead to instantiating the JUnit Runners twice.
Is this issue the same with SUREFIRE-1227 ?
I think we can close this issue as a duplicate.
Do you agree?


was (Author: tibor17):
[~OliverL]
We had to do this change in {{surefire-junit4}} because too precise Description would lead to instantiating the JUnir Runners twice.
Is this issue the same with SUREFIRE-1227 ?
I think we can close this issue as a duplicate.
Do you agree?

> JUnit4Provider#createTestsDescription doesn't respect runner anymore
> --------------------------------------------------------------------
>
>                 Key: SUREFIRE-1232
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1232
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Junit 4.x support
>    Affects Versions: 2.19.1
>            Reporter: Oliver Libutzki
>            Assignee: Tibor Digana
>
> In 2.19.1 the JUnit4Prrovider doesn't respect the annotated runner when creating the description of a suite as org.apache.maven.surefire.common.junit4.JUnit4Refelector#createDescription is called which just calls Descritpion#createSuiteDescription.
> In 2.18.1 JUnit4ProviderUtil.createSuiteDescription( classes ) is called which creates a Request and asks the runner for the description.
> This is a regression in my opinion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)