You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2011/12/15 23:29:33 UTC
[jira] [Commented] (FLUME-869) JDBC channel tests leave derby.log
in module directory
[ https://issues.apache.org/jira/browse/FLUME-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170536#comment-13170536 ]
jiraposter@reviews.apache.org commented on FLUME-869:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3217/
-----------------------------------------------------------
Review request for Flume and Eric Sammer.
Summary
-------
Introduced a mechanism by which JDBC channel implementation will be able to set system properties that may be needed to configure/govern any embedded database instance that it may use. Used this mechanism to set the location of derby.log file for test runs.
This addresses bug FLUME-869.
https://issues.apache.org/jira/browse/FLUME-869
Diffs
-----
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 83ccba3
flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 34027ea
flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestJdbcChannelProvider.java 862be39
flume-ng-core/src/main/java/org/apache/flume/Context.java 8cac89a
Diff: https://reviews.apache.org/r/3217/diff
Testing
-------
Ran all unit tests and verified that the derby.log file is being created in the target test directory as expected.
Thanks,
Arvind
> JDBC channel tests leave derby.log in module directory
> ------------------------------------------------------
>
> Key: FLUME-869
> URL: https://issues.apache.org/jira/browse/FLUME-869
> Project: Flume
> Issue Type: Bug
> Components: Build, Test
> Affects Versions: NG alpha 2
> Reporter: E. Sammer
> Assignee: Arvind Prabhakar
> Priority: Trivial
> Fix For: NG alpha 3
>
> Attachments: FLUME-869-1.patch
>
>
> The JDBC channel tests leave a derby.log file in the module's base directory which causes RAT to fail. Ideally no generated files should live outside of ${project.build.dir}.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira