[GitHub] [spark] brkyvz commented on a change in pull request #27838: [SPARK-30902][SQL][FOLLOW-UP] Allow ReplaceTableAsStatement to have none provider

[GitBox <gi...@apache.org>]

brkyvz commented on a change in pull request #27838: [SPARK-30902][SQL][FOLLOW-UP] Allow ReplaceTableAsStatement to have none provider
URL: https://github.com/apache/spark/pull/27838#discussion_r389096222
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
 ##########
 @@ -2834,11 +2834,11 @@ class AstBuilder(conf: SQLConf) extends SqlBaseBaseVisitor[AnyRef] with Logging
 
       case Some(query) =>
         ReplaceTableAsSelectStatement(table, query, partitioning, bucketSpec, properties,
-          provider, options, location, comment, orCreate = orCreate)
+          Some(provider), options, location, comment, orCreate = orCreate)
 
 Review comment:
   These should be `Option` not `Some`, `Some(null).get => null`, `Option(null) => None`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org