You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/03/17 20:46:21 UTC

[GitHub] [airflow] Fokko commented on a change in pull request #4927: [AIRFLOW-4106] instrument starving tasks in pool

Fokko commented on a change in pull request #4927: [AIRFLOW-4106] instrument starving tasks in pool
URL: https://github.com/apache/airflow/pull/4927#discussion_r266258196
 
 

 ##########
 File path: airflow/jobs.py
 ##########
 @@ -1143,13 +1145,16 @@ def _find_executable_task_instances(self, simple_dag_bag, states, session=None):
             # DAG IDs with running tasks that equal the concurrency limit of the dag
             dag_id_to_possibly_running_task_count = {}
 
-            for task_instance in priority_sorted_task_instances:
+            # Number of tasks that cannot be scheduled because of no open slot in pool
+            num_starved_tasks = 0
+            for i, task_instance in enumerate(priority_sorted_task_instances):
 
 Review comment:
   Can we make this variable name a bit more meaningful?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services