You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by "Matt Franklin (JIRA)" <ji...@apache.org> on 2012/05/29 19:53:23 UTC
[jira] [Created] (RAVE-630) Refactor Person
Matt Franklin created RAVE-630:
----------------------------------
Summary: Refactor Person
Key: RAVE-630
URL: https://issues.apache.org/jira/browse/RAVE-630
Project: Rave
Issue Type: Technical task
Reporter: Matt Franklin
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAVE-630) Refactor Person
Posted by "Ate Douma (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ate Douma updated RAVE-630:
---------------------------
Fix Version/s: 0.13
> Refactor Person
> ---------------
>
> Key: RAVE-630
> URL: https://issues.apache.org/jira/browse/RAVE-630
> Project: Rave
> Issue Type: Technical task
> Reporter: Matt Franklin
> Assignee: Matt Franklin
> Fix For: 0.13
>
>
> Refactor Person object and related entitites
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAVE-630) Refactor Person
Posted by "Matt Franklin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Franklin updated RAVE-630:
-------------------------------
Description: Refactor Person object and related entitites
> Refactor Person
> ---------------
>
> Key: RAVE-630
> URL: https://issues.apache.org/jira/browse/RAVE-630
> Project: Rave
> Issue Type: Technical task
> Reporter: Matt Franklin
> Assignee: Matt Franklin
>
> Refactor Person object and related entitites
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-630) Refactor Person
Posted by "Chris Geer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285239#comment-13285239 ]
Chris Geer commented on RAVE-630:
---------------------------------
Based on the "OS Person" != "Rave User" [1], does it make more sense to have Person extend from User instead of User extend from Person as part of this refactor? I can see a case where you would need a Rave admin account that would never show up in a social context.
[1] http://mail-archives.apache.org/mod_mbox/rave-dev/201205.mbox/browser
> Refactor Person
> ---------------
>
> Key: RAVE-630
> URL: https://issues.apache.org/jira/browse/RAVE-630
> Project: Rave
> Issue Type: Technical task
> Reporter: Matt Franklin
> Assignee: Matt Franklin
>
> Refactor Person object and related entitites
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (RAVE-630) Refactor Person
Posted by "Matt Franklin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Franklin reassigned RAVE-630:
----------------------------------
Assignee: Matt Franklin
> Refactor Person
> ---------------
>
> Key: RAVE-630
> URL: https://issues.apache.org/jira/browse/RAVE-630
> Project: Rave
> Issue Type: Technical task
> Reporter: Matt Franklin
> Assignee: Matt Franklin
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-630) Refactor Person
Posted by "Ate Douma (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285431#comment-13285431 ]
Ate Douma commented on RAVE-630:
--------------------------------
I agree with Matt we should stick to the primary refactoring goal of moving to interface based model first.
And then first wrap up and merge back to trunk before considering serious model restructuring.
Concerning Person and User and which should extend which:
I think User extending Person for most cases makes more sense than the other way around.
However, I'd rather see User as a composite wrapping or referencing a Person (or even possibly more than one ...) instead of extending it.
That also should solve the 'non-person' admin user use-case easily. As well as having person objects which are not used by/attached to any user account which IMO also an important use-case.
> Refactor Person
> ---------------
>
> Key: RAVE-630
> URL: https://issues.apache.org/jira/browse/RAVE-630
> Project: Rave
> Issue Type: Technical task
> Reporter: Matt Franklin
> Assignee: Matt Franklin
>
> Refactor Person object and related entitites
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-630) Refactor Person
Posted by "Matt Franklin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285252#comment-13285252 ]
Matt Franklin commented on RAVE-630:
------------------------------------
I think there are a lot of model issues that need to be cleaned up; especially in Person and Social data. The plan initially for this refactor was to just move everything to interfaces and then refactor the object model for simplicity after that.
In terms of Person extending User, we had discussed previously that objects should be tied to the Person rather than the User and User is only for authentication and authorization to the system as it has a bunch of account specific details. Of course, everything is up for discussion and nothing is set in stone.
> Refactor Person
> ---------------
>
> Key: RAVE-630
> URL: https://issues.apache.org/jira/browse/RAVE-630
> Project: Rave
> Issue Type: Technical task
> Reporter: Matt Franklin
> Assignee: Matt Franklin
>
> Refactor Person object and related entitites
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-630) Refactor Person
Posted by "Matt Franklin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285747#comment-13285747 ]
Matt Franklin commented on RAVE-630:
------------------------------------
Completely agree User should just reference person
> Refactor Person
> ---------------
>
> Key: RAVE-630
> URL: https://issues.apache.org/jira/browse/RAVE-630
> Project: Rave
> Issue Type: Technical task
> Reporter: Matt Franklin
> Assignee: Matt Franklin
>
> Refactor Person object and related entitites
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (RAVE-630) Refactor Person
Posted by "Chris Geer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285239#comment-13285239 ]
Chris Geer edited comment on RAVE-630 at 5/29/12 11:03 PM:
-----------------------------------------------------------
Based on the "OS Person" != "Rave User" comment [1], does it make more sense to have Person extend from User instead of User extend from Person as part of this refactor? I can see a case where you would need a Rave admin account that would never show up in a social context.
[1] http://mail-archives.apache.org/mod_mbox/rave-dev/201205.mbox/browser
was (Author: geerzo):
Based on the "OS Person" != "Rave User" [1], does it make more sense to have Person extend from User instead of User extend from Person as part of this refactor? I can see a case where you would need a Rave admin account that would never show up in a social context.
[1] http://mail-archives.apache.org/mod_mbox/rave-dev/201205.mbox/browser
> Refactor Person
> ---------------
>
> Key: RAVE-630
> URL: https://issues.apache.org/jira/browse/RAVE-630
> Project: Rave
> Issue Type: Technical task
> Reporter: Matt Franklin
> Assignee: Matt Franklin
>
> Refactor Person object and related entitites
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-630) Refactor Person
Posted by "Chris Geer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285738#comment-13285738 ]
Chris Geer commented on RAVE-630:
---------------------------------
You guys are right, move to interface first, then worry about the rest.
Ate, I was also thinking about something along the lines of your second option (referencing a person). That would give us the cleanest separation.
> Refactor Person
> ---------------
>
> Key: RAVE-630
> URL: https://issues.apache.org/jira/browse/RAVE-630
> Project: Rave
> Issue Type: Technical task
> Reporter: Matt Franklin
> Assignee: Matt Franklin
>
> Refactor Person object and related entitites
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (RAVE-630) Refactor Person
Posted by "Raminderjeet Singh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raminderjeet Singh closed RAVE-630.
-----------------------------------
> Refactor Person
> ---------------
>
> Key: RAVE-630
> URL: https://issues.apache.org/jira/browse/RAVE-630
> Project: Rave
> Issue Type: Technical task
> Reporter: Matt Franklin
> Assignee: Matt Franklin
> Fix For: 0.13
>
>
> Refactor Person object and related entitites
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (RAVE-630) Refactor Person
Posted by "Matt Franklin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Franklin resolved RAVE-630.
--------------------------------
Resolution: Fixed
> Refactor Person
> ---------------
>
> Key: RAVE-630
> URL: https://issues.apache.org/jira/browse/RAVE-630
> Project: Rave
> Issue Type: Technical task
> Reporter: Matt Franklin
> Assignee: Matt Franklin
>
> Refactor Person object and related entitites
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira