[GitHub] [hbase-filesystem] steveloughran commented on a change in pull request #30: HBASE-26483. [HBOSS] add support for openFile(path)

[GitBox <gi...@apache.org>]

steveloughran commented on a change in pull request #30:
URL: https://github.com/apache/hbase-filesystem/pull/30#discussion_r755898528



##########
File path: hbase-oss/src/main/java/org/apache/hadoop/hbase/oss/HBaseObjectStoreSemantics.java
##########
@@ -170,6 +173,26 @@ public FSDataInputStream open(Path f) throws IOException {
     }
   }
 
+  @Override
+  public FutureDataInputStreamBuilder openFile(final Path path)
+      throws IOException, UnsupportedOperationException {
+    return new LockedFutureDataInputStreamBuilder(sync, path,
+        fs.openFile(path));
+  }
+
+  /**
+   * This is mostly unsupported, and as there's no way to
+   * get the path from a pathHandle, impossible to lock.
+   * @param pathHandle path
+   * @return never returns successfully.
+   * @throws UnsupportedOperationException always
+   */
+  @Override
+  public FutureDataInputStreamBuilder openFile(final PathHandle pathHandle)
+      throws IOException, UnsupportedOperationException {
+    throw new UnsupportedOperationException("openFile(PathHandle) unsupported");
+  }
+

Review comment:
       yes, just reject it. you are currently never going to be trying to use hboss on a store which implements it (hdfs, webhdfs), but due diligence is always good




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org