You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/08 09:40:38 UTC
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #250: feat: ingress v1
tokers opened a new pull request #250:
URL: https://github.com/apache/apisix-ingress-controller/pull/250
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- Related issues
___
### Bugfix
- Description
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
___
### Backport patches
- Why need to backport?
- Source branch
- Related commits and pull requests
- Target branch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #250: feat: ingress v1
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #250:
URL: https://github.com/apache/apisix-ingress-controller/pull/250#discussion_r577574879
##########
File path: cmd/ingress/ingress_test.go
##########
@@ -105,6 +105,9 @@ func TestSignalHandler(t *testing.T) {
}
func TestNewIngressCommandEffectiveLog(t *testing.T) {
+ // Delay for 2 seconds to avoid conflicting with the
+ // TestSignalHandler case.
+ time.Sleep(2 * time.Second)
Review comment:
It is strange, if the port conflict, we need to retry.
##########
File path: docs/samples/proxy-the-httpbin-service-with-ingress.md
##########
@@ -0,0 +1,126 @@
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+# Proxy the httpbin service
+
+This document explains how apisix-ingress-controller guides Apache APISIX routes traffic to httpbin service correctly by the [Kubernetes Ingress](https://kubernetes.io/docs/concepts/services-networking/ingress/).
+
+## Prerequisites
+
+* Prepare an available Kubernetes cluster in your workstation, we recommend you to use [Minikube](https://github.com/kubernetes/minikube).
+* [Install Apache APISIX in Kubernetes by Helm Chart](https://github.com/apache/apisix-helm-chart).
+* Install [apisix-ingress-controller](https://github.com/apache/apisix-ingress-controller/blob/master/docs/install.md).
+
+## Deploy httpbin service
+
+We use [kennethreitz/httpbin](https://hub.docker.com/r/kennethreitz/httpbin/) as the service image, See its overview page for details.
+
+Now, try to deploy it to your Kubernetes cluster:
+
+```shell
+kubectl run httpbin --image kennethreitz/httpbin --port 80
+kubectl expose pod httpbin --port 80
+```
+
+## Resource Delivery
+
+Here we create an Ingress resource.
+
+```yaml
+# httpbin-ingress.yaml
+# Note use apiVersion is networking.k8s.io/v1, so please make sure your
+# Kubernetes cluster version is v1.19.0 or higher.
+apiVersion: networking.k8s.io/v1
+kind: Ingress
+metadata:
+ name: httpserver-ingress
+spec:
+ # apisix-ingress-controller is only interested in Ingress
+ # resources with the matched ingressClass name, in our case,
+ # it's apisix.
+ ingressClassName: apisix
+ rules:
+ - host: local.httpbin.org
+ http:
+ paths:
+ - backend:
+ service:
+ name: httpbin
+ port:
+ number: 80
+ path: /
+ pathType: Prefix
Review comment:
Should `Prefix` start with a capital letter? I think it is better to keep lowercase.
##########
File path: go.mod
##########
@@ -5,6 +5,7 @@ go 1.13
require (
github.com/gin-gonic/gin v1.6.3
github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
+ github.com/gruntwork-io/terratest v0.32.3 // indirect
Review comment:
Why we add this in ingress, we should only use this in e2e test.
##########
File path: go.mod
##########
@@ -5,6 +5,7 @@ go 1.13
require (
github.com/gin-gonic/gin v1.6.3
github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
+ github.com/gruntwork-io/terratest v0.32.3 // indirect
Review comment:
Why we add this in ingress, we should only use this in e2e test.
##########
File path: docs/samples/proxy-the-httpbin-service-with-ingress.md
##########
@@ -0,0 +1,126 @@
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+# Proxy the httpbin service
+
+This document explains how apisix-ingress-controller guides Apache APISIX routes traffic to httpbin service correctly by the [Kubernetes Ingress](https://kubernetes.io/docs/concepts/services-networking/ingress/).
+
+## Prerequisites
+
+* Prepare an available Kubernetes cluster in your workstation, we recommend you to use [Minikube](https://github.com/kubernetes/minikube).
+* [Install Apache APISIX in Kubernetes by Helm Chart](https://github.com/apache/apisix-helm-chart).
+* Install [apisix-ingress-controller](https://github.com/apache/apisix-ingress-controller/blob/master/docs/install.md).
+
+## Deploy httpbin service
+
+We use [kennethreitz/httpbin](https://hub.docker.com/r/kennethreitz/httpbin/) as the service image, See its overview page for details.
+
+Now, try to deploy it to your Kubernetes cluster:
+
+```shell
+kubectl run httpbin --image kennethreitz/httpbin --port 80
+kubectl expose pod httpbin --port 80
+```
+
+## Resource Delivery
+
+Here we create an Ingress resource.
+
+```yaml
+# httpbin-ingress.yaml
+# Note use apiVersion is networking.k8s.io/v1, so please make sure your
+# Kubernetes cluster version is v1.19.0 or higher.
+apiVersion: networking.k8s.io/v1
+kind: Ingress
+metadata:
+ name: httpserver-ingress
+spec:
+ # apisix-ingress-controller is only interested in Ingress
+ # resources with the matched ingressClass name, in our case,
+ # it's apisix.
+ ingressClassName: apisix
+ rules:
+ - host: local.httpbin.org
+ http:
+ paths:
+ - backend:
+ service:
+ name: httpbin
+ port:
+ number: 80
+ path: /
+ pathType: Prefix
+
+# Use ingress.networking.k8s.io/v1beta1 if your Kubernetes cluster
+# version is older than v1.19.0.
+apiVersion: networking.k8s.io/v1beta1
+kind: Ingress
+metadata:
+ name: httpserver-ingress
+ # Note for ingress.networking.k8s.io/v1beta1,
+ # you have to carry annotation kubernetes.io/ingress.class,
+ # and its value must be matched with the one configured in
+ # apisix-ingress-controller, in our case, it's apisix.
+ annotations:
+ kubernetes.io/ingress.class: apisix
+spec:
+ rules:
+ - host: local.httpbin.org
+ http:
+ paths:
+ - backend:
+ serviceName: httpbin
+ servicePort: 80
+ path: /
+ pathType: Prefix
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj merged pull request #250: feat: ingress v1
Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #250:
URL: https://github.com/apache/apisix-ingress-controller/pull/250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #250: feat: ingress v1
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #250:
URL: https://github.com/apache/apisix-ingress-controller/pull/250#issuecomment-775020837
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=h1) Report
> Merging [#250](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=desc) (f539f72) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/419a76acf7481c8cce6446439cfd21e95ea54085?el=desc) (419a76a) will **increase** coverage by `3.28%`.
> The diff coverage is `88.66%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
+ Coverage 48.13% 51.42% +3.28%
==========================================
Files 36 34 -2
Lines 2202 2320 +118
==========================================
+ Hits 1060 1193 +133
+ Misses 999 974 -25
- Partials 143 153 +10
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/ingress/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3JvdXRlLmdv) | `0.00% <ø> (ø)` | |
| [pkg/kube/translation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3Vwc3RyZWFtLmdv) | `92.54% <ø> (ø)` | |
| [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `54.68% <0.00%> (ø)` | |
| [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | `66.37% <50.00%> (-0.91%)` | :arrow_down: |
| [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `80.00% <50.00%> (-3.34%)` | :arrow_down: |
| [pkg/kube/translation/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vaW5ncmVzcy5nbw==) | `91.93% <91.93%> (ø)` | |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `73.97% <100.00%> (+2.76%)` | :arrow_up: |
| [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `77.31% <100.00%> (+0.23%)` | :arrow_up: |
| [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `40.52% <100.00%> (+0.78%)` | :arrow_up: |
| [pkg/seven/state/solver.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL3NldmVuL3N0YXRlL3NvbHZlci5nbw==) | `1.98% <0.00%> (-1.99%)` | :arrow_down: |
| ... and [5 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=footer). Last update [419a76a...f539f72](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #250: feat: ingress v1
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #250:
URL: https://github.com/apache/apisix-ingress-controller/pull/250#issuecomment-775020837
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=h1) Report
> Merging [#250](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=desc) (fa0d918) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/09787ed80507be7f2a7b97d3aefddd28cfcad4a6?el=desc) (09787ed) will **increase** coverage by `4.00%`.
> The diff coverage is `88.66%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
+ Coverage 48.41% 52.41% +4.00%
==========================================
Files 35 34 -1
Lines 2239 2358 +119
==========================================
+ Hits 1084 1236 +152
+ Misses 1007 966 -41
- Partials 148 156 +8
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/ingress/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3JvdXRlLmdv) | `0.00% <ø> (ø)` | |
| [pkg/kube/translation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3Vwc3RyZWFtLmdv) | `88.08% <ø> (ø)` | |
| [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `53.03% <0.00%> (ø)` | |
| [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | `66.37% <50.00%> (-0.91%)` | :arrow_down: |
| [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `80.00% <50.00%> (-3.34%)` | :arrow_down: |
| [pkg/kube/translation/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vaW5ncmVzcy5nbw==) | `91.93% <91.93%> (ø)` | |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `73.97% <100.00%> (+2.76%)` | :arrow_up: |
| [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `77.77% <100.00%> (+0.22%)` | :arrow_up: |
| [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `42.48% <100.00%> (+2.74%)` | :arrow_up: |
| [pkg/kube/init.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvaW5pdC5nbw==) | | |
| ... and [5 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=footer). Last update [09787ed...fa0d918](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #250: feat: ingress v1
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #250:
URL: https://github.com/apache/apisix-ingress-controller/pull/250#issuecomment-775020837
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=h1) Report
> Merging [#250](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=desc) (fa0d918) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/09787ed80507be7f2a7b97d3aefddd28cfcad4a6?el=desc) (09787ed) will **increase** coverage by `3.23%`.
> The diff coverage is `88.66%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
+ Coverage 48.41% 51.65% +3.23%
==========================================
Files 35 34 -1
Lines 2239 2358 +119
==========================================
+ Hits 1084 1218 +134
+ Misses 1007 982 -25
- Partials 148 158 +10
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/ingress/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3JvdXRlLmdv) | `0.00% <ø> (ø)` | |
| [pkg/kube/translation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3Vwc3RyZWFtLmdv) | `88.08% <ø> (ø)` | |
| [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `53.03% <0.00%> (ø)` | |
| [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | `66.37% <50.00%> (-0.91%)` | :arrow_down: |
| [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `80.00% <50.00%> (-3.34%)` | :arrow_down: |
| [pkg/kube/translation/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vaW5ncmVzcy5nbw==) | `91.93% <91.93%> (ø)` | |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `73.97% <100.00%> (+2.76%)` | :arrow_up: |
| [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `77.77% <100.00%> (+0.22%)` | :arrow_up: |
| [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `40.52% <100.00%> (+0.78%)` | :arrow_up: |
| [pkg/seven/state/solver.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL3NldmVuL3N0YXRlL3NvbHZlci5nbw==) | `1.98% <0.00%> (-1.99%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=footer). Last update [09787ed...fa0d918](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #250: feat: ingress v1
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #250:
URL: https://github.com/apache/apisix-ingress-controller/pull/250#issuecomment-775020837
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=h1) Report
> Merging [#250](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=desc) (21605a5) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/419a76acf7481c8cce6446439cfd21e95ea54085?el=desc) (419a76a) will **increase** coverage by `3.28%`.
> The diff coverage is `88.66%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
+ Coverage 48.13% 51.42% +3.28%
==========================================
Files 36 34 -2
Lines 2202 2320 +118
==========================================
+ Hits 1060 1193 +133
+ Misses 999 974 -25
- Partials 143 153 +10
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/ingress/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3JvdXRlLmdv) | `0.00% <ø> (ø)` | |
| [pkg/kube/translation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3Vwc3RyZWFtLmdv) | `92.54% <ø> (ø)` | |
| [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `54.68% <0.00%> (ø)` | |
| [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | `66.37% <50.00%> (-0.91%)` | :arrow_down: |
| [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `80.00% <50.00%> (-3.34%)` | :arrow_down: |
| [pkg/kube/translation/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vaW5ncmVzcy5nbw==) | `91.93% <91.93%> (ø)` | |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `73.97% <100.00%> (+2.76%)` | :arrow_up: |
| [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `77.31% <100.00%> (+0.23%)` | :arrow_up: |
| [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `40.52% <100.00%> (+0.78%)` | :arrow_up: |
| [pkg/seven/state/solver.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL3NldmVuL3N0YXRlL3NvbHZlci5nbw==) | `1.98% <0.00%> (-1.99%)` | :arrow_down: |
| ... and [5 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=footer). Last update [419a76a...21605a5](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #250: feat: ingress v1
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #250:
URL: https://github.com/apache/apisix-ingress-controller/pull/250#issuecomment-775020837
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=h1) Report
> Merging [#250](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=desc) (fa0d918) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/09787ed80507be7f2a7b97d3aefddd28cfcad4a6?el=desc) (09787ed) will **increase** coverage by `3.32%`.
> The diff coverage is `88.66%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
+ Coverage 48.41% 51.73% +3.32%
==========================================
Files 35 34 -1
Lines 2239 2358 +119
==========================================
+ Hits 1084 1220 +136
+ Misses 1007 980 -27
- Partials 148 158 +10
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/ingress/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3JvdXRlLmdv) | `0.00% <ø> (ø)` | |
| [pkg/kube/translation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3Vwc3RyZWFtLmdv) | `88.08% <ø> (ø)` | |
| [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `53.03% <0.00%> (ø)` | |
| [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | `66.37% <50.00%> (-0.91%)` | :arrow_down: |
| [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `80.00% <50.00%> (-3.34%)` | :arrow_down: |
| [pkg/kube/translation/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vaW5ncmVzcy5nbw==) | `91.93% <91.93%> (ø)` | |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `73.97% <100.00%> (+2.76%)` | :arrow_up: |
| [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `77.77% <100.00%> (+0.22%)` | :arrow_up: |
| [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `40.52% <100.00%> (+0.78%)` | :arrow_up: |
| [pkg/kube/init.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvaW5pdC5nbw==) | | |
| ... and [3 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=footer). Last update [09787ed...fa0d918](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #250: feat: ingress v1
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #250:
URL: https://github.com/apache/apisix-ingress-controller/pull/250#discussion_r578061215
##########
File path: go.mod
##########
@@ -5,6 +5,7 @@ go 1.13
require (
github.com/gin-gonic/gin v1.6.3
github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
+ github.com/gruntwork-io/terratest v0.32.3 // indirect
Review comment:
Fixed.
##########
File path: go.mod
##########
@@ -5,6 +5,7 @@ go 1.13
require (
github.com/gin-gonic/gin v1.6.3
github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
+ github.com/gruntwork-io/terratest v0.32.3 // indirect
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #250: feat: ingress v1
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #250:
URL: https://github.com/apache/apisix-ingress-controller/pull/250#issuecomment-781221811
@gxthrj Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #250: feat: ingress v1
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #250:
URL: https://github.com/apache/apisix-ingress-controller/pull/250#discussion_r578065288
##########
File path: cmd/ingress/ingress_test.go
##########
@@ -105,6 +105,9 @@ func TestSignalHandler(t *testing.T) {
}
func TestNewIngressCommandEffectiveLog(t *testing.T) {
+ // Delay for 2 seconds to avoid conflicting with the
+ // TestSignalHandler case.
+ time.Sleep(2 * time.Second)
Review comment:
Fixed by another way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #250: feat: ingress v1
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #250:
URL: https://github.com/apache/apisix-ingress-controller/pull/250#issuecomment-775020837
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=h1) Report
> Merging [#250](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=desc) (5e9a80d) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/09787ed80507be7f2a7b97d3aefddd28cfcad4a6?el=desc) (09787ed) will **increase** coverage by `3.23%`.
> The diff coverage is `88.66%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
+ Coverage 48.41% 51.65% +3.23%
==========================================
Files 35 34 -1
Lines 2239 2358 +119
==========================================
+ Hits 1084 1218 +134
+ Misses 1007 982 -25
- Partials 148 158 +10
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/ingress/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3JvdXRlLmdv) | `0.00% <ø> (ø)` | |
| [pkg/kube/translation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3Vwc3RyZWFtLmdv) | `88.08% <ø> (ø)` | |
| [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `53.03% <0.00%> (ø)` | |
| [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | `66.37% <50.00%> (-0.91%)` | :arrow_down: |
| [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `80.00% <50.00%> (-3.34%)` | :arrow_down: |
| [pkg/kube/translation/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vaW5ncmVzcy5nbw==) | `91.93% <91.93%> (ø)` | |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `73.97% <100.00%> (+2.76%)` | :arrow_up: |
| [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `77.77% <100.00%> (+0.22%)` | :arrow_up: |
| [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `40.52% <100.00%> (+0.78%)` | :arrow_up: |
| [pkg/seven/state/solver.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL3NldmVuL3N0YXRlL3NvbHZlci5nbw==) | `1.98% <0.00%> (-1.99%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=footer). Last update [09787ed...5e9a80d](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #250: feat: ingress v1
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #250:
URL: https://github.com/apache/apisix-ingress-controller/pull/250#issuecomment-775020837
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=h1) Report
> Merging [#250](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=desc) (2fb1203) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/fe0edaf7f3e8f8ffb5808c9f2e0860ee6fae295a?el=desc) (fe0edaf) will **increase** coverage by `54.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #250 +/- ##
============================================
+ Coverage 45.99% 100.00% +54.00%
============================================
Files 35 1 -34
Lines 2061 1 -2060
============================================
- Hits 948 1 -947
+ Misses 974 0 -974
+ Partials 139 0 -139
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/types/timeduration.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL3R5cGVzL3RpbWVkdXJhdGlvbi5nbw==) | | |
| [pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv) | | |
| [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | | |
| [pkg/ingress/apisix/tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3Rscy5nbw==) | | |
| [pkg/log/logger.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dnZXIuZ28=) | | |
| [pkg/log/default\_logger.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2xvZy9kZWZhdWx0X2xvZ2dlci5nbw==) | | |
| [pkg/types/errors.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL3R5cGVzL2Vycm9ycy5nbw==) | | |
| [pkg/ingress/apisix/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3BsdWdpbi5nbw==) | | |
| [pkg/api/server.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaS9zZXJ2ZXIuZ28=) | | |
| [pkg/types/event.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL3R5cGVzL2V2ZW50Lmdv) | | |
| ... and [22 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=footer). Last update [fe0edaf...2fb1203](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #250: feat: ingress v1
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #250:
URL: https://github.com/apache/apisix-ingress-controller/pull/250#issuecomment-775020837
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=h1) Report
> Merging [#250](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=desc) (1453156) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/09787ed80507be7f2a7b97d3aefddd28cfcad4a6?el=desc) (09787ed) will **increase** coverage by `3.23%`.
> The diff coverage is `88.66%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
+ Coverage 48.41% 51.65% +3.23%
==========================================
Files 35 34 -1
Lines 2239 2358 +119
==========================================
+ Hits 1084 1218 +134
+ Misses 1007 982 -25
- Partials 148 158 +10
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/ingress/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3JvdXRlLmdv) | `0.00% <ø> (ø)` | |
| [pkg/kube/translation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3Vwc3RyZWFtLmdv) | `88.08% <ø> (ø)` | |
| [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `53.03% <0.00%> (ø)` | |
| [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | `66.37% <50.00%> (-0.91%)` | :arrow_down: |
| [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `80.00% <50.00%> (-3.34%)` | :arrow_down: |
| [pkg/kube/translation/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vaW5ncmVzcy5nbw==) | `91.93% <91.93%> (ø)` | |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `73.97% <100.00%> (+2.76%)` | :arrow_up: |
| [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `77.77% <100.00%> (+0.22%)` | :arrow_up: |
| [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `40.52% <100.00%> (+0.78%)` | :arrow_up: |
| [pkg/seven/state/solver.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL3NldmVuL3N0YXRlL3NvbHZlci5nbw==) | `1.98% <0.00%> (-1.99%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=footer). Last update [09787ed...1453156](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #250: feat: ingress v1
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #250:
URL: https://github.com/apache/apisix-ingress-controller/pull/250#issuecomment-775020837
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=h1) Report
> Merging [#250](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=desc) (456865d) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/419a76acf7481c8cce6446439cfd21e95ea54085?el=desc) (419a76a) will **increase** coverage by `51.86%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #250 +/- ##
============================================
+ Coverage 48.13% 100.00% +51.86%
============================================
Files 36 1 -35
Lines 2202 1 -2201
============================================
- Hits 1060 1 -1059
+ Misses 999 0 -999
+ Partials 143 0 -143
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/kube/infra.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvaW5mcmEuZ28=) | | |
| [pkg/log/options.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2xvZy9vcHRpb25zLmdv) | | |
| [pkg/types/errors.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL3R5cGVzL2Vycm9ycy5nbw==) | | |
| [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | | |
| [pkg/kube/init.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvaW5pdC5nbw==) | | |
| [pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv) | | |
| [pkg/seven/conf/conf.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL3NldmVuL2NvbmYvY29uZi5nbw==) | | |
| [pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==) | | |
| [pkg/types/timeduration.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL3R5cGVzL3RpbWVkdXJhdGlvbi5nbw==) | | |
| [pkg/log/logger.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dnZXIuZ28=) | | |
| ... and [20 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=footer). Last update [419a76a...456865d](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #250: feat: ingress v1
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #250:
URL: https://github.com/apache/apisix-ingress-controller/pull/250#issuecomment-781202136
There are some conflicting files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #250: feat: ingress v1
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #250:
URL: https://github.com/apache/apisix-ingress-controller/pull/250#discussion_r578060717
##########
File path: docs/samples/proxy-the-httpbin-service-with-ingress.md
##########
@@ -0,0 +1,126 @@
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+# Proxy the httpbin service
+
+This document explains how apisix-ingress-controller guides Apache APISIX routes traffic to httpbin service correctly by the [Kubernetes Ingress](https://kubernetes.io/docs/concepts/services-networking/ingress/).
+
+## Prerequisites
+
+* Prepare an available Kubernetes cluster in your workstation, we recommend you to use [Minikube](https://github.com/kubernetes/minikube).
+* [Install Apache APISIX in Kubernetes by Helm Chart](https://github.com/apache/apisix-helm-chart).
+* Install [apisix-ingress-controller](https://github.com/apache/apisix-ingress-controller/blob/master/docs/install.md).
+
+## Deploy httpbin service
+
+We use [kennethreitz/httpbin](https://hub.docker.com/r/kennethreitz/httpbin/) as the service image, See its overview page for details.
+
+Now, try to deploy it to your Kubernetes cluster:
+
+```shell
+kubectl run httpbin --image kennethreitz/httpbin --port 80
+kubectl expose pod httpbin --port 80
+```
+
+## Resource Delivery
+
+Here we create an Ingress resource.
+
+```yaml
+# httpbin-ingress.yaml
+# Note use apiVersion is networking.k8s.io/v1, so please make sure your
+# Kubernetes cluster version is v1.19.0 or higher.
+apiVersion: networking.k8s.io/v1
+kind: Ingress
+metadata:
+ name: httpserver-ingress
+spec:
+ # apisix-ingress-controller is only interested in Ingress
+ # resources with the matched ingressClass name, in our case,
+ # it's apisix.
+ ingressClassName: apisix
+ rules:
+ - host: local.httpbin.org
+ http:
+ paths:
+ - backend:
+ service:
+ name: httpbin
+ port:
+ number: 80
+ path: /
+ pathType: Prefix
Review comment:
Well, it's the specification, the `pathType` can be :
* `Exact`
* `Prefix`
* `ImplementationSpecific`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #250: feat: ingress v1
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #250:
URL: https://github.com/apache/apisix-ingress-controller/pull/250#issuecomment-775020837
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=h1) Report
> Merging [#250](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=desc) (fa0d918) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/09787ed80507be7f2a7b97d3aefddd28cfcad4a6?el=desc) (09787ed) will **increase** coverage by `4.00%`.
> The diff coverage is `88.66%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
+ Coverage 48.41% 52.41% +4.00%
==========================================
Files 35 34 -1
Lines 2239 2358 +119
==========================================
+ Hits 1084 1236 +152
+ Misses 1007 966 -41
- Partials 148 156 +8
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/ingress/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3JvdXRlLmdv) | `0.00% <ø> (ø)` | |
| [pkg/kube/translation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3Vwc3RyZWFtLmdv) | `88.08% <ø> (ø)` | |
| [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `53.03% <0.00%> (ø)` | |
| [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | `66.37% <50.00%> (-0.91%)` | :arrow_down: |
| [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `80.00% <50.00%> (-3.34%)` | :arrow_down: |
| [pkg/kube/translation/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vaW5ncmVzcy5nbw==) | `91.93% <91.93%> (ø)` | |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `73.97% <100.00%> (+2.76%)` | :arrow_up: |
| [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `77.77% <100.00%> (+0.22%)` | :arrow_up: |
| [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `42.48% <100.00%> (+2.74%)` | :arrow_up: |
| [pkg/kube/init.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvaW5pdC5nbw==) | | |
| ... and [5 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=footer). Last update [09787ed...fa0d918](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #250: feat: ingress v1
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #250:
URL: https://github.com/apache/apisix-ingress-controller/pull/250#issuecomment-775020837
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=h1) Report
> Merging [#250](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=desc) (005b035) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/09787ed80507be7f2a7b97d3aefddd28cfcad4a6?el=desc) (09787ed) will **increase** coverage by `3.23%`.
> The diff coverage is `88.66%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
+ Coverage 48.41% 51.65% +3.23%
==========================================
Files 35 34 -1
Lines 2239 2358 +119
==========================================
+ Hits 1084 1218 +134
+ Misses 1007 982 -25
- Partials 148 158 +10
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/ingress/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3JvdXRlLmdv) | `0.00% <ø> (ø)` | |
| [pkg/kube/translation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3Vwc3RyZWFtLmdv) | `88.08% <ø> (ø)` | |
| [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `53.03% <0.00%> (ø)` | |
| [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | `66.37% <50.00%> (-0.91%)` | :arrow_down: |
| [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `80.00% <50.00%> (-3.34%)` | :arrow_down: |
| [pkg/kube/translation/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vaW5ncmVzcy5nbw==) | `91.93% <91.93%> (ø)` | |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `73.97% <100.00%> (+2.76%)` | :arrow_up: |
| [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `77.77% <100.00%> (+0.22%)` | :arrow_up: |
| [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `40.52% <100.00%> (+0.78%)` | :arrow_up: |
| [pkg/seven/state/solver.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL3NldmVuL3N0YXRlL3NvbHZlci5nbw==) | `1.98% <0.00%> (-1.99%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=footer). Last update [09787ed...005b035](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #250: feat: ingress v1
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #250:
URL: https://github.com/apache/apisix-ingress-controller/pull/250#issuecomment-775020837
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=h1) Report
> Merging [#250](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=desc) (5d08f86) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/419a76acf7481c8cce6446439cfd21e95ea54085?el=desc) (419a76a) will **decrease** coverage by `1.17%`.
> The diff coverage is `3.70%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
- Coverage 48.13% 46.96% -1.18%
==========================================
Files 36 36
Lines 2202 2255 +53
==========================================
- Hits 1060 1059 -1
- Misses 999 1053 +54
Partials 143 143
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/kube/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvaW5ncmVzcy5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/kube/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRvci5nbw==) | `41.93% <0.00%> (-0.69%)` | :arrow_down: |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `71.64% <100.00%> (+0.42%)` | :arrow_up: |
| [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `83.78% <100.00%> (+0.45%)` | :arrow_up: |
| [pkg/seven/state/solver.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL3NldmVuL3N0YXRlL3NvbHZlci5nbw==) | `1.98% <0.00%> (-1.99%)` | :arrow_down: |
| [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-dGVzdC9lMmUvZTJlLmdv) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=footer). Last update [419a76a...5d08f86](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #250: feat: ingress v1
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #250:
URL: https://github.com/apache/apisix-ingress-controller/pull/250#issuecomment-775020837
# [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=h1) Report
> Merging [#250](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=desc) (c8a2908) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/09787ed80507be7f2a7b97d3aefddd28cfcad4a6?el=desc) (09787ed) will **increase** coverage by `3.23%`.
> The diff coverage is `88.66%`.
[](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #250 +/- ##
==========================================
+ Coverage 48.41% 51.65% +3.23%
==========================================
Files 35 34 -1
Lines 2239 2358 +119
==========================================
+ Hits 1084 1218 +134
+ Misses 1007 982 -25
- Partials 148 158 +10
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/ingress/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3JvdXRlLmdv) | `0.00% <ø> (ø)` | |
| [pkg/kube/translation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3Vwc3RyZWFtLmdv) | `88.08% <ø> (ø)` | |
| [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `53.03% <0.00%> (ø)` | |
| [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | `66.37% <50.00%> (-0.91%)` | :arrow_down: |
| [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `80.00% <50.00%> (-3.34%)` | :arrow_down: |
| [pkg/kube/translation/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vaW5ncmVzcy5nbw==) | `91.93% <91.93%> (ø)` | |
| [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `73.97% <100.00%> (+2.76%)` | :arrow_up: |
| [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `77.77% <100.00%> (+0.22%)` | :arrow_up: |
| [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `40.52% <100.00%> (+0.78%)` | :arrow_up: |
| [pkg/seven/state/solver.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree#diff-cGtnL3NldmVuL3N0YXRlL3NvbHZlci5nbw==) | `1.98% <0.00%> (-1.99%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=footer). Last update [09787ed...c8a2908](https://codecov.io/gh/apache/apisix-ingress-controller/pull/250?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #250: feat: ingress v1
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #250:
URL: https://github.com/apache/apisix-ingress-controller/pull/250#discussion_r578060348
##########
File path: cmd/ingress/ingress_test.go
##########
@@ -105,6 +105,9 @@ func TestSignalHandler(t *testing.T) {
}
func TestNewIngressCommandEffectiveLog(t *testing.T) {
+ // Delay for 2 seconds to avoid conflicting with the
+ // TestSignalHandler case.
+ time.Sleep(2 * time.Second)
Review comment:
Not the conflicts of port, just like the conflicts about terminal (stdout).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org