You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ev...@apache.org on 2003/08/29 13:27:50 UTC
cvs commit: maven/src/java/org/apache/maven/jelly/tags/maven SnapshotSignature.java
evenisse 2003/08/29 04:27:50
Modified: src/java/org/apache/maven/jelly/tags/maven
SnapshotSignature.java
Log:
MAVEN-750. Add current version to snapshotSignature
Revision Changes Path
1.10 +4 -2 maven/src/java/org/apache/maven/jelly/tags/maven/SnapshotSignature.java
Index: SnapshotSignature.java
===================================================================
RCS file: /home/cvs/maven/src/java/org/apache/maven/jelly/tags/maven/SnapshotSignature.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- SnapshotSignature.java 19 Aug 2003 04:25:39 -0000 1.9
+++ SnapshotSignature.java 29 Aug 2003 11:27:50 -0000 1.10
@@ -111,7 +111,9 @@
SimpleDateFormat formatter = new SimpleDateFormat( "yyyyMMdd.HHmmss" );
formatter.setTimeZone( TimeZone.getTimeZone( "GMT" ) );
String snapshotVersion = formatter.format( now );
- String snapshotSignature = getProject().getArtifactId() + "-" + snapshotVersion;
+ String snapshotSignature = getProject().getArtifactId() + "-" +
+ getProject().getCurrentVersion() + "-" +
+ snapshotVersion;
context.setVariable( "snapshotSignature", snapshotSignature );
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: cvs commit: maven/src/java/org/apache/maven/jelly/tags/maven
SnapshotSignature.java
Posted by Jason van Zyl <jv...@maven.org>.
On Mon, 2003-09-01 at 11:41, Emmanuel Venisse wrote:
> ----- Original Message -----
> From: <di...@multitask.com.au>
> To: "Maven Developers List" <de...@maven.apache.org>
> Sent: Monday, September 01, 2003 3:22 PM
> Subject: Re: cvs commit: maven/src/java/org/apache/maven/jelly/tags/maven
> SnapshotSignature.java
>
>
> > "Emmanuel Venisse" <ev...@ifrance.com> wrote on 01/09/2003 07:43:41 PM:
> >
> > > > Hey Emannuelle,
> > > My name is Emmanuel!!!
> > Woops, sorry about that. I thought I had it wrong as I typed it.
> >
> > > > what happens if the version is something like 1.3-SNAPSHOT?
> > > >
> > > > I'm -1 on this change for the above reason, as it breaks existing
> > > > assumptions.
> > > I think that current version is necessary in jar name for project that
> > work
> > > on several version/branch. When You download the jar, I think you want
> > to
> > > know the version you use.
> > ${pom.currentVersion} wont have a branch in it, so it doesn't solve that
> > case.
> Yes, but suppose (for example) that we want to release a daily version of
> maven rc1 and maven rc1 refactor with the jar:snapshot goal. If we don't use
> the version in jar name, we'll obtain for both jars
> maven-yyyyMMdd.HHmmss.jar
> Which corresponds to rc1 and which corresponds to rc1 refactor?
> We don't have the problem if the version is included into the jar name.
This was decided long ago that it is simply SNAPSHOT. Whatever you
decide to present to the world as your SNAPSHOT is your snapshot. There
are problems trying to automatically flip SNAPSHOTS in the release
plugin when there are multiple SNAPSHOTs. Multiplicity is a simplicity
killer, much like having multiple source directories. I am -1 on putting
the version in the SNAPSHOT so please back it out.
> >
> > I can see why you want the version number, i.e. maven-1.0-rc1-SNAPSHOT.jar
> >
> > if that's the case, people can just do a jar:deploy or jar:install, no?
> Yes, but if we want to create daily release, we'll use jar:snapshot.
>
>
> >
> > > For version that ends with SNAPSHOT, we can cut the end and make the
> > > snapshot signature with current version without snapshot string.
> > I'd much rather people put the -SNAPSHOT in the project.xml like we have
> > now.
> >
> > > If you're always -1, I'll rollback my changes, but I think that's a best
> > > practices to have the version in the jar name.
> > I agree. What comments do you have on the stuff I wrote above?
>
> Do you want a rollback or not?
>
>
> >
> > p.s. thanks for all the work lately!
> > --
> > dIon Gillard, Multitask Consulting
> > Blog: http://blogs.codehaus.org/people/dion/
> >
> >
> >
>
> _____________________________________________________________________
> Envie de discuter en "live" avec vos amis ? Télécharger MSN Messenger
> http://www.ifrance.com/_reloc/m la 1ère messagerie instantanée de France
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
--
jvz.
Jason van Zyl
jason@zenplex.com
http://tambora.zenplex.org
In short, man creates for himself a new religion of a rational
and technical order to justify his work and to be justified in it.
-- Jacques Ellul, The Technological Society
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: cvs commit: maven/src/java/org/apache/maven/jelly/tags/maven SnapshotSignature.java
Posted by Emmanuel Venisse <ev...@ifrance.com>.
----- Original Message -----
From: <di...@multitask.com.au>
To: "Maven Developers List" <de...@maven.apache.org>
Sent: Monday, September 01, 2003 3:22 PM
Subject: Re: cvs commit: maven/src/java/org/apache/maven/jelly/tags/maven
SnapshotSignature.java
> "Emmanuel Venisse" <ev...@ifrance.com> wrote on 01/09/2003 07:43:41 PM:
>
> > > Hey Emannuelle,
> > My name is Emmanuel!!!
> Woops, sorry about that. I thought I had it wrong as I typed it.
>
> > > what happens if the version is something like 1.3-SNAPSHOT?
> > >
> > > I'm -1 on this change for the above reason, as it breaks existing
> > > assumptions.
> > I think that current version is necessary in jar name for project that
> work
> > on several version/branch. When You download the jar, I think you want
> to
> > know the version you use.
> ${pom.currentVersion} wont have a branch in it, so it doesn't solve that
> case.
Yes, but suppose (for example) that we want to release a daily version of
maven rc1 and maven rc1 refactor with the jar:snapshot goal. If we don't use
the version in jar name, we'll obtain for both jars
maven-yyyyMMdd.HHmmss.jar
Which corresponds to rc1 and which corresponds to rc1 refactor?
We don't have the problem if the version is included into the jar name.
>
> I can see why you want the version number, i.e. maven-1.0-rc1-SNAPSHOT.jar
>
> if that's the case, people can just do a jar:deploy or jar:install, no?
Yes, but if we want to create daily release, we'll use jar:snapshot.
>
> > For version that ends with SNAPSHOT, we can cut the end and make the
> > snapshot signature with current version without snapshot string.
> I'd much rather people put the -SNAPSHOT in the project.xml like we have
> now.
>
> > If you're always -1, I'll rollback my changes, but I think that's a best
> > practices to have the version in the jar name.
> I agree. What comments do you have on the stuff I wrote above?
Do you want a rollback or not?
>
> p.s. thanks for all the work lately!
> --
> dIon Gillard, Multitask Consulting
> Blog: http://blogs.codehaus.org/people/dion/
>
>
>
_____________________________________________________________________
Envie de discuter en "live" avec vos amis ? Télécharger MSN Messenger
http://www.ifrance.com/_reloc/m la 1ère messagerie instantanée de France
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: cvs commit: maven/src/java/org/apache/maven/jelly/tags/maven
SnapshotSignature.java
Posted by di...@multitask.com.au.
"Emmanuel Venisse" <ev...@ifrance.com> wrote on 01/09/2003 07:43:41 PM:
> > Hey Emannuelle,
> My name is Emmanuel!!!
Woops, sorry about that. I thought I had it wrong as I typed it.
> > what happens if the version is something like 1.3-SNAPSHOT?
> >
> > I'm -1 on this change for the above reason, as it breaks existing
> > assumptions.
> I think that current version is necessary in jar name for project that
work
> on several version/branch. When You download the jar, I think you want
to
> know the version you use.
${pom.currentVersion} wont have a branch in it, so it doesn't solve that
case.
I can see why you want the version number, i.e. maven-1.0-rc1-SNAPSHOT.jar
if that's the case, people can just do a jar:deploy or jar:install, no?
> For version that ends with SNAPSHOT, we can cut the end and make the
> snapshot signature with current version without snapshot string.
I'd much rather people put the -SNAPSHOT in the project.xml like we have
now.
> If you're always -1, I'll rollback my changes, but I think that's a best
> practices to have the version in the jar name.
I agree. What comments do you have on the stuff I wrote above?
p.s. thanks for all the work lately!
--
dIon Gillard, Multitask Consulting
Blog: http://blogs.codehaus.org/people/dion/
Re: cvs commit: maven/src/java/org/apache/maven/jelly/tags/maven SnapshotSignature.java
Posted by Emmanuel Venisse <ev...@ifrance.com>.
> Hey Emannuelle,
My name is Emmanuel!!!
>
> what happens if the version is something like 1.3-SNAPSHOT?
>
> I'm -1 on this change for the above reason, as it breaks existing
> assumptions.
I think that current version is necessary in jar name for project that work
on several version/branch. When You download the jar, I think you want to
know the version you use.
For version that ends with SNAPSHOT, we can cut the end and make the
snapshot signature with current version without snapshot string.
If you're always -1, I'll rollback my changes, but I think that's a best
practices to have the version in the jar name.
>
> Anyone else have some ideas?
> --
> dIon Gillard, Multitask Consulting
> Blog: http://blogs.codehaus.org/people/dion/
>
>
> evenisse@apache.org wrote on 29/08/2003 09:27:50 PM:
>
> > evenisse 2003/08/29 04:27:50
> >
> > Modified: src/java/org/apache/maven/jelly/tags/maven
> > SnapshotSignature.java
> > Log:
> > MAVEN-750. Add current version to snapshotSignature
> >
> > Revision Changes Path
> > 1.10 +4 -2
> > maven/src/java/org/apache/maven/jelly/tags/maven/SnapshotSignature.java
> >
> > Index: SnapshotSignature.java
> > ===================================================================
> > RCS file:
> >
>
/home/cvs/maven/src/java/org/apache/maven/jelly/tags/maven/SnapshotSignature
.
> > java,v
> > retrieving revision 1.9
> > retrieving revision 1.10
> > diff -u -r1.9 -r1.10
> > --- SnapshotSignature.java 19 Aug 2003 04:25:39 -0000 1.9
> > +++ SnapshotSignature.java 29 Aug 2003 11:27:50 -0000 1.10
> > @@ -111,7 +111,9 @@
> > SimpleDateFormat formatter = new SimpleDateFormat(
> > "yyyyMMdd.HHmmss" );
> > formatter.setTimeZone( TimeZone.getTimeZone( "GMT" ) );
> > String snapshotVersion = formatter.format( now );
> > - String snapshotSignature = getProject().getArtifactId() +
> > "-" + snapshotVersion;
> > + String snapshotSignature = getProject().getArtifactId() + "-"
> +
> > + getProject().getCurrentVersion() +
> "-" +
> > + snapshotVersion;
> >
> > context.setVariable( "snapshotSignature", snapshotSignature
> );
> >
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
>
_____________________________________________________________________
Envie de discuter en "live" avec vos amis ? Télécharger MSN Messenger
http://www.ifrance.com/_reloc/m la 1ère messagerie instantanée de France
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: cvs commit: maven/src/java/org/apache/maven/jelly/tags/maven
SnapshotSignature.java
Posted by di...@multitask.com.au.
Hey Emannuelle,
what happens if the version is something like 1.3-SNAPSHOT?
I'm -1 on this change for the above reason, as it breaks existing
assumptions.
Anyone else have some ideas?
--
dIon Gillard, Multitask Consulting
Blog: http://blogs.codehaus.org/people/dion/
evenisse@apache.org wrote on 29/08/2003 09:27:50 PM:
> evenisse 2003/08/29 04:27:50
>
> Modified: src/java/org/apache/maven/jelly/tags/maven
> SnapshotSignature.java
> Log:
> MAVEN-750. Add current version to snapshotSignature
>
> Revision Changes Path
> 1.10 +4 -2
> maven/src/java/org/apache/maven/jelly/tags/maven/SnapshotSignature.java
>
> Index: SnapshotSignature.java
> ===================================================================
> RCS file:
>
/home/cvs/maven/src/java/org/apache/maven/jelly/tags/maven/SnapshotSignature.
> java,v
> retrieving revision 1.9
> retrieving revision 1.10
> diff -u -r1.9 -r1.10
> --- SnapshotSignature.java 19 Aug 2003 04:25:39 -0000 1.9
> +++ SnapshotSignature.java 29 Aug 2003 11:27:50 -0000 1.10
> @@ -111,7 +111,9 @@
> SimpleDateFormat formatter = new SimpleDateFormat(
> "yyyyMMdd.HHmmss" );
> formatter.setTimeZone( TimeZone.getTimeZone( "GMT" ) );
> String snapshotVersion = formatter.format( now );
> - String snapshotSignature = getProject().getArtifactId() +
> "-" + snapshotVersion;
> + String snapshotSignature = getProject().getArtifactId() + "-"
+
> + getProject().getCurrentVersion() +
"-" +
> + snapshotVersion;
>
> context.setVariable( "snapshotSignature", snapshotSignature
);
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>