You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by rhtyd <gi...@git.apache.org> on 2016/05/12 12:47:40 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...
GitHub user rhtyd opened a pull request:
https://github.com/apache/cloudstack/pull/1540
CLOUDSTACK-9377: Fix metrics pagesize issue
Fixes listing of clusters and host to list all clusters/hosts by passing
pagesize=-1.
/cc @koushik-das @swill @DaanHoogland -- fixes the issue raised on dev@ ML by Rashmi
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack metrics-pagesize-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1540.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1540
----
commit 591c9b40563ad115ddcc97456bb2fe082a3b1cfb
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2016-05-12T12:44:06Z
CLOUDSTACK-9377: Fix metrics pagesize issue
Fixes listing of clusters and host to list all clusters/hosts by passing
pagesize=-1.
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-220675720
Thanks @swill
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-219400690
@rhtyd While the change looks simple, what happens in case there are say > 1K hosts, > 10K VMs with this fix?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-220632778
Ya, sorry, I had a backlog of commits that were ready while I sorted out some merge conflicts doing a forward merge from 4.8 and then testing the resulting master to make sure nothing was broken. I got a bunch of PRs merged in this morning. Thanks for the patience. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1540
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...
Posted by rhtyd <gi...@git.apache.org>.
GitHub user rhtyd reopened a pull request:
https://github.com/apache/cloudstack/pull/1540
CLOUDSTACK-9377: Fix metrics pagesize issue
Fixes listing of clusters and host to list all clusters/hosts by passing
pagesize=-1.
/cc @koushik-das @swill @DaanHoogland -- fixes the issue raised on dev@ ML by Rashmi
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack metrics-pagesize-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1540.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1540
----
commit 591c9b40563ad115ddcc97456bb2fe082a3b1cfb
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2016-05-12T12:44:06Z
CLOUDSTACK-9377: Fix metrics pagesize issue
Fixes listing of clusters and host to list all clusters/hosts by passing
pagesize=-1.
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-219450328
Man something is up with Jenkins now days. We have a completely different set of errors now. There seems to be two or three different situations that different PRs seem to be hitting and I am not sure what to do about it. :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-220545140
@swill let's merge this? thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-218945981
@swill screenshots to prove it does not break the existing; in the screenshot we see pagesize passed as -1 (i.e lists all). The pagesize change is only in zone and cluster metrics view.
Zone metrics view:
Cluster metrics view:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-219615189
@swill it's all green now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/1540
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/1540
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-218746528
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-219416836
@koushik-das I'm assuming, pragmatically no one should have 1k or 10k hosts in a `single` cluster; or similarly 1k or 10k clusters in a `single` zone.
@swill I'll push -f
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-219415201
Looks like travis is complaining. Not sure why...
```
======================================================================
ERROR: test suite for <class 'integration.component.test_acl_listsnapshot.TestSnapshotList'>
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/travis/.local/lib/python2.7/site-packages/nose/suite.py", line 228, in run
self.tearDown()
File "/home/travis/.local/lib/python2.7/site-packages/nose/suite.py", line 351, in tearDown
self.teardownContext(ancestor)
File "/home/travis/.local/lib/python2.7/site-packages/nose/suite.py", line 367, in teardownContext
try_run(context, names)
File "/home/travis/.local/lib/python2.7/site-packages/nose/util.py", line 471, in try_run
return func()
File "/home/travis/build/apache/cloudstack/test/integration/component/test_acl_listsnapshot.py", line 374, in tearDownClass
cls.domain_2.delete(cls.apiclient,cleanup="true")
File "/home/travis/.local/lib/python2.7/site-packages/marvin/lib/base.py", line 78, in delete
apiclient.deleteDomain(cmd)
File "/home/travis/.local/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 703, in deleteDomain
response = self.connection.marvinRequest(command, response_type=response, method=method)
File "/home/travis/.local/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest
raise e
Exception: Job failed: {jobprocstatus : 0, created : u'2016-05-14T06:35:33+0000', cmd : u'org.apache.cloudstack.api.command.admin.domain.DeleteDomainCmd', userid : u'7ff2d4e4-199b-11e6-bc3d-42010a80001f', jobstatus : 2, jobid : u'f9286556-a479-47e2-847c-5ab9b384af6a', jobresultcode : 530, jobresulttype : u'object', jobresult : {errorcode : 530, errortext : u'Failed to clean up domain resources and sub domains, delete failed on domain D2-ZIJ741 (id: 15).'}, accountid : u'7ff2b764-199b-11e6-bc3d-42010a80001f'}
```
I don't think it is related to this since it is only a UI change, but I am not sure what to do about this... Do I just make a judgement call and force merge some of these?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-219203017
@swill done, closed and reopened to kick CIs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...
Posted by GabrielBrascher <gi...@git.apache.org>.
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-219430432
The idea and screenshot seem nice, the code is ok. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...
Posted by rhtyd <gi...@git.apache.org>.
GitHub user rhtyd reopened a pull request:
https://github.com/apache/cloudstack/pull/1540
CLOUDSTACK-9377: Fix metrics pagesize issue
Fixes listing of clusters and host to list all clusters/hosts by passing
pagesize=-1.
/cc @koushik-das @swill @DaanHoogland -- fixes the issue raised on dev@ ML by Rashmi
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack metrics-pagesize-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1540.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1540
----
commit da36ffe1e7e43e74ed167e64bbe41d5b0913b4f5
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2016-05-12T12:44:06Z
CLOUDSTACK-9377: Fix metrics pagesize issue
Fixes listing of clusters and host to list all clusters/hosts by passing
pagesize=-1.
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-219474182
@swill I looked at recent Jenkins errors and they seem to be environment related:
1. Jenkins failed during initialization to checkout the git tag/sha, it fails to do a clean up. I would do a git clean -fdx && git checkout -- . && git fetch origin; before checking out target branch and applying the PR. I don't know who has access to the Jenkins job and can fix it.
2. There seem be a recurring NPE issue with corbertura maven plugin, I don't know how to fix it. We can perhaps try to update the version to latest (this probably is a Jenkins plugin, so INFRA needs to fix it).
```
Exception in thread "main" java.lang.NullPointerException
at net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler.saveCoverageData(CoverageDataFileHandler.java:138)
at net.sourceforge.cobertura.coveragedata.CoverageDataFileHandler.saveCoverageData(CoverageDataFileHandler.java:115)
at net.sourceforge.cobertura.instrument.Main.parseArguments(Main.java:404)
at net.sourceforge.cobertura.instrument.Main.main(Main.java:421)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-218867747
Can we get screenshots or something to verify this works? Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---