You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by janl <gi...@git.apache.org> on 2015/12/12 17:02:52 UTC
[GitHub] couchdb pull request: COUCHDB-2876 js tests merged
GitHub user janl opened a pull request:
https://github.com/apache/couchdb/pull/377
COUCHDB-2876 js tests merged
All work on the JS test suite is ready to go into master now.
Not all tests pass, and not all are run, but we should get this into mainline now.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/couchdb 2876-js-tests-merged
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/377.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #377
----
commit e1683e010f97370dc67b43ee5756f94e12360996
Author: Jan Lehnardt <ja...@apache.org>
Date: 2015-06-25T20:25:40Z
correctly copy test utility files
commit bbbd649677fe83db04101220d7c67ee12835b86c
Author: Jan Lehnardt <ja...@apache.org>
Date: 2015-06-25T20:29:23Z
test/javascript/run: allow configuration of target URL with couchdb.uri file
commit 9543d8267eaded5ab908da60a8e89280e2685c46
Author: Jan Lehnardt <ja...@apache.org>
Date: 2015-06-25T20:32:02Z
js tests: make all_docs.js cluster-capable
commit 8fc4eccea53bc55c98a74ec9f4bcec1d98e8bedf
Author: Jan Lehnardt <ja...@apache.org>
Date: 2015-06-26T22:07:57Z
wip
commit b2bb3b8038fcfbafe1b47d0168191ff1a526649b
Author: Jan Lehnardt <ja...@apache.org>
Date: 2015-10-07T12:34:58Z
make request commits global
commit aa1731d944d40cc10881798758ca404abd67ccc5
Author: Jan Lehnardt <ja...@apache.org>
Date: 2015-10-07T13:04:16Z
wip-continued: port tests to random databases
commit 50721d84f43ca203bbaf3b6f823f8b51a7107811
Author: Jan Lehnardt <ja...@apache.org>
Date: 2015-10-09T22:51:30Z
more wip work to get js tests passing on the cluster, see inside for details
- tests that are broken now print one of three things:
- TODO: means the cause of breakage is still to be determiend
- TODO <text>: the cause of breakage is known
- Error <text>: the cause of breakate is known
- `Error: _config not available on cluster`, which unfortunately
are a lot, because run_on_modified_server uses it
Assorted issues found:
- _all_docs update_seq :true option missing (needs fix)
- invalid_docid error messages changed from `bad_request` to `illegal_docid` (fixed, must be noted in BREAKING CHANGES)
- OPTIONS for list view not allowed (needs fix)
- _purge: this feature is not yet implemented (needs impl)
- all_or_nothing is gone! (fixed, needs to be noted in BREAKING CHANGES)
commit e534fde5b4508ba223d2ef813c22273b469e0e5d
Author: sebastianro <se...@apache.org>
Date: 2015-10-11T16:13:04Z
All_docs and attachment tests updated
commit f22174a8f0c04de51683ce29da459630c0a1970c
Author: sebastianro <se...@apache.org>
Date: 2015-10-17T12:48:10Z
Basics test
commit b6b18e4313e8c10e133697319c0b3442ba48839e
Author: sebastianro <se...@apache.org>
Date: 2015-10-17T12:54:51Z
Bulk docs test
commit 497dde0cb7039ac0d8a269c0c24b7a6ba7569b3e
Author: sebastianro <se...@apache.org>
Date: 2015-10-17T14:33:57Z
Changes test
commit 40126902cd2236f85203b3f2432619eed2da38c5
Author: sebastianro <se...@apache.org>
Date: 2015-10-17T15:36:13Z
Conflict and design doc tests
commit 0431c5c1bd9d21ac3cd92bd9a8e681c86e91bcd3
Author: sebastianro <se...@apache.org>
Date: 2015-10-17T15:44:28Z
HTTP test
commit 624c60d77ec13e8432d1f3254876e79836f2aba7
Author: sebastianro <se...@apache.org>
Date: 2015-11-02T17:40:08Z
since is opaque, not a string
commit a4801b43109d01bd21ccac5a06d19b2e24ba9832
Author: sebastianro <se...@apache.org>
Date: 2015-11-02T18:19:20Z
Better hint for etags
commit b5f3c17b41bb7c14434d382b56d25d649ae10d01
Author: sebastianro <se...@apache.org>
Date: 2015-11-02T20:42:54Z
Work through list_views and also give better hints
commit 1250e2aa3af4bac111e44931cbd1484e9f1bbcab
Author: sebastianro <se...@apache.org>
Date: 2015-11-02T21:25:50Z
Comments and poss. 4 auth tests
commit 9cf1cb8ede73f4507bccef28f144e8109f7ab9cb
Author: Tony Sun <to...@cloudant.com>
Date: 2015-11-11T22:38:24Z
Add keys to options for query
The keys option was being added to design doc body. This meant we
could not append the keys= option to the view query.
commit 35af1eab1172662c9637d2810d64d50746b97dc5
Author: sebastianro <se...@apache.org>
Date: 2015-11-05T22:04:42Z
Initial solutions for cluster testing
commit f888c01df1bc45ad94053a73d72cbece4560b859
Author: sebastianro <se...@apache.org>
Date: 2015-11-10T19:56:02Z
Solve the issue of DB not found - point out fix
commit 2e011d4eb3fa9d9661555c7ec6c2c23a6168defa
Author: sebastianro <se...@apache.org>
Date: 2015-11-10T20:15:54Z
replication.js 1st part
commit 5a2e9bc61365d9e2583d4b4eef4bebe45f171756
Author: sebastianro <se...@apache.org>
Date: 2015-11-10T20:59:30Z
since in replication
commit 29cb25f1029902459e557a88d7a0d0e1d06601f9
Author: sebastianro <se...@apache.org>
Date: 2015-11-11T20:45:30Z
Replication core test
commit 3346282fa1273ad29de286b757106ad30c76180c
Author: sebastianro <se...@apache.org>
Date: 2015-11-11T21:36:23Z
draft compression config
commit 3a9a3e6c4eed5b4e45b3f5323f6ada80ab0f1521
Author: sebastianro <se...@apache.org>
Date: 2015-11-12T19:42:41Z
Attachments working and only security left
commit eac2dc2d37fc3ccd6c6fa00520ef290cf1b1aeed
Author: sebastianro <se...@apache.org>
Date: 2015-11-12T20:35:26Z
Completed replication.js test
commit 8d22b95a12d5229a831c1d6a51c5c8b4fa122ef5
Author: sebastianro <se...@apache.org>
Date: 2015-11-17T20:39:09Z
Re-add _security checking after fix
commit 330c5b065ff27cb802b04ef5b48a8f299b8e71b4
Author: sebastianro <se...@apache.org>
Date: 2015-11-17T21:48:01Z
One more replicator DB test
commit d4850e28b4f29fd2a4899fd4b338de6b254a4ea5
Author: Jan Lehnardt <ja...@apache.org>
Date: 2015-12-12T11:41:16Z
fix attachments.js, was reading test data from wrong port
commit f67101a1a00fc88ea8a98775c3221cee6b055f6a
Author: Jan Lehnardt <ja...@apache.org>
Date: 2015-12-12T12:28:40Z
fix view_errors.js test, skip temp views
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-2876 js tests merged
Posted by janl <gi...@git.apache.org>.
Github user janl commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/377#discussion_r47433411
--- Diff: Makefile ---
@@ -102,8 +102,17 @@ eunit: couch
.PHONY: javascript
# target: javascript - Run JavaScript test suites or specific ones defined by suites option
-javascript: all share/www/script/test
- @dev/run -q --with-admin-party-please test/javascript/run $(suites)
+javascript: all
+ @mkdir -p share/www/script/test
+ifeq ($(IN_RELEASE), true)
+ @cp test/javascript/tests/lorem*.txt share/www/test/
+else
+ @mkdir -p src/fauxton/dist/release/test
+ @cp test/javascript/tests/lorem*.txt src/fauxton/dist/release/test/
+endif
+ @ulimit -n 10240
--- End diff --
the ulimit? why doesn’t that work on FreeBSD? Different modifier?
The reason is that we are now using random db names and during the course of the test runs we open many hundreds of fds and things fail with emfile when this isn’t in here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-2876 js tests merged
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/377#discussion_r47433338
--- Diff: Makefile ---
@@ -102,8 +102,17 @@ eunit: couch
.PHONY: javascript
# target: javascript - Run JavaScript test suites or specific ones defined by suites option
-javascript: all share/www/script/test
- @dev/run -q --with-admin-party-please test/javascript/run $(suites)
+javascript: all
+ @mkdir -p share/www/script/test
+ifeq ($(IN_RELEASE), true)
+ @cp test/javascript/tests/lorem*.txt share/www/test/
+else
+ @mkdir -p src/fauxton/dist/release/test
+ @cp test/javascript/tests/lorem*.txt src/fauxton/dist/release/test/
+endif
+ @ulimit -n 10240
--- End diff --
Why this is needed? Except you want to make `make javascript` not work on..say...FreeBSD (:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-2876 js tests merged
Posted by janl <gi...@git.apache.org>.
Github user janl commented on the pull request:
https://github.com/apache/couchdb/pull/377#issuecomment-165227757
Clean rebase here: https://github.com/apache/couchdb/pull/378
Closing this. Thanks all! <3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-2876 js tests merged
Posted by janl <gi...@git.apache.org>.
Github user janl commented on the pull request:
https://github.com/apache/couchdb/pull/377#issuecomment-164164782
> Need to not forget cleanup history and some bits before merge.
yeah, but how? :/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-2876 js tests merged
Posted by janl <gi...@git.apache.org>.
Github user janl closed the pull request at:
https://github.com/apache/couchdb/pull/377
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-2876 js tests merged
Posted by janl <gi...@git.apache.org>.
Github user janl commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/377#discussion_r47433610
--- Diff: rel/overlay/etc/default.ini ---
@@ -299,6 +299,9 @@ verify_ssl_certificates = false
;ssl_trusted_certificates_file = /etc/ssl/certs/ca-certificates.crt
; Maximum peer certificate depth (must be set even if certificate validation is off).
ssl_certificate_max_depth = 3
+; improve testing
+start_delay=0
--- End diff --
They are all backed out at this point anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-2876 js tests merged
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/377#discussion_r47433319
--- Diff: Makefile ---
@@ -102,8 +102,17 @@ eunit: couch
.PHONY: javascript
# target: javascript - Run JavaScript test suites or specific ones defined by suites option
-javascript: all share/www/script/test
--- End diff --
Ok, no problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-2876 js tests merged
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/377#discussion_r47433381
--- Diff: rel/overlay/etc/default.ini ---
@@ -299,6 +299,9 @@ verify_ssl_certificates = false
;ssl_trusted_certificates_file = /etc/ssl/certs/ca-certificates.crt
; Maximum peer certificate depth (must be set even if certificate validation is off).
ssl_certificate_max_depth = 3
+; improve testing
+start_delay=0
--- End diff --
That shouldn't be here since it harms general logic and actually is a hack to not sleep in tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-2876 js tests merged
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/377#discussion_r47433514
--- Diff: rel/overlay/etc/default.ini ---
@@ -299,6 +299,9 @@ verify_ssl_certificates = false
;ssl_trusted_certificates_file = /etc/ssl/certs/ca-certificates.crt
; Maximum peer certificate depth (must be set even if certificate validation is off).
ssl_certificate_max_depth = 3
+; improve testing
+start_delay=0
--- End diff --
That not an issue, but iirc that will broke some replicator tests (:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-2876 js tests merged
Posted by janl <gi...@git.apache.org>.
Github user janl commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/377#discussion_r47433245
--- Diff: Makefile ---
@@ -102,8 +102,17 @@ eunit: couch
.PHONY: javascript
# target: javascript - Run JavaScript test suites or specific ones defined by suites option
-javascript: all share/www/script/test
--- End diff --
@kxepal sorry I had to undo your cleanup here, because we are depending on different dirs, depending on whether we run the JS tests from the source tree or a release tarball. I don’t know how to better formulate this in make.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-2876 js tests merged
Posted by janl <gi...@git.apache.org>.
Github user janl commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/377#discussion_r47433419
--- Diff: rel/overlay/etc/default.ini ---
@@ -299,6 +299,9 @@ verify_ssl_certificates = false
;ssl_trusted_certificates_file = /etc/ssl/certs/ca-certificates.crt
; Maximum peer certificate depth (must be set even if certificate validation is off).
ssl_certificate_max_depth = 3
+; improve testing
+start_delay=0
--- End diff --
can you back it out and push to the branch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-2876 js tests merged
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/377#discussion_r47433508
--- Diff: Makefile ---
@@ -102,8 +102,17 @@ eunit: couch
.PHONY: javascript
# target: javascript - Run JavaScript test suites or specific ones defined by suites option
-javascript: all share/www/script/test
- @dev/run -q --with-admin-party-please test/javascript/run $(suites)
+javascript: all
+ @mkdir -p share/www/script/test
+ifeq ($(IN_RELEASE), true)
+ @cp test/javascript/tests/lorem*.txt share/www/test/
+else
+ @mkdir -p src/fauxton/dist/release/test
+ @cp test/javascript/tests/lorem*.txt src/fauxton/dist/release/test/
+endif
+ @ulimit -n 10240
--- End diff --
```
[couchdb@freebsd ~]$ ulimit -n 1024
-bash: ulimit: open files: cannot modify limit: Operation not permitted
```
That's strange that we can hit emfile here, while with the same strategy for eunit tests we don't. Do we cleanup databases after the tests? Or we just have fd leak? That's important.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-2876 js tests merged
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/377#issuecomment-164164476
Need to not forget cleanup history and some bits before merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: COUCHDB-2876 js tests merged
Posted by janl <gi...@git.apache.org>.
Github user janl commented on a diff in the pull request:
https://github.com/apache/couchdb/pull/377#discussion_r47433601
--- Diff: Makefile ---
@@ -102,8 +102,17 @@ eunit: couch
.PHONY: javascript
# target: javascript - Run JavaScript test suites or specific ones defined by suites option
-javascript: all share/www/script/test
- @dev/run -q --with-admin-party-please test/javascript/run $(suites)
+javascript: all
+ @mkdir -p share/www/script/test
+ifeq ($(IN_RELEASE), true)
+ @cp test/javascript/tests/lorem*.txt share/www/test/
+else
+ @mkdir -p src/fauxton/dist/release/test
+ @cp test/javascript/tests/lorem*.txt src/fauxton/dist/release/test/
+endif
+ @ulimit -n 10240
--- End diff --
I made it so we close dbs in all tests, but I didn't investigate further, the tests are a pretty big thing to handle on their own.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---