You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2022/08/01 06:45:01 UTC
[GitHub] [tomcat-jakartaee-migration] aooohan opened a new pull request, #30: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry
aooohan opened a new pull request, #30:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/30
See #29
The problem is that common-compression has CRC checks when the closeArchiveEntry method is executed, when the method of the Entry is not DEFLATED and the SeekableByteChannel is not used.
However, because we have some information modification at the time of Converter, the CRC value calculated after the modification must not be equal to the value of the CRC in the original Entry.
The original Entry information is retained.
https://github.com/apache/tomcat-jakartaee-migration/blob/34d7c72aa0eea3d403b287b10e92cdcead0676c7/src/main/java/org/apache/tomcat/jakartaee/Migration.java#L319-L329
There is another way to recalculate the CRC, but I don't feel it makes much sense and there is a performance overhead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] aooohan commented on pull request #30: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry
Posted by GitBox <gi...@apache.org>.
aooohan commented on PR #30:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/30#issuecomment-1228271046
Merge manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] aooohan closed pull request #30: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry
Posted by GitBox <gi...@apache.org>.
aooohan closed pull request #30: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] aooohan commented on pull request #30: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry
Posted by GitBox <gi...@apache.org>.
aooohan commented on PR #30:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/30#issuecomment-1227979940
If there are no objections to this sloution, I will merge it today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] aooohan commented on pull request #30: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry
Posted by GitBox <gi...@apache.org>.
aooohan commented on PR #30:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/30#issuecomment-1208932186
> If I am reading this correctly, a side-effect of this change is that entries that were previously `STORED` will now be `DEFLATED`.
Yes, I now don't think that's very elegant, so I tried another way to handle the case where the archive entries is `STORED`. Although there is some performance loss in doing this, it will only affect archive entries that are `STORED`, but it is still faster than processing in memory.
@markt-asf Please review the new changes, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] markt-asf commented on pull request #30: Exception in thread "main" java.util.zip.ZipException: Bad CRC checksum for entry
Posted by GitBox <gi...@apache.org>.
markt-asf commented on PR #30:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/30#issuecomment-1208293255
If I am reading this correctly, a side-effect of this change is that entries that were previously `STORED` will now be `DEFLATED`.
The only use case I am aware of that requires archive entries to be `STORED` is Spring Boot's fat jar (for performance reasons) and I can't think of any reason why such a JAR would need to be converted.
Therefore, unless there are other objections, I intend to merge this PR in the next day or so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org