You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2025/10/16 16:05:41 UTC

[I] Replace connexion with fast-api for FAB provider. [airflow]

potiuk opened a new issue, #56730:
URL: https://github.com/apache/airflow/issues/56730

   ### Body
   
   We should follow the suite and replace connexion usage (still) in FAB provider 3 with the pure FastAPI approach so that we can get rid of connexion and related unnecessary dependencies.
   
   ### Committer
   
   - [x] I acknowledge that I am a maintainer/committer of the Apache Airflow project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Replace connexion with fast-api for FAB provider. [airflow]

Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on issue #56730:
URL: https://github.com/apache/airflow/issues/56730#issuecomment-4185052573

   @potiuk looks like all tasks are completed. Can you confirm?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Replace connexion with fast-api for FAB provider. [airflow]

Posted by "meher1993 (via GitHub)" <gi...@apache.org>.
meher1993 commented on issue #56730:
URL: https://github.com/apache/airflow/issues/56730#issuecomment-3427366422

   > BTW, If any of you want to help - the task is up for grabs. The sooner **someone** will do it, the sooner the version that supports 3.13 will be released [@meher1993](https://github.com/meher1993) [@danielshulansky](https://github.com/danielshulansky)
   
   I can try and attempt at it @potiuk . Mind sharing the specific issue opened?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Replace connexion with fast-api for FAB provider. [airflow]

Posted by "Dev-iL (via GitHub)" <gi...@apache.org>.
Dev-iL commented on issue #56730:
URL: https://github.com/apache/airflow/issues/56730#issuecomment-3754011595

   @ddovbii Consider creating a PR that removes "connexion and related unnecessary dependencies" -> if CI allows that, _then_ I'd say we're done here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Replace connexion with fast-api for FAB provider. [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #56730:
URL: https://github.com/apache/airflow/issues/56730#issuecomment-3427789266

   > Mind sharing the specific issue opened?
   
   That's basically the issue :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Replace connexion with fast-api for FAB provider. [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #56730:
URL: https://github.com/apache/airflow/issues/56730#issuecomment-3413665600

   Feel free to attempt it - if you have any issues or need help #fab-ulgrade in slack is a good place to discuss it ! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Replace connexion with fast-api for FAB provider. [airflow]

Posted by "meher1993 (via GitHub)" <gi...@apache.org>.
meher1993 commented on issue #56730:
URL: https://github.com/apache/airflow/issues/56730#issuecomment-3426933480

   > is it related to fab provider being not compatible with python3.13?
   
   I would say this is directly related to this [comment](https://github.com/apache/airflow/pull/51681#issuecomment-3410852400) and the discussion in general around connexion for AF3. @potiuk can confirm
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Replace connexion with fast-api for FAB provider. [airflow]

Posted by "kyounghunJang (via GitHub)" <gi...@apache.org>.
kyounghunJang commented on issue #56730:
URL: https://github.com/apache/airflow/issues/56730#issuecomment-3413494872

   @potiuk 
   Hi, could you please assign this issue to me?
   
   Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Replace connexion with fast-api for FAB provider. [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #56730:
URL: https://github.com/apache/airflow/issues/56730#issuecomment-4187668057

   Not sure if you noticed but the task is completed 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Replace connexion with fast-api for FAB provider. [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #56730:
URL: https://github.com/apache/airflow/issues/56730#issuecomment-3785395819

   > Looking at providers/fab/src/airflow/providers/fab/auth_manager/api_endpoints/user_endpoint.py, it appears that /users has more methods than just POST (i.e. GET, PUT, DELETE).
   
   Yep. There are still some connexion references. 
   
   > @potiuk the issue could be closed? when the new version of fab provider will br relased? thanks!
   
   I guess when someone takes one the task to remove those remaining usages. Doing it will speed it up (just saying).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Replace connexion with fast-api for FAB provider. [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #56730:
URL: https://github.com/apache/airflow/issues/56730#issuecomment-3477891680

   Looks like there are open PRs (see above)
   
   <img width="610" height="87" alt="Image" src="https://github.com/user-attachments/assets/fafcac87-b408-4e68-a46e-87ba845049d4" />
   
   So likely commenting and reviewing those is a good way forward.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Replace connexion with fast-api for FAB provider. [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #56730:
URL: https://github.com/apache/airflow/issues/56730#issuecomment-3986432815

   @kyounghunJang We are unassigning you from this issue as part of our updated [assignment policy](https://github.com/apache/airflow/blob/main/contributing-docs/04_how_to_contribute.rst#contribute-code-changes).
   
   This is not meant to discourage your contribution — quite the opposite! You are still very welcome to work on this issue and submit a PR for it. Simply comment that you are working on it and open a PR when ready.
   
   We found that formal assignments were not working well, as they often prevented others from contributing when the assignee was not actively working on the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Replace connexion with fast-api for FAB provider. [airflow]

Posted by "kyounghunJang (via GitHub)" <gi...@apache.org>.
kyounghunJang commented on issue #56730:
URL: https://github.com/apache/airflow/issues/56730#issuecomment-3418691731

   @potiuk 
   As I understand this issue, it involves converting all Flask-related functionality in the FAB provider to FastAPI. After analyzing the codebase, I found that this would require modifying a fairly large number of files. Is my understanding correct, or should we narrow the scope and only convert a specific subset? Either way, I’ll proceed step by step.
   
   Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Replace connexion with fast-api for FAB provider. [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #56730:
URL: https://github.com/apache/airflow/issues/56730#issuecomment-3427128333

   BTW, If any of you want to help - the task is up for grabs. The sooner **someone** will do it, the sooner the version that supports 3.13 will be released @meher1993 @danielshulansky 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Replace connexion with fast-api for FAB provider. [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #56730:
URL: https://github.com/apache/airflow/issues/56730#issuecomment-3427124772

   Yes. it's also connected to that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Replace connexion with fast-api for FAB provider. [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #56730:
URL: https://github.com/apache/airflow/issues/56730#issuecomment-3418719670

   > As I understand this issue, it involves converting all Flask-related functionality in the FAB provider 
   
   No - not all. Flask Application Builder **by definition** uses Flask - so all things related to Flask should not be touched. What **really** needs to be removed is `connexion` usage. Connexion is used to expose the API calls that have nothing to do with Flask, really (or so it seems) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Replace connexion with fast-api for FAB provider. [airflow]

Posted by "danielshulansky (via GitHub)" <gi...@apache.org>.
danielshulansky commented on issue #56730:
URL: https://github.com/apache/airflow/issues/56730#issuecomment-3426889489

   is it related to fab provider being not compatible with python3.13?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Replace connexion with fast-api for FAB provider. [airflow]

Posted by "kyounghunJang (via GitHub)" <gi...@apache.org>.
kyounghunJang commented on issue #56730:
URL: https://github.com/apache/airflow/issues/56730#issuecomment-3466398083

   @potiuk @chiuinggum 
   Hi! I’ve been working on the implementation for the user, role, and permission GET, POST, DELETE, and PATCH endpoints, as well as writing the corresponding test cases.
   I noticed that you’ve submitted a PR covering some of these parts.
   I just wanted to check — should I open a PR for the remaining parts I’ve implemented, or are you still working on additional parts?
   Thank you!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Replace connexion with fast-api for FAB provider. [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #56730:
URL: https://github.com/apache/airflow/issues/56730#issuecomment-3785448653

   I created sub-issues with remaining tasks and marked them as "good first issue" - they are up for grabs for anyone.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Replace connexion with fast-api for FAB provider. [airflow]

Posted by "ddovbii (via GitHub)" <gi...@apache.org>.
ddovbii commented on issue #56730:
URL: https://github.com/apache/airflow/issues/56730#issuecomment-3753166740

   hey! I see @henry3260 has just completed the [last PR](https://github.com/apache/airflow/pull/60523) required for completing this. 
   @potiuk the issue could be closed? when the new version of fab provider will br relased? thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Replace connexion with fast-api for FAB provider. [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed issue #56730: Replace connexion with fast-api for FAB provider.
URL: https://github.com/apache/airflow/issues/56730


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Replace connexion with fast-api for FAB provider. [airflow]

Posted by "harishkernel (via GitHub)" <gi...@apache.org>.
harishkernel commented on issue #56730:
URL: https://github.com/apache/airflow/issues/56730#issuecomment-4186328891

   Hi there, I’m planning to work on this. Is anyone already working on it / is there an in-progress PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org