You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/20 18:22:45 UTC

[GitHub] [incubator-dolphinscheduler] nauu opened a new pull request #1534: Add SparkArgsUtilsTest which is the UT of SparkArgsUtils

nauu opened a new pull request #1534: Add SparkArgsUtilsTest which is the UT of SparkArgsUtils
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1534
 
 
   ## What is the purpose of the pull request
   
   For #1465.
   
   1.Add SparkArgsUtilsTest
   2.Optimize SparkArgsUtils
   3.Add the UT path in pom
   
   ## Brief change log
   
     - *Add SparkArgsUtilsTest.java*
     - *Edit SparkArgsUtils.java*
     - *Add UT path to root pom.xml*
   
   ## Verify this pull request
   
   This change added tests and can be verified as follows:
   
     - *Added SparkArgsUtilsTest to verify the change.*
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] lgcareer merged pull request #1534: Add SparkArgsUtilsTest which is the UT of SparkArgsUtils

Posted by GitBox <gi...@apache.org>.
lgcareer merged pull request #1534: Add SparkArgsUtilsTest which is the UT of SparkArgsUtils
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1534
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1534: Add SparkArgsUtilsTest which is the UT of SparkArgsUtils

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1534: Add SparkArgsUtilsTest which is the UT of SparkArgsUtils
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1534#issuecomment-568036435
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1534?src=pr&el=h1) Report
   > Merging [#1534](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1534?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/99fc87f9116f871fa89d985731fb579f0f41aa17?src=pr&el=desc) will **increase** coverage by `0.35%`.
   > The diff coverage is `91.42%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1534/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1534?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff            @@
   ##             dev   #1534      +/-   ##
   ========================================
   + Coverage    7.4%   7.75%   +0.35%     
   ========================================
     Files        272     272              
     Lines      13643   13650       +7     
     Branches    2170    2167       -3     
   ========================================
   + Hits        1010    1059      +49     
   + Misses     12566   12520      -46     
   - Partials      67      71       +4
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1534?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../dolphinscheduler/server/utils/SparkArgsUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1534/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1NwYXJrQXJnc1V0aWxzLmphdmE=) | `92.15% <91.42%> (+92.15%)` | :arrow_up: |
   | [...ache/dolphinscheduler/common/enums/ZKNodeType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1534/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1pLTm9kZVR5cGUuamF2YQ==) | `100% <0%> (+100%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1534?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1534?src=pr&el=footer). Last update [99fc87f...291dfe7](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1534?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services