You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by ghxiao <gi...@git.apache.org> on 2017/01/25 18:01:27 UTC
[GitHub] commons-rdf pull request #31: COMMONSRDF-54: overloads of RDF4J#asRDFTerm
GitHub user ghxiao opened a pull request:
https://github.com/apache/commons-rdf/pull/31
COMMONSRDF-54: overloads of RDF4J#asRDFTerm
Resolves: COMMONSRDF-54
This PR adds three overloaded methods into the class RDF4J:
RDF4JBlankNode asRDFTerm(final org.eclipse.rdf4j.model.BNode value)
RDF4JLiteral asRDFTerm(final org.eclipse.rdf4j.model.Literal value)
RDF4JIRI asRDFTerm(final org.eclipse.rdf4j.model.IRI value)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ghxiao/commons-rdf COMMONSRDF-54
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-rdf/pull/31.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #31
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-rdf issue #31: COMMONSRDF-54: overloads of RDF4J#asRDFTerm
Posted by stain <gi...@git.apache.org>.
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/31
Thanks, this looks sensible to me!
Should we add unit test for each of the new `asRDFTerm` methods? They are in a way already tested through `createLiteral` etc.., but just so we don't break it later?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-rdf pull request #31: COMMONSRDF-54: overloads of RDF4J#asRDFTerm
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-rdf/pull/31
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-rdf issue #31: COMMONSRDF-54: overloads of RDF4J#asRDFTerm
Posted by ghxiao <gi...@git.apache.org>.
Github user ghxiao commented on the issue:
https://github.com/apache/commons-rdf/pull/31
I added a test case`RDF4JMethodOverloadsTest` and one more method in RDF4J
`public RDF4JBlankNodeOrIRI asRDFTerm(final org.eclipse.rdf4j.model.Resource value)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org