You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/02 16:11:52 UTC

[GitHub] [flink] tillrohrmann commented on a change in pull request #13375: [FLINK-18815][filesystems][tests] Join SafetyNetCloseableRegistry's reaper thread before assertion

tillrohrmann commented on a change in pull request #13375:
URL: https://github.com/apache/flink/pull/13375#discussion_r498916657



##########
File path: flink-core/src/main/java/org/apache/flink/core/fs/SafetyNetCloseableRegistry.java
##########
@@ -134,10 +135,17 @@ public void close() throws IOException {
 				--GLOBAL_SAFETY_NET_REGISTRY_COUNT;
 				if (0 == GLOBAL_SAFETY_NET_REGISTRY_COUNT) {
 					REAPER_THREAD.interrupt();

Review comment:
       Alright. It would also be out of the scope of this PR to change it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org