You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ephraimbuddy (via GitHub)" <gi...@apache.org> on 2024/05/15 10:08:08 UTC
[PR] Add `breeze generate-migration-file` command [airflow]
ephraimbuddy opened a new pull request, #39632:
URL: https://github.com/apache/airflow/pull/39632
This helps to generate alembic migration file for ORM changes.
Closes: #39576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add `breeze generate-migration-file` command [airflow]
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on PR #39632:
URL: https://github.com/apache/airflow/pull/39632#issuecomment-2112296774
> <img alt="Screenshot 2024-05-15 at 07 12 45" width="1608" src="https://private-user-images.githubusercontent.com/595491/330780266-70ff18ed-9157-458a-b423-6ae8732158d4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTU3NzE4OTksIm5iZiI6MTcxNTc3MTU5OSwicGF0aCI6Ii81OTU0OTEvMzMwNzgwMjY2LTcwZmYxOGVkLTkxNTctNDU4YS1iNDIzLTZhZTg3MzIxNThkNC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNTE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDUxNVQxMTEzMTlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04ZDMzYzhiOTZjNTdlMzZmMDhiMWIyYWY1NjJlMTk4NTEzYTliZDZkYzEwNTE5ZWJjYzZmZmI5YjY1ZDNiY2FlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.E5clN1Zvq4WgZmkMtFV5bN_z7JPY0liRRwVsxTrm6-k">
Other commands like `build-docs` did not create a new file like it's suggesting I create: `dev/breeze/src/airflow_breeze/commands/generate_migration_file_commands_config.py`. I thought having it in `dev/breeze/src/airflow_breeze/commands/developer_commands_config.py` is enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add `breeze generate-migration-file` command [airflow]
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on PR #39632:
URL: https://github.com/apache/airflow/pull/39632#issuecomment-2112229716
Hi @potiuk , I'm not sure what this failure means: https://github.com/apache/airflow/actions/runs/9093832549/job/24993789868?pr=39632#step:8:416.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add `breeze generate-migration-file` command [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #39632:
URL: https://github.com/apache/airflow/pull/39632#issuecomment-2112310696
> Other commands like `build-docs` did not create a new file like it's suggesting I create: `dev/breeze/src/airflow_breeze/commands/generate_migration_file_commands_config.py`. I thought having it in `dev/breeze/src/airflow_breeze/commands/developer_commands_config.py` is enough
Yeah that message is not 100% correct in all cases - release_commands for example are also in a different place. It might need some improvement. But generally it's about making sure there is a group defined and used in breeze so that the `--message` in help does not land in `Common options` group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add `breeze generate-migration-file` command [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #39632:
URL: https://github.com/apache/airflow/pull/39632#issuecomment-2112239375
<img width="1608" alt="Screenshot 2024-05-15 at 07 12 45" src="https://github.com/apache/airflow/assets/595491/70ff18ed-9157-458a-b423-6ae8732158d4">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add `breeze generate-migration-file` command [airflow]
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on PR #39632:
URL: https://github.com/apache/airflow/pull/39632#issuecomment-2112475722
> > Other commands like `build-docs` did not create a new file like it's suggesting I create: `dev/breeze/src/airflow_breeze/commands/generate_migration_file_commands_config.py`. I thought having it in `dev/breeze/src/airflow_breeze/commands/developer_commands_config.py` is enough
>
> Yeah that message is not 100% correct in all cases - release_commands for example are also in a different place. It might need some improvement. But generally it's about making sure there is a group defined and used in breeze so that the `--message` in help does not land in `Common options` group.
Solved it by adding it to the developer_command in dev/breeze/src/airflow_breeze/commands/setup_commands.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add `breeze generate-migration-file` command [airflow]
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy merged PR #39632:
URL: https://github.com/apache/airflow/pull/39632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org