[GitHub] [flink] renxiaoyao opened a new pull request, #22433: [FLINK-31863]kubernetes] Add Hostname enum val to kubernetes NodeAddress type

["renxiaoyao (via GitHub)" <gi...@apache.org>]

renxiaoyao opened a new pull request, #22433:
URL: https://github.com/apache/flink/pull/22433

   ## What is the purpose of the change
   
   * Add Hostname enum val to kubernetes NodeAddress type.* Class io.fabric8.kubernetes.api.model.NodeAddress.type contains 'InternalIP','ExternalIP' and 'Hostname'. The InternalIP address is unavailable in the private cloud environment. But the hostname can be resolved by the DNS server. So 'org.apache.flink.kubernetes.configuration.NodePortAddressType.NodePortAddressType' should add 'Hostname' enumeration value.
   
   
   ## Brief change log
   
   ```
       public enum NodePortAddressType {
           InternalIP,
           ExternalIP,
       }
   ```
   Upgrade to:
   ```
       public enum NodePortAddressType {
           InternalIP,
           ExternalIP,
           Hostname
       }
   ```
   
   
   ## Verifying this change
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`:  no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #22433: [FLINK-31863]kubernetes] Add Hostname enum val to kubernetes NodeAddress type

["flinkbot (via GitHub)" <gi...@apache.org>]

flinkbot commented on PR #22433:
URL: https://github.com/apache/flink/pull/22433#issuecomment-1516138350

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5043182803d92eeae60a6cbc2584f455122541ee",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5043182803d92eeae60a6cbc2584f455122541ee",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5043182803d92eeae60a6cbc2584f455122541ee UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org