You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Jukka Zitting (JIRA)" <ji...@apache.org> on 2007/10/20 23:25:50 UTC
[jira] Created: (JCR-1181) Use common base classes in
jackrabbit-core and jcr2spi
Use common base classes in jackrabbit-core and jcr2spi
------------------------------------------------------
Key: JCR-1181
URL: https://issues.apache.org/jira/browse/JCR-1181
Project: Jackrabbit
Issue Type: Improvement
Components: jackrabbit-core, SPI
Reporter: Jukka Zitting
Assignee: Jukka Zitting
Priority: Minor
Attachments: JCR-1181.patch
As part of JCR-742 I've implemented a number of generic JCR base classes and adapters in org.apache.jackrabbit.commons. These classes are based on existing code in jackrabbit-core.
To encourage code reuse across jackrabbit-core and jcr2spi, I'd like to make both components use these generic base classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1181) Use common base classes in
jackrabbit-core and jcr2spi
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-1181:
-------------------------------
Fix Version/s: 1.4
> Use common base classes in jackrabbit-core and jcr2spi
> ------------------------------------------------------
>
> Key: JCR-1181
> URL: https://issues.apache.org/jira/browse/JCR-1181
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core, SPI
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: 1.4
>
> Attachments: JCR-1181.patch
>
>
> As part of JCR-742 I've implemented a number of generic JCR base classes and adapters in org.apache.jackrabbit.commons. These classes are based on existing code in jackrabbit-core.
> To encourage code reuse across jackrabbit-core and jcr2spi, I'd like to make both components use these generic base classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1181) Use common base classes in
jackrabbit-core and jcr2spi
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-1181:
-------------------------------
Attachment: JCR-1181.patch
Attached a proposed patch. I'll commit the changes in a few days unless anyone objects.
> Use common base classes in jackrabbit-core and jcr2spi
> ------------------------------------------------------
>
> Key: JCR-1181
> URL: https://issues.apache.org/jira/browse/JCR-1181
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core, SPI
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Attachments: JCR-1181.patch
>
>
> As part of JCR-742 I've implemented a number of generic JCR base classes and adapters in org.apache.jackrabbit.commons. These classes are based on existing code in jackrabbit-core.
> To encourage code reuse across jackrabbit-core and jcr2spi, I'd like to make both components use these generic base classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-1181) Use common base classes in
jackrabbit-core and jcr2spi
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting resolved JCR-1181.
--------------------------------
Resolution: Fixed
Resolved in a sequence of commits (see the Subversion Commits tab).
> Use common base classes in jackrabbit-core and jcr2spi
> ------------------------------------------------------
>
> Key: JCR-1181
> URL: https://issues.apache.org/jira/browse/JCR-1181
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core, jackrabbit-jcr2spi
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: 1.4
>
> Attachments: JCR-1181.patch
>
>
> As part of JCR-742 I've implemented a number of generic JCR base classes and adapters in org.apache.jackrabbit.commons. These classes are based on existing code in jackrabbit-core.
> To encourage code reuse across jackrabbit-core and jcr2spi, I'd like to make both components use these generic base classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1181) Use common base classes in
jackrabbit-core and jcr2spi
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536698 ]
Jukka Zitting commented on JCR-1181:
------------------------------------
Angela:
> however, if you would like to make jackrabbit-core and jcr2spi use them, i would suggest to move them
> out of the jcr-commons project as well and adjust them in order to get rid of their usage of QName and
> the other deprecated classes.
The classes in org.apache.jackrabbit.commons use the (now deprecated) QName class for a few namespace constants. In fact I just dropped the dependency by copying the jcr and mix URI string constants to o.a.j.commons.AbstractNode in revision 587120.
The classes are intimately related to the JCR API boundary and they only deal with prefixed names in string format. There are no dependencies to SPI concepts. Thus I'd rather keep the classes in jcr-commons instead of spi-commons. Alternatively we could (or perhaps should!) move them over to jcr2spi, but I'm not sure if we're yet ready to introduce jcr2spi as a dependency to jackrabbit-core.
> Use common base classes in jackrabbit-core and jcr2spi
> ------------------------------------------------------
>
> Key: JCR-1181
> URL: https://issues.apache.org/jira/browse/JCR-1181
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core, SPI
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Attachments: JCR-1181.patch
>
>
> As part of JCR-742 I've implemented a number of generic JCR base classes and adapters in org.apache.jackrabbit.commons. These classes are based on existing code in jackrabbit-core.
> To encourage code reuse across jackrabbit-core and jcr2spi, I'd like to make both components use these generic base classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1181) Use common base classes in
jackrabbit-core and jcr2spi
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536676 ]
angela commented on JCR-1181:
-----------------------------
hi jukka
while working on JCR-1169 i was not sure about the status of the classes in the org.apache.jackrabbit.commons package, because they were not used anywere. therefore i decided not to touch them.
however, if you would like to make jackrabbit-core and jcr2spi use them, i would suggest to move them out of the jcr-commons project as well and adjust them in order to get rid of their usage of QName and the other deprecated classes.
what do you think?
> Use common base classes in jackrabbit-core and jcr2spi
> ------------------------------------------------------
>
> Key: JCR-1181
> URL: https://issues.apache.org/jira/browse/JCR-1181
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core, SPI
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Attachments: JCR-1181.patch
>
>
> As part of JCR-742 I've implemented a number of generic JCR base classes and adapters in org.apache.jackrabbit.commons. These classes are based on existing code in jackrabbit-core.
> To encourage code reuse across jackrabbit-core and jcr2spi, I'd like to make both components use these generic base classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1181) Use common base classes in
jackrabbit-core and jcr2spi
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela updated JCR-1181:
------------------------
Component/s: (was: jackrabbit-spi)
jackrabbit-jcr2spi
> Use common base classes in jackrabbit-core and jcr2spi
> ------------------------------------------------------
>
> Key: JCR-1181
> URL: https://issues.apache.org/jira/browse/JCR-1181
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core, jackrabbit-jcr2spi
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Fix For: 1.4
>
> Attachments: JCR-1181.patch
>
>
> As part of JCR-742 I've implemented a number of generic JCR base classes and adapters in org.apache.jackrabbit.commons. These classes are based on existing code in jackrabbit-core.
> To encourage code reuse across jackrabbit-core and jcr2spi, I'd like to make both components use these generic base classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1181) Use common base classes in
jackrabbit-core and jcr2spi
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536708 ]
angela commented on JCR-1181:
-----------------------------
> The classes in org.apache.jackrabbit.commons use the (now deprecated) QName class for a
> few namespace constants. In fact I just dropped the dependency by copying the jcr and mix URI
> string constants to o.a.j.commons.AbstractNode in revision 587120.
ok. then i'm fine :)
i just wanted to make sure, we get rid of the QName and don't introduce a dependency to
spi/spi-commons in the jcr-commons... that's all.
> Use common base classes in jackrabbit-core and jcr2spi
> ------------------------------------------------------
>
> Key: JCR-1181
> URL: https://issues.apache.org/jira/browse/JCR-1181
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core, SPI
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Priority: Minor
> Attachments: JCR-1181.patch
>
>
> As part of JCR-742 I've implemented a number of generic JCR base classes and adapters in org.apache.jackrabbit.commons. These classes are based on existing code in jackrabbit-core.
> To encourage code reuse across jackrabbit-core and jcr2spi, I'd like to make both components use these generic base classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.