You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@gmail.com> on 2023/02/28 07:12:03 UTC

Review Request 74327: RANGER-4109: Add unique constraint on resource_signature column of x_rms_service_resource table

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74327/
-----------------------------------------------------------

Review request for ranger, Abhishek  Kumar, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Nikhil P, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-4109
    https://issues.apache.org/jira/browse/RANGER-4109


Repository: ranger


Description
-------

RANGER-3067 is adding index on resource_signature column of x_rms_service_resource table but its not a unique index and may cause duplication of entries. To avoid this situation the key index should be changed to unique index.


Diffs
-----

  security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 9a79fe8ad 
  security-admin/db/mysql/patches/065-add-uk-on-x_rms_service_resource-resource_signature.sql PRE-CREATION 
  security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql fd6cec9a7 
  security-admin/db/oracle/patches/065-add-uk-on-x_rms_service_resource-resource_signature.sql PRE-CREATION 
  security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 4d5a8cedf 
  security-admin/db/postgres/patches/065-add-uk-on-x_rms_service_resource-resource_signature.sql PRE-CREATION 
  security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 3ed2a5b9c 
  security-admin/db/sqlanywhere/patches/065-add-uk-on-x_rms_service_resource-resource_signature.sql PRE-CREATION 
  security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql ca8f7da1f 
  security-admin/db/sqlserver/patches/065-add-uk-on-x_rms_service_resource-resource_signature.sql PRE-CREATION 


Diff: https://reviews.apache.org/r/74327/diff/1/


Testing
-------

Tested fresh and upgrade installation, This patch is removing the existing index and adding the unique index on resource_signature column of x_rms_service_resource table.
Tested the patch for mysql, postgres and oracle DB flavors.


Thanks,

Pradeep Agrawal


Re: Review Request 74327: RANGER-4109: Add unique constraint on resource_signature column of x_rms_service_resource table

Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74327/#review225263
-----------------------------------------------------------


Ship it!




Ship It!

- Abhay Kulkarni


On Feb. 28, 2023, 7:12 a.m., Pradeep Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74327/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2023, 7:12 a.m.)
> 
> 
> Review request for ranger, Abhishek  Kumar, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Nikhil P, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4109
>     https://issues.apache.org/jira/browse/RANGER-4109
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-3067 is adding index on resource_signature column of x_rms_service_resource table but its not a unique index and may cause duplication of entries. To avoid this situation the key index should be changed to unique index.
> 
> 
> Diffs
> -----
> 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 9a79fe8ad 
>   security-admin/db/mysql/patches/065-add-uk-on-x_rms_service_resource-resource_signature.sql PRE-CREATION 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql fd6cec9a7 
>   security-admin/db/oracle/patches/065-add-uk-on-x_rms_service_resource-resource_signature.sql PRE-CREATION 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 4d5a8cedf 
>   security-admin/db/postgres/patches/065-add-uk-on-x_rms_service_resource-resource_signature.sql PRE-CREATION 
>   security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 3ed2a5b9c 
>   security-admin/db/sqlanywhere/patches/065-add-uk-on-x_rms_service_resource-resource_signature.sql PRE-CREATION 
>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql ca8f7da1f 
>   security-admin/db/sqlserver/patches/065-add-uk-on-x_rms_service_resource-resource_signature.sql PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/74327/diff/2/
> 
> 
> Testing
> -------
> 
> Tested fresh and upgrade installation, This patch is removing the existing index and adding the unique index on resource_signature column of x_rms_service_resource table.
> Tested the patch for mysql, postgres and oracle DB flavors.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>