You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/06/25 05:50:11 UTC
[Impala-ASF-CR] IMPALA-8315: ignore rmtree errors in run stmt in hive()
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13720
Change subject: IMPALA-8315: ignore rmtree errors in run_stmt_in_hive()
......................................................................
IMPALA-8315: ignore rmtree errors in run_stmt_in_hive()
Per Joe's suggestion in the JIRA, we shouldn't fail the
test if rmtree() hits an error.
Change-Id: Ic303b61e4df0a7a3fcabbae812a6d2b9a8aa52df
---
M tests/common/impala_test_suite.py
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/13720/1
--
To view, visit http://gerrit.cloudera.org:8080/13720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic303b61e4df0a7a3fcabbae812a6d2b9a8aa52df
Gerrit-Change-Number: 13720
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8315: ignore rmtree errors in run stmt in hive()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13720 )
Change subject: IMPALA-8315: ignore rmtree errors in run_stmt_in_hive()
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3732/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic303b61e4df0a7a3fcabbae812a6d2b9a8aa52df
Gerrit-Change-Number: 13720
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 06:30:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8315: ignore rmtree errors in run stmt in hive()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13720 )
Change subject: IMPALA-8315: ignore rmtree errors in run_stmt_in_hive()
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4534/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic303b61e4df0a7a3fcabbae812a6d2b9a8aa52df
Gerrit-Change-Number: 13720
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 05:50:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8315: ignore rmtree errors in run stmt in hive()
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13720 )
Change subject: IMPALA-8315: ignore rmtree errors in run_stmt_in_hive()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic303b61e4df0a7a3fcabbae812a6d2b9a8aa52df
Gerrit-Change-Number: 13720
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 21:30:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8315: ignore rmtree errors in run stmt in hive()
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13720 )
Change subject: IMPALA-8315: ignore rmtree errors in run_stmt_in_hive()
......................................................................
IMPALA-8315: ignore rmtree errors in run_stmt_in_hive()
Per Joe's suggestion in the JIRA, we shouldn't fail the
test if rmtree() hits an error.
Change-Id: Ic303b61e4df0a7a3fcabbae812a6d2b9a8aa52df
Reviewed-on: http://gerrit.cloudera.org:8080/13720
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
---
M tests/common/impala_test_suite.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Joe McDonnell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic303b61e4df0a7a3fcabbae812a6d2b9a8aa52df
Gerrit-Change-Number: 13720
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8315: ignore rmtree errors in run stmt in hive()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13720 )
Change subject: IMPALA-8315: ignore rmtree errors in run_stmt_in_hive()
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic303b61e4df0a7a3fcabbae812a6d2b9a8aa52df
Gerrit-Change-Number: 13720
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 11:22:16 +0000
Gerrit-HasComments: No