You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@axis.apache.org by "Chris Darroch (JIRA)" <ji...@apache.org> on 2006/11/03 21:58:16 UTC

[jira] Created: (AXIS2C-384) CLONE -calls to NULL pointers in woden/src/wsdl10/part.c

CLONE -calls to NULL pointers in woden/src/wsdl10/part.c
--------------------------------------------------------

                 Key: AXIS2C-384
                 URL: http://issues.apache.org/jira/browse/AXIS2C-384
             Project: Axis2-C
          Issue Type: Bug
          Components: woden
    Affects Versions: Current (Nightly), 0.94
            Reporter: Chris Darroch
         Assigned To: Dinesh Premalal
            Priority: Minor
             Fix For: 0.95


In woden/src/wsdl10/msg_ref.c the following code is repeated often:

    if (!msg_ref)
    {
        msg_ref_impl = (woden_wsdl10_msg_ref_impl_t *) create(env);
    }
    else
        msg_ref_impl = (woden_wsdl10_msg_ref_impl_t *) msg_ref;

    woden_wsdl10_msg_ref_free_ops(msg_ref, env);

This won't actually work if msg_ref is NULL, because although create() runs OK, the
call to woden_wsdl10_msg_ref_free_ops() then fails with a segfault.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org


[jira] Updated: (AXIS2C-384) CLONE -calls to NULL pointers in woden/src/wsdl10/part.c

Posted by "Dinesh Premalal (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/AXIS2C-384?page=all ]

Dinesh Premalal updated AXIS2C-384:
-----------------------------------

        Fix Version/s: 0.96
                           (was: 0.95)
    Affects Version/s:     (was: Current (Nightly))

> CLONE -calls to NULL pointers in woden/src/wsdl10/part.c
> --------------------------------------------------------
>
>                 Key: AXIS2C-384
>                 URL: http://issues.apache.org/jira/browse/AXIS2C-384
>             Project: Axis2-C
>          Issue Type: Bug
>          Components: woden
>    Affects Versions: 0.94
>            Reporter: Chris Darroch
>         Assigned To: Dinesh Premalal
>            Priority: Minor
>             Fix For: 0.96
>
>
> In woden/src/wsdl10/msg_ref.c the following code is repeated often:
>     if (!msg_ref)
>     {
>         msg_ref_impl = (woden_wsdl10_msg_ref_impl_t *) create(env);
>     }
>     else
>         msg_ref_impl = (woden_wsdl10_msg_ref_impl_t *) msg_ref;
>     woden_wsdl10_msg_ref_free_ops(msg_ref, env);
> This won't actually work if msg_ref is NULL, because although create() runs OK, the
> call to woden_wsdl10_msg_ref_free_ops() then fails with a segfault.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org


[jira] Commented: (AXIS2C-384) CLONE -calls to NULL pointers in woden/src/wsdl10/part.c

Posted by "Dinesh Premalal (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/AXIS2C-384?page=comments#action_12449116 ] 
            
Dinesh Premalal commented on AXIS2C-384:
----------------------------------------

add a fix to  almost every where in the woden code. Please have a look.

> CLONE -calls to NULL pointers in woden/src/wsdl10/part.c
> --------------------------------------------------------
>
>                 Key: AXIS2C-384
>                 URL: http://issues.apache.org/jira/browse/AXIS2C-384
>             Project: Axis2-C
>          Issue Type: Bug
>          Components: woden
>    Affects Versions: 0.94
>            Reporter: Chris Darroch
>         Assigned To: Dinesh Premalal
>            Priority: Minor
>             Fix For: 0.96
>
>
> In woden/src/wsdl10/msg_ref.c the following code is repeated often:
>     if (!msg_ref)
>     {
>         msg_ref_impl = (woden_wsdl10_msg_ref_impl_t *) create(env);
>     }
>     else
>         msg_ref_impl = (woden_wsdl10_msg_ref_impl_t *) msg_ref;
>     woden_wsdl10_msg_ref_free_ops(msg_ref, env);
> This won't actually work if msg_ref is NULL, because although create() runs OK, the
> call to woden_wsdl10_msg_ref_free_ops() then fails with a segfault.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org


[jira] Commented: (AXIS2C-384) CLONE -calls to NULL pointers in woden/src/wsdl10/part.c

Posted by "Chris Darroch (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/AXIS2C-384?page=comments#action_12447077 ] 
            
Chris Darroch commented on AXIS2C-384:
--------------------------------------

While woden/src/wsdl10/msg_ref.c has been fixed, I see similar problems in
woden/src/wsdl10/part.c, for example:

    if (!part)
    {
        part_impl = (woden_wsdl10_part_impl_t *) create(env);
    }
    else
        part_impl = (woden_wsdl10_part_impl_t *) part;

    woden_wsdl10_part_free_ops(part, env);

I suspect there are other places where this occurs too ... I see some in
wsdl10_desc.c, and also over in woden/src/wsdl20/desc.c, etc.  Someone
will need to do a thorough seach through the code, I'm afraid.  Sorry!

> CLONE -calls to NULL pointers in woden/src/wsdl10/part.c
> --------------------------------------------------------
>
>                 Key: AXIS2C-384
>                 URL: http://issues.apache.org/jira/browse/AXIS2C-384
>             Project: Axis2-C
>          Issue Type: Bug
>          Components: woden
>    Affects Versions: Current (Nightly), 0.94
>            Reporter: Chris Darroch
>         Assigned To: Dinesh Premalal
>            Priority: Minor
>             Fix For: 0.95
>
>
> In woden/src/wsdl10/msg_ref.c the following code is repeated often:
>     if (!msg_ref)
>     {
>         msg_ref_impl = (woden_wsdl10_msg_ref_impl_t *) create(env);
>     }
>     else
>         msg_ref_impl = (woden_wsdl10_msg_ref_impl_t *) msg_ref;
>     woden_wsdl10_msg_ref_free_ops(msg_ref, env);
> This won't actually work if msg_ref is NULL, because although create() runs OK, the
> call to woden_wsdl10_msg_ref_free_ops() then fails with a segfault.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org


[jira] Resolved: (AXIS2C-384) CLONE -calls to NULL pointers in woden/src/wsdl10/part.c

Posted by "Dinesh Premalal (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/AXIS2C-384?page=all ]

Dinesh Premalal resolved AXIS2C-384.
------------------------------------

    Fix Version/s: Current (Nightly)
                       (was: 0.96)
       Resolution: Fixed

fixed !

> CLONE -calls to NULL pointers in woden/src/wsdl10/part.c
> --------------------------------------------------------
>
>                 Key: AXIS2C-384
>                 URL: http://issues.apache.org/jira/browse/AXIS2C-384
>             Project: Axis2-C
>          Issue Type: Bug
>          Components: woden
>    Affects Versions: 0.94
>            Reporter: Chris Darroch
>         Assigned To: Dinesh Premalal
>            Priority: Minor
>             Fix For: Current (Nightly)
>
>
> In woden/src/wsdl10/msg_ref.c the following code is repeated often:
>     if (!msg_ref)
>     {
>         msg_ref_impl = (woden_wsdl10_msg_ref_impl_t *) create(env);
>     }
>     else
>         msg_ref_impl = (woden_wsdl10_msg_ref_impl_t *) msg_ref;
>     woden_wsdl10_msg_ref_free_ops(msg_ref, env);
> This won't actually work if msg_ref is NULL, because although create() runs OK, the
> call to woden_wsdl10_msg_ref_free_ops() then fails with a segfault.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org


[jira] Commented: (AXIS2C-384) CLONE -calls to NULL pointers in woden/src/wsdl10/part.c

Posted by "Chris Darroch (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/AXIS2C-384?page=comments#action_12447080 ] 
            
Chris Darroch commented on AXIS2C-384:
--------------------------------------

I'm also not sure that this is completely fixed in msg_ref.c, as per AXIS2C-322.
If I read the new code there right, it will return NULL in the case where
msg_ref is NULL on input, because it never assigns the value of msg_ref_impl
that's created by create(env) back to msg_ref ... but then it returns msg_ref,
which will just be NULL.

Maybe I'm wrong; I haven't tested it.

> CLONE -calls to NULL pointers in woden/src/wsdl10/part.c
> --------------------------------------------------------
>
>                 Key: AXIS2C-384
>                 URL: http://issues.apache.org/jira/browse/AXIS2C-384
>             Project: Axis2-C
>          Issue Type: Bug
>          Components: woden
>    Affects Versions: Current (Nightly), 0.94
>            Reporter: Chris Darroch
>         Assigned To: Dinesh Premalal
>            Priority: Minor
>             Fix For: 0.95
>
>
> In woden/src/wsdl10/msg_ref.c the following code is repeated often:
>     if (!msg_ref)
>     {
>         msg_ref_impl = (woden_wsdl10_msg_ref_impl_t *) create(env);
>     }
>     else
>         msg_ref_impl = (woden_wsdl10_msg_ref_impl_t *) msg_ref;
>     woden_wsdl10_msg_ref_free_ops(msg_ref, env);
> This won't actually work if msg_ref is NULL, because although create() runs OK, the
> call to woden_wsdl10_msg_ref_free_ops() then fails with a segfault.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org