You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/02 12:17:00 UTC

[jira] [Commented] (THRIFT-4540) buffered transport broken when trying to re-open a formerly closed transport

    [ https://issues.apache.org/jira/browse/THRIFT-4540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422186#comment-16422186 ] 

ASF GitHub Bot commented on THRIFT-4540:
----------------------------------------

GitHub user Jens-G opened a pull request:

    https://github.com/apache/thrift/pull/1530

    THRIFT-4540 buffered transport broken when trying to re-open a former…

    …ly closed transport
    
    Client: Delphi
    Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Jens-G/thrift THRIFT-4540

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1530.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1530
    
----
commit 4d55a6c9ead4ce07bcbcacfa447ab03a424f8aeb
Author: Jens Geyer <je...@...>
Date:   2018-04-02T11:57:55Z

    THRIFT-4540 buffered transport broken when trying to re-open a formerly closed transport
    Client: Delphi
    Patch: Jens Geyer

----


> buffered transport broken when trying to re-open a formerly closed transport
> ----------------------------------------------------------------------------
>
>                 Key: THRIFT-4540
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4540
>             Project: Thrift
>          Issue Type: Bug
>          Components: Delphi - Library
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>            Priority: Major
>
> TBufferedTransportImpl does not properly set and clear all member vars, which leads to all kinds of strange errors after reopening a formerly closed stream. Root cause is that {{InitBuffers}} must be called when {{Open}}-ing the transport again to get the internal interface pointers aligned again. If this is not done, any read/write may either fail straight away, or may produce errors that indicate an invalid underlying transport.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)