You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/28 17:13:12 UTC

[GitHub] [beam] robinyqiu commented on pull request #11272: [BEAM-9641] Support ZetaSQL DATE type as a Beam LogicalType

robinyqiu commented on pull request #11272:
URL: https://github.com/apache/beam/pull/11272#issuecomment-620739925


   > What do you think about going ahead and defining the date logical type in `org.apache.beam.sdk.schemas.logicaltypes`? It would be useful in other contexts - for example it would give us something to map Avro's logical date type to (currently it is just overloaded with millis-instant onto DATETIME)
   
   Done. Thanks for the suggestion. I made the `Date` type a public logical type in `org.apache.beam.sdk.schemas.logicaltypes` and added a layer of indirection by letting `SqlTypes.DATE` reference it.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org