You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by ravikiran23 <gi...@git.apache.org> on 2016/09/07 13:13:02 UTC
[GitHub] incubator-carbondata pull request #135: changing the error message in delete...
GitHub user ravikiran23 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/135
changing the error message in delete by ID.
changing the error message in delete by ID.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ravikiran23/incubator-carbondata MessageChanges
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/135.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #135
----
commit e40953c7996ba4ccdf1cb5048e5a233d98f0d967
Author: ravikiran <ra...@gmail.com>
Date: 2016-09-07T13:09:40Z
changing the error message in delete by ID.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #135: [CARBONDATA-226]changing the error m...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/135
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #135: [CARBONDATA-226]changing the error m...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/135#discussion_r77953863
--- Diff: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala ---
@@ -931,11 +931,11 @@ private[sql] case class DeleteLoadsById(
if (invalidLoadIds.isEmpty) {
- LOGGER.audit(s"Delete load by Id is successfull for $databaseName.$tableName.")
+ LOGGER.audit(s"Delete segment by Id is successfull for $databaseName.$tableName.")
}
else {
- sys.error("Delete load by Id is failed. No matching load id found. SegmentSeqId(s) - "
- + invalidLoadIds)
+ sys.error("Delete segment by Id is failed. Invalid ID is :"
+ + invalidLoadIds.mkString(",") + ". Please check the log.")
--- End diff --
remove please check log message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---