You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/02/18 15:41:05 UTC
[GitHub] [ignite-3] sashapolo opened a new pull request #677: IGNITE-16583 Make Vault synchronous
sashapolo opened a new pull request #677:
URL: https://github.com/apache/ignite-3/pull/677
https://issues.apache.org/jira/browse/IGNITE-16583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ptupitsyn commented on pull request #677: IGNITE-16583 Make Vault synchronous
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on pull request #677:
URL: https://github.com/apache/ignite-3/pull/677#issuecomment-1044805183
`PersistentVaultService` uses RocksDB, which does synchronous disk IO. Ultimately this leads to a situation where Netty thread (e.g. `ClientInboundMessageHandler`) may be performing synchronous disk IO, which is not acceptable.
Currently, `PersistentVaultService` offloads those sync IO operations to a separate thread pool (`PersistentVaultService.threadPool`), which solves the problem.
**We have a different problem up the stack**: all `VaultManager` calls use `CompletableFuture.join()`, blocking the (Netty) thread. This is what needs to be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ptupitsyn removed a comment on pull request #677: IGNITE-16583 Make Vault synchronous
Posted by GitBox <gi...@apache.org>.
ptupitsyn removed a comment on pull request #677:
URL: https://github.com/apache/ignite-3/pull/677#issuecomment-1044805183
`PersistentVaultService` uses RocksDB, which does synchronous disk IO. Ultimately this leads to a situation where Netty thread (e.g. `ClientInboundMessageHandler`) may be performing synchronous disk IO, which is not acceptable.
Currently, `PersistentVaultService` offloads those sync IO operations to a separate thread pool (`PersistentVaultService.threadPool`), which solves the problem.
**We have a different problem up the stack**: all `VaultManager` calls use `CompletableFuture.join()`, blocking the (Netty) thread. This is what needs to be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org