Re: cvs commit:

[Remy Maucherat <re...@apache.org>]

> There seems to be no need for a JspxState object anymore.
> Jspx.State.tagCount is really not used, and JspxState.out can be
> make local.  I should just comment that out for now.

Hey, that's your code ;-)
It didn't seem very useful to me either, but that's only after I realized
that the PageContext would also get reused.

>   +                    out.printil("_bc.clear();");
>   +                    out.printil("out = _bc;");
>

> Can call to clear() be moved to pushBody()?

This method throws IOException, so that's why it's not in pushBody. The
BodyContent.clearBody() method could be used also, but it adds a try/catch.

>   +    protected BodyContent[] outs = new BodyContentImpl[0];

> Why not start the array with a small fixed size, say 5, to avoid all
> these copying.

The array is only alocated once per page context, so it's a not an issue.

Remy


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>