[GitHub] andrzej-kaczmarek commented on a change in pull request #198: nimble/host: Fixes for UUID handling

[GitBox <gi...@apache.org>]

andrzej-kaczmarek commented on a change in pull request #198: nimble/host: Fixes for UUID handling
URL: https://github.com/apache/mynewt-nimble/pull/198#discussion_r226728187
 
 

 ##########
 File path: nimble/host/src/ble_uuid.c
 ##########
 @@ -33,21 +33,12 @@ static uint8_t ble_uuid_base[16] = {
 };
 
 #if MYNEWT_VAL(BLE_HS_DEBUG)
-static int verify_uuid(const ble_uuid_t *uuid)
-{
-    switch (uuid->type) {
-    case BLE_UUID_TYPE_16:
-    case BLE_UUID_TYPE_32:
-        return 0;
-    case BLE_UUID_TYPE_128:
-        if (memcmp(BLE_UUID128(uuid)->value, ble_uuid_base, 12) != 0) {
 
 Review comment:
   if remote behaves incorrectly it will just fail and you will find the root cause in logs anyway

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services