You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by "Pieper, Aaron" <Pi...@Pragmatics.com> on 2011/02/09 20:00:25 UTC
Typo in LoggingInInterceptor constructor?
Is there a typo in the LoggingInInterceptor(String,String) constructor?
It seems to inaccurately call super(id, id) instead of super(id, phase).
I'm looking at r1058274 which appears to be the latest:
http://svn.apache.org/viewvc/cxf/trunk/rt/core/src/main/java/org/apache/
cxf/interceptor/LoggingInInterceptor.java?revision=1058274&view=markup
It seems accidental, given the invocations on lines 55 and 64 which
wouldn't make much sense if it were deliberate.
- Aaron
Re: Typo in LoggingInInterceptor constructor?
Posted by James Carr <ja...@gmail.com>.
Monster Energy drink? That's not a reward, that's a punishment. :)
On Wed, Feb 9, 2011 at 1:40 PM, Glen Mazza <gm...@talend.com> wrote:
> Hmm, seems like the CXF team owes Aaron a Monster energy drink (unless he's
> become partial to other beverages).
>
> Glen
>
> On 09.02.2011 14:00, Pieper, Aaron wrote:
>>
>> Is there a typo in the LoggingInInterceptor(String,String) constructor?
>> It seems to inaccurately call super(id, id) instead of super(id, phase).
>> I'm looking at r1058274 which appears to be the latest:
>>
>>
>>
>> http://svn.apache.org/viewvc/cxf/trunk/rt/core/src/main/java/org/apache/
>> cxf/interceptor/LoggingInInterceptor.java?revision=1058274&view=markup
>>
>>
>>
>> It seems accidental, given the invocations on lines 55 and 64 which
>> wouldn't make much sense if it were deliberate.
>>
>> - Aaron
>>
>
>
> --
> Glen Mazza
> Software Engineer, Talend (http://www.talend.com)
> blog: http://www.jroller.com/gmazza
>
>
>
Re: Typo in LoggingInInterceptor constructor?
Posted by Glen Mazza <gm...@talend.com>.
Thanks!
On 2/11/2011 4:26 AM, Willem Jiang wrote:
> Hi Glen,
>
> Your fix has some side effect, I just committed another patch[1] to fix
> the test error of SecurityPolicyTest.
>
> [1]http://svn.apache.org/viewvc?rev=1069716&view=rev
>
> Willem
>
> On 2/10/11 11:47 PM, Glen Mazza wrote:
>> Fixed on 2.3.2 and upcoming 2.4. Also, I checked the official CXF
>> treasury ($0.00), sorry no money for the Monster drink.
>>
>> Thanks,
>> Glen
>>
>> On 09.02.2011 14:40, Glen Mazza wrote:
>>> Hmm, seems like the CXF team owes Aaron a Monster energy drink (unless
>>> he's become partial to other beverages).
>>>
>>> Glen
>>>
>>> On 09.02.2011 14:00, Pieper, Aaron wrote:
>>>> Is there a typo in the LoggingInInterceptor(String,String) constructor?
>>>> It seems to inaccurately call super(id, id) instead of super(id, phase).
>>>> I'm looking at r1058274 which appears to be the latest:
>>>>
>>>>
>>>>
>>>> http://svn.apache.org/viewvc/cxf/trunk/rt/core/src/main/java/org/apache/
>>>> cxf/interceptor/LoggingInInterceptor.java?revision=1058274&view=markup
>>>>
>>>>
>>>>
>>>> It seems accidental, given the invocations on lines 55 and 64 which
>>>> wouldn't make much sense if it were deliberate.
>>>>
>>>> - Aaron
>>>>
>>
>
Re: Typo in LoggingInInterceptor constructor?
Posted by Willem Jiang <wi...@gmail.com>.
Hi Glen,
Your fix has some side effect, I just committed another patch[1] to fix
the test error of SecurityPolicyTest.
[1]http://svn.apache.org/viewvc?rev=1069716&view=rev
Willem
On 2/10/11 11:47 PM, Glen Mazza wrote:
> Fixed on 2.3.2 and upcoming 2.4. Also, I checked the official CXF
> treasury ($0.00), sorry no money for the Monster drink.
>
> Thanks,
> Glen
>
> On 09.02.2011 14:40, Glen Mazza wrote:
>> Hmm, seems like the CXF team owes Aaron a Monster energy drink (unless
>> he's become partial to other beverages).
>>
>> Glen
>>
>> On 09.02.2011 14:00, Pieper, Aaron wrote:
>>> Is there a typo in the LoggingInInterceptor(String,String) constructor?
>>> It seems to inaccurately call super(id, id) instead of super(id, phase).
>>> I'm looking at r1058274 which appears to be the latest:
>>>
>>>
>>>
>>> http://svn.apache.org/viewvc/cxf/trunk/rt/core/src/main/java/org/apache/
>>> cxf/interceptor/LoggingInInterceptor.java?revision=1058274&view=markup
>>>
>>>
>>>
>>> It seems accidental, given the invocations on lines 55 and 64 which
>>> wouldn't make much sense if it were deliberate.
>>>
>>> - Aaron
>>>
>>
>
>
--
Willem
----------------------------------
FuseSource
Web: http://www.fusesource.com
Blog: http://willemjiang.blogspot.com (English)
http://jnn.javaeye.com (Chinese)
Twitter: willemjiang
RE: Typo in LoggingInInterceptor constructor?
Posted by "Pieper, Aaron" <Pi...@Pragmatics.com>.
Ha ha no problem, Glen :) thanks for incorporating my change.
- Aaron
-----Original Message-----
From: Glen Mazza [mailto:gmazza@talend.com]
Sent: Thursday, February 10, 2011 10:48 AM
To: dev@cxf.apache.org
Subject: Re: Typo in LoggingInInterceptor constructor?
Fixed on 2.3.2 and upcoming 2.4. Also, I checked the official CXF
treasury ($0.00), sorry no money for the Monster drink.
Thanks,
Glen
On 09.02.2011 14:40, Glen Mazza wrote:
> Hmm, seems like the CXF team owes Aaron a Monster energy drink (unless
> he's become partial to other beverages).
>
> Glen
>
> On 09.02.2011 14:00, Pieper, Aaron wrote:
>> Is there a typo in the LoggingInInterceptor(String,String)
constructor?
>> It seems to inaccurately call super(id, id) instead of super(id,
phase).
>> I'm looking at r1058274 which appears to be the latest:
>>
>>
>>
>>
http://svn.apache.org/viewvc/cxf/trunk/rt/core/src/main/java/org/apache/
>>
cxf/interceptor/LoggingInInterceptor.java?revision=1058274&view=markup
>>
>>
>>
>> It seems accidental, given the invocations on lines 55 and 64 which
>> wouldn't make much sense if it were deliberate.
>>
>> - Aaron
>>
>
--
Glen Mazza
Software Engineer, Talend (http://www.talend.com)
blog: http://www.jroller.com/gmazza
Re: Typo in LoggingInInterceptor constructor?
Posted by Glen Mazza <gm...@talend.com>.
Fixed on 2.3.2 and upcoming 2.4. Also, I checked the official CXF
treasury ($0.00), sorry no money for the Monster drink.
Thanks,
Glen
On 09.02.2011 14:40, Glen Mazza wrote:
> Hmm, seems like the CXF team owes Aaron a Monster energy drink (unless
> he's become partial to other beverages).
>
> Glen
>
> On 09.02.2011 14:00, Pieper, Aaron wrote:
>> Is there a typo in the LoggingInInterceptor(String,String) constructor?
>> It seems to inaccurately call super(id, id) instead of super(id, phase).
>> I'm looking at r1058274 which appears to be the latest:
>>
>>
>>
>> http://svn.apache.org/viewvc/cxf/trunk/rt/core/src/main/java/org/apache/
>> cxf/interceptor/LoggingInInterceptor.java?revision=1058274&view=markup
>>
>>
>>
>> It seems accidental, given the invocations on lines 55 and 64 which
>> wouldn't make much sense if it were deliberate.
>>
>> - Aaron
>>
>
--
Glen Mazza
Software Engineer, Talend (http://www.talend.com)
blog: http://www.jroller.com/gmazza
Re: Typo in LoggingInInterceptor constructor?
Posted by Glen Mazza <gm...@talend.com>.
Hmm, seems like the CXF team owes Aaron a Monster energy drink (unless
he's become partial to other beverages).
Glen
On 09.02.2011 14:00, Pieper, Aaron wrote:
> Is there a typo in the LoggingInInterceptor(String,String) constructor?
> It seems to inaccurately call super(id, id) instead of super(id, phase).
> I'm looking at r1058274 which appears to be the latest:
>
>
>
> http://svn.apache.org/viewvc/cxf/trunk/rt/core/src/main/java/org/apache/
> cxf/interceptor/LoggingInInterceptor.java?revision=1058274&view=markup
>
>
>
> It seems accidental, given the invocations on lines 55 and 64 which
> wouldn't make much sense if it were deliberate.
>
> - Aaron
>
--
Glen Mazza
Software Engineer, Talend (http://www.talend.com)
blog: http://www.jroller.com/gmazza