You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/06 12:29:05 UTC
[GitHub] [dubbo-go] LaurenceLiZhixin opened a new pull request #1505: Fix: solve v3 zk/nacos service disc
LaurenceLiZhixin opened a new pull request #1505:
URL: https://github.com/apache/dubbo-go/pull/1505
Solve the bug of 3.0 zk/nacos app-level service discovery.
- Metadata service start in rootConfig.Start, instead of service-discovery registry, which is same as Java.
- Solve dubbo protocol metadata service port conflict.
- Always publish metadata to metadata service, which is same as Java, this would be useful for dubbogo-cli.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin merged pull request #1505: Fix: solve v3 zk/nacos service disc
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin merged pull request #1505:
URL: https://github.com/apache/dubbo-go/pull/1505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin merged pull request #1505: Fix: solve v3 zk/nacos service disc
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin merged pull request #1505:
URL: https://github.com/apache/dubbo-go/pull/1505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1505: Fix: solve v3 zk/nacos service disc
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1505:
URL: https://github.com/apache/dubbo-go/pull/1505#issuecomment-936304005
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1505?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1505](https://codecov.io/gh/apache/dubbo-go/pull/1505?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6ba7511) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/0b8429731b79878af2888c46f67b2f6c6ddd7519?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0b84297) will **increase** coverage by `0.05%`.
> The diff coverage is `32.81%`.
> :exclamation: Current head 6ba7511 differs from pull request most recent head 191b812. Consider uploading reports for the commit 191b812 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1505?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1505 +/- ##
==========================================
+ Coverage 42.06% 42.11% +0.05%
==========================================
Files 261 262 +1
Lines 15179 15182 +3
==========================================
+ Hits 6385 6394 +9
+ Misses 8046 8044 -2
+ Partials 748 744 -4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1505?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/extension/metadata\_service\_exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/1505/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlX2V4cG9ydGVyLmdv) | `0.00% <0.00%> (ø)` | |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1505/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `13.23% <0.00%> (-0.66%)` | :arrow_down: |
| [config/config\_resolver.go](https://codecov.io/gh/apache/dubbo-go/pull/1505/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19yZXNvbHZlci5nbw==) | `40.74% <ø> (ø)` | |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1505/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `24.65% <0.00%> (-0.70%)` | :arrow_down: |
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1505/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `9.39% <0.00%> (+0.07%)` | :arrow_up: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/1505/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `26.49% <0.00%> (ø)` | |
| [metadata/service/local/service.go](https://codecov.io/gh/apache/dubbo-go/pull/1505/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvc2VydmljZS9sb2NhbC9zZXJ2aWNlLmdv) | `74.07% <0.00%> (-1.12%)` | :arrow_down: |
| [...try/servicediscovery/service\_discovery\_registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1505/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zZXJ2aWNlX2Rpc2NvdmVyeV9yZWdpc3RyeS5nbw==) | `1.26% <ø> (+0.15%)` | :arrow_up: |
| [config/metadata\_report\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1505/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL21ldGFkYXRhX3JlcG9ydF9jb25maWcuZ28=) | `22.50% <28.57%> (-1.50%)` | :arrow_down: |
| [config/root\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1505/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Jvb3RfY29uZmlnLmdv) | `35.03% <44.73%> (-1.59%)` | :arrow_down: |
| ... and [5 more](https://codecov.io/gh/apache/dubbo-go/pull/1505/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1505?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1505?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0b84297...191b812](https://codecov.io/gh/apache/dubbo-go/pull/1505?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org